[Trigger] MUI Spell, Wait, Possible?

[Zwiebelchen]

The condition "equal to no Unit" will never be true unless ZS_Omnislash_Loop is reached or all units in range are removed/killed. Is that really the behaviour you want?

Also, EVERY unit in range will be damaged with every loop iteration. I don't think this is what you want! You only want tempPickedUnit to be damaged, don't you? Remove the "Pick every unit in tempGroup1" thing.

 

[deathismyfriend]

the group only runs every 30 iterations. so about every .9 seconds. but yes i doubt its what he wanted. i believe i told him about that but i cant remember lol

 

[MasterTrainer]

The condition "equal to no Unit" will never be true unless ZS_Omnislash_Loop is reached or all units in range are removed/killed. Is that really the behaviour you want?

Also, EVERY unit in range will be damaged with every loop iteration. I don't think this is what you want! You only want tempPickedUnit to be damaged, don't you? Remove the "Pick every unit in tempGroup1" thing.

But the Omnislashing should stop when TempUnit returns null right or when there are no more units to be omnislashed right? So after that the next and final phase takes place, then finally the de-indexing.

And if I remove the Pick every unit in tempgroup1, how will the war stomp phases deal damage?

 

[deathismyfriend]

Yes but i think he is wondering how the units get removed from the group.

not remove just move it. i dont think u want the damage dealt every .9 seconds.

 

[Zwiebelchen]

And if I remove the Pick every unit in tempgroup1, how will the war stomp phases deal damage?

That's no what I meant. When your unit is omnislashing, you only want the currently slashed unit to take damage, not all units in range, don't you?

 

[MasterTrainer]

That's no what I meant. When your unit is omnislashing, you only want the currently slashed unit to take damage, not all units in range, don't you?

Oh yes, but the Pick Every Unit in tempgroup 1 refers to the units in range from the caster when the final phase happens, not while omnislashing.

Anyways, I have updated the trigger:

Show

• ZS Loop
  • Events
    • Time - Every 0.03 seconds of game time
  • Conditions
  • Actions
    • For each (Integer ZS_CurrentIndex) from 1 to ZS_MaxIndex, do (Actions)
      • Loop - Actions
        • Set ZS_Counter[ZS_CurrentIndex] = (ZS_Counter[ZS_CurrentIndex] + 1)
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ZS_Counter[ZS_CurrentIndex] Equal to 30
          • Then - Actions
            • Set ZS_Counter[ZS_CurrentIndex] = 0
            • -------- [START] Circle War Stomp [START] --------
            • Set ZS_CasterLoc[ZS_CurrentIndex] = (Position of ZS_Caster[ZS_CurrentIndex])
            • Unit - Create 1 ZS_StartDummy for ZS_TempPlayer[ZS_CurrentIndex] at ZS_CasterLoc[ZS_CurrentIndex] facing Default building facing degrees
            • Set ZS_Dummy = (Last created unit)
            • For each (Integer ZS_CirclInt) from 1 to ZS_StartCircleNumber, do (Actions)
              • Loop - Actions
                • Set ZS_TempPoint = (ZS_CasterLoc[ZS_CurrentIndex] offset by ZS_StartCircleOffset towards ((Real(ZS_CirclInt)) x (360.00 / (Real(ZS_StartCircleNumber)))) degrees)
                • Custom script: call SetUnitPostionLoc(udg_ZS_Dummy, udg_ZS_TempPoint)
                • Animation - Add the birth animation tag to ZS_Dummy
                • Animation - Play ZS_Dummy's birth animation
            • Unit - Remove ZS_Dummy from the game
            • Set ZS_TempGroup1 = (Units within 300.00 of ZS_CasterLoc[ZS_CurrentIndex] matching (((Matching unit) belongs to an enemy of ZS_TempPlayer[ZS_CurrentIndex]) Equal to True))
            • Unit Group - Pick every unit in ZS_TempGroup1 and do (Actions)
              • Loop - Actions
                • Unit - Cause ZS_Caster[ZS_CurrentIndex] to damage (Picked unit), dealing ZS_StartCircleDamage damage of attack type Chaos and damage type Divine
            • Custom script: call DestroyGroup(udg_ZS_TempGroup1)
            • Custom script: call RemoveLocation(udg_ZS_TempPoint)
            • -------- [END] Circle War Stomp [END] --------
            • -------- [START] Omnislash[START] --------
            • For each (Integer ZS_LoopInt) from 1 to ZS_Omnislash_Loop, do (Actions)
              • Loop - Actions
                • Set ZS_TempGroup1 = (Units within ZS_Omnislash_Range of ZS_CasterLoc[ZS_CurrentIndex] matching ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) is alive) Equal to True) and ((((Matching unit) belongs to an enemy of ZS_TempPlayer[ZS_CurrentIndex]) Equal t
                • Set ZS_TempGroup2 = (Random 1 units from ZS_TempGroup1)
                • Custom script: set udg_ZS_PickedUnit[udg_ZS_CurrentIndex] = FirstOfGroup( udg_ZS_TempGroup2)
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • ZS_PickedUnit[ZS_CurrentIndex] Equal to No unit
                  • Then - Actions
                    • -------- Fnial Phase and De-indexing --------
                    • -------- [START] Final Circle War Stomp [START] --------
                    • Set ZS_CasterLoc[ZS_CurrentIndex] = (Position of ZS_Caster[ZS_CurrentIndex])
                    • Unit - Create 1 ZS_FinalDummy for ZS_TempPlayer[ZS_CurrentIndex] at ZS_CasterLoc[ZS_CurrentIndex] facing Default building facing degrees
                    • Set ZS_Dummy = (Last created unit)
                    • For each (Integer ZS_CirclInt) from 1 to ZS_FinalCircleNumber, do (Actions)
                      • Loop - Actions
                        • Set ZS_TempPoint = (ZS_CasterLoc[ZS_CurrentIndex] offset by ZS_FinalCircleOffset towards ((Real(ZS_CirclInt)) x (360.00 / (Real(ZS_FinalCircleNumber)))) degrees)
                        • Custom script: call SetUnitPostionLoc(udg_ZS_Dummy, udg_ZS_TempPoint)
                        • Animation - Add the birth animation tag to ZS_Dummy
                        • Animation - Play ZS_Dummy's birth animation
                    • Unit - Remove ZS_Dummy from the game
                    • Unit Group - Pick every unit in ZS_TempGroup1 and do (Actions)
                      • Loop - Actions
                        • Unit - Cause ZS_Caster[ZS_CurrentIndex] to damage (Picked unit), dealing ZS_FinalCircleDamage damage of attack type Chaos and damage type Divine
                    • -------- [END] Final Circle War Stomp [END] --------
                    • Custom script: call DestroyGroup(udg_ZS_TempGroup1)
                    • Custom script: call RemoveLocation(udg_ZS_TempPoint)
                    • Custom script: call RemoveLocation(udg_ZS_CasterLoc[udg_ZS_CurrentIndex])
                    • Custom script: set udg_ZS_TempPoint = null
                    • -------- Recycling --------
                    • Set ZS_Caster[ZS_CurrentIndex] = ZS_Caster[ZS_MaxIndex]
                    • Set ZS_CasterLoc[ZS_CurrentIndex] = ZS_CasterLoc[ZS_MaxIndex]
                    • Set ZS_Counter[ZS_CurrentIndex] = ZS_Counter[ZS_MaxIndex]
                    • Set ZS_TempPlayer[ZS_CurrentIndex] = ZS_TempPlayer[ZS_MaxIndex]
                    • Set ZS_Omniboolean[ZS_CurrentIndex] = ZS_Omniboolean[ZS_MaxIndex]
                    • Set ZS_MaxIndex = (ZS_MaxIndex - 1)
                    • Set ZS_CurrentIndex = (ZS_CurrentIndex - 1)
                    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                      • If - Conditions
                        • ZS_MaxIndex Equal to 0
                      • Then - Actions
                        • Trigger - Turn off (This trigger)
                      • Else - Actions
                    • -------- Instance Recycled --------
                    • -------- End Loop --------
                    • -------- End Cast --------
                  • Else - Actions
                    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                      • If - Conditions
                        • (Number of units in ZS_TempGroup2) Greater than 0
                      • Then - Actions
                        • Animation - Change ZS_Caster[ZS_CurrentIndex]'s vertex coloring to (100.00%, 100.00%, 100.00%) with 50.00% transparency
                        • Animation - Change ZS_Caster[ZS_CurrentIndex]'s animation speed to 50.00% of its original speed
                        • Unit Group - Pick every unit in ZS_TempGroup2 and do (Actions)
                          • Loop - Actions
                            • Set ZS_PickedUnitLoc[ZS_CurrentIndex] = (Position of ZS_PickedUnit[ZS_CurrentIndex])
                            • Custom script: call SetUnitPositionLoc( udg_ZS_Caster[udg_ZS_CurrentIndex], udg_ZS_PickedUnitLoc[udg_ZS_CurrentIndex])
                            • Custom script: call RemoveLocation( udg_ZS_PickedUnitLoc[udg_ZS_CurrentIndex])
                            • Custom script: set udg_ZS_PickedUnitLoc[udg_ZS_CurrentIndex] = null
                            • Animation - Play ZS_Caster[ZS_CurrentIndex]'s ZS_Omnislash_AttackAnim animation
                            • Unit - Cause ZS_Caster[ZS_CurrentIndex] to damage ZS_PickedUnit[ZS_CurrentIndex], dealing ZS_Omnislash_Damage damage of attack type ZS_Omnislash_AttackType and damage type ZS_Omnislash_DamageType
                            • Unit Group - Remove ZS_PickedUnit[ZS_CurrentIndex] from ZS_TempGroup2
                            • Special Effect - Create a special effect attached to the ZS_Omnislash_AttachPoint of ZS_Caster[ZS_CurrentIndex] using ZS_Omnislash_Sfx
                            • Special Effect - Destroy (Last created special effect)
                        • Custom script: call DestroyGroup( udg_ZS_TempGroup1)
                        • Custom script: call DestroyGroup( udg_ZS_TempGroup2)
                        • Animation - Change ZS_Caster[ZS_CurrentIndex]'s vertex coloring to (100.00%, 100.00%, 100.00%) with 0.00% transparency
                        • Animation - Change ZS_Caster[ZS_CurrentIndex]'s animation speed to 100.00% of its original speed
                        • Set ZS_Omniboolean[ZS_CurrentIndex] = True
                      • Else - Actions
                        • Custom script: call DestroyGroup( udg_ZS_TempGroup1)
                        • Custom script: call DestroyGroup( udg_ZS_TempGroup2)
                        • Set ZS_Omniboolean[ZS_CurrentIndex] = False
            • -------- [END] Omnislash[END] --------
          • Else - Actions

 

[Zwiebelchen]

So does it work or not? If not, what exactly is not working?

 

[MasterTrainer]

Okay I decided to put the Omnislash phase in another trigger, and I set it up with a different integer variable for MaxIndex and CurrentIndex and the counter.

But the Omnislash doesn't work. Help.

Show Triggers

AtCast

• ZS Cast
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Zephyr Strike
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ZS_MaxIndex Equal to 0
      • Then - Actions
        • -------- If no instance is running, we turn on the loop --------
        • Trigger - Turn on ZS Loop <gen>
      • Else - Actions
    • Set ZS_MaxIndex = (ZS_MaxIndex + 1)
    • Set ZS_OmniMaxIndex = (ZS_OmniMaxIndex + 1)
    • Set ZS_OmniCounter[ZS_OmniMaxIndex] = 0
    • Set ZS_Caster[ZS_MaxIndex] = (Triggering unit)
    • Set ZS_CasterLoc[ZS_MaxIndex] = (Position of ZS_Caster[ZS_MaxIndex])
    • Set ZS_TempPlayer[ZS_MaxIndex] = (Owner of ZS_Caster[ZS_MaxIndex])
    • Set ZS_Counter[ZS_MaxIndex] = 0
    • Set ZS_Omniboolean[ZS_MaxIndex] = False

Loop

• ZS Loop
  • Events
    • Time - Every 0.03 seconds of game time
  • Conditions
  • Actions
    • For each (Integer ZS_CurrentIndex) from 1 to ZS_MaxIndex, do (Actions)
      • Loop - Actions
        • Set ZS_Counter[ZS_CurrentIndex] = (ZS_Counter[ZS_CurrentIndex] + 1)
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ZS_Counter[ZS_CurrentIndex] Equal to 30
          • Then - Actions
            • -------- [START] Circle War Stomp [START] --------
            • Set ZS_CasterLoc[ZS_CurrentIndex] = (Position of ZS_Caster[ZS_CurrentIndex])
            • For each (Integer ZS_CirclInt) from 1 to ZS_StartCircleNumber, do (Actions)
              • Loop - Actions
                • Set ZS_TempPoint[ZS_CurrentIndex] = (ZS_CasterLoc[ZS_CurrentIndex] offset by ZS_StartCircleOffset towards ((Real(ZS_CirclInt)) x (360.00 / (Real(ZS_StartCircleNumber)))) degrees)
                • Unit - Create 1 ZS_StartDummy for ZS_TempPlayer[ZS_CurrentIndex] at ZS_TempPoint[ZS_CurrentIndex] facing Default building facing degrees
                • Set ZS_Dummy[ZS_CirclInt] = (Last created unit)
                • Unit - Add a 0.30 second Generic expiration timer to ZS_Dummy[ZS_CirclInt]
            • Set ZS_TempGroup1[ZS_CurrentIndex] = (Units within 300.00 of ZS_CasterLoc[ZS_CurrentIndex] matching (((Matching unit) belongs to an enemy of ZS_TempPlayer[ZS_CurrentIndex]) Equal to True))
            • Unit Group - Pick every unit in ZS_TempGroup1[ZS_CurrentIndex] and do (Actions)
              • Loop - Actions
                • Unit - Cause ZS_Caster[ZS_CurrentIndex] to damage (Picked unit), dealing ZS_StartCircleDamage damage of attack type Chaos and damage type Divine
            • Custom script: call DestroyGroup(udg_ZS_TempGroup1[udg_ZS_CurrentIndex])
            • Custom script: call RemoveLocation(udg_ZS_TempPoint[udg_ZS_CurrentIndex])
            • -------- [END] Circle War Stomp [END] --------
            • -------- [START] Omnislash[START] --------
            • Trigger - Turn on ZS Omnislash Loop <gen>
            • -------- [END] Omnislash[END] --------
            • -------- [START] Final Circle War Stomp [START] --------
            • Set ZS_CasterLoc[ZS_CurrentIndex] = (Position of ZS_Caster[ZS_CurrentIndex])
            • For each (Integer ZS_CirclInt) from 1 to ZS_FinalCircleNumber, do (Actions)
              • Loop - Actions
                • Set ZS_TempPoint[ZS_CurrentIndex] = (ZS_CasterLoc[ZS_CurrentIndex] offset by ZS_FinalCircleOffset towards ((Real(ZS_CirclInt)) x (360.00 / (Real(ZS_FinalCircleNumber)))) degrees)
                • Unit - Create 1 ZS_FinalDummy for ZS_TempPlayer[ZS_CurrentIndex] at ZS_TempPoint[ZS_CurrentIndex] facing Default building facing degrees
                • Set ZS_Dummy[ZS_CirclInt] = (Last created unit)
                • Unit - Add a 0.30 second Generic expiration timer to ZS_Dummy[ZS_CirclInt]
            • Unit Group - Pick every unit in ZS_TempGroup1[ZS_CurrentIndex] and do (Actions)
              • Loop - Actions
                • Unit - Cause ZS_Caster[ZS_CurrentIndex] to damage (Picked unit), dealing ZS_FinalCircleDamage damage of attack type Chaos and damage type Divine
            • -------- [END] Final Circle War Stomp [END] --------
            • Custom script: call DestroyGroup(udg_ZS_TempGroup1[udg_ZS_CurrentIndex])
            • Custom script: call RemoveLocation(udg_ZS_TempPoint[udg_ZS_CurrentIndex])
            • Custom script: call RemoveLocation(udg_ZS_CasterLoc[udg_ZS_CurrentIndex])
            • Custom script: set udg_ZS_TempPoint[udg_ZS_CurrentIndex] = null
            • -------- Recycling --------
            • Set ZS_Caster[ZS_CurrentIndex] = ZS_Caster[ZS_MaxIndex]
            • Set ZS_CasterLoc[ZS_CurrentIndex] = ZS_CasterLoc[ZS_MaxIndex]
            • Set ZS_Counter[ZS_CurrentIndex] = ZS_Counter[ZS_MaxIndex]
            • Set ZS_TempPlayer[ZS_CurrentIndex] = ZS_TempPlayer[ZS_MaxIndex]
            • Set ZS_Omniboolean[ZS_CurrentIndex] = ZS_Omniboolean[ZS_MaxIndex]
            • Set ZS_MaxIndex = (ZS_MaxIndex - 1)
            • Set ZS_CurrentIndex = (ZS_CurrentIndex - 1)
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • ZS_MaxIndex Equal to 0
              • Then - Actions
                • Trigger - Turn off (This trigger)
              • Else - Actions
            • -------- Instance Recycled --------
            • -------- End Loop --------
            • -------- End Cast --------
          • Else - Actions

Omnislash Loop

• ZS Omnislash Loop
  • Events
    • Time - Every 1.00 seconds of game time
  • Conditions
  • Actions
    • For each (Integer ZS_OmniCurrentIndex) from 1 to ZS_OmniMaxIndex, do (Actions)
      • Loop - Actions
        • Set ZS_OmniCounter[ZS_OmniCurrentIndex] = (ZS_OmniCounter[ZS_OmniCurrentIndex] + 1)
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ZS_OmniCurrentIndex Equal to 1
          • Then - Actions
            • For each (Integer ZS_LoopInt) from 1 to ZS_Omnislash_Loop, do (Actions)
              • Loop - Actions
                • Set ZS_TempGroup1[ZS_OmniCurrentIndex] = (Units within ZS_Omnislash_Range of ZS_CasterLoc[ZS_OmniCurrentIndex] matching ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) is alive) Equal to True) and ((((Matching unit) belongs to an enemy of ZS_TempPlayer[ZS_OmniCurrentIndex])
                • Set ZS_TempGroup2[ZS_OmniCurrentIndex] = (Random 1 units from ZS_TempGroup1[ZS_OmniCurrentIndex])
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • (Number of units in ZS_TempGroup1[ZS_OmniCurrentIndex]) Greater than 0
                  • Then - Actions
                    • Animation - Change ZS_Caster[ZS_OmniCurrentIndex]'s vertex coloring to (100.00%, 100.00%, 100.00%) with 50.00% transparency
                    • Animation - Change ZS_Caster[ZS_OmniCurrentIndex]'s animation speed to 50.00% of its original speed
                    • Unit Group - Pick every unit in ZS_TempGroup2[ZS_CurrentIndex] and do (Actions)
                      • Loop - Actions
                        • Set ZS_OmniCounter[ZS_OmniCurrentIndex] = 0
                        • Set ZS_PickedUnit[ZS_OmniCurrentIndex] = (Picked unit)
                        • Set ZS_PickedUnitLoc[ZS_OmniCurrentIndex] = (Position of ZS_PickedUnit[ZS_CurrentIndex])
                        • Custom script: call SetUnitPositionLoc( udg_ZS_Caster[udg_ZS_OmniCurrentIndex], udg_ZS_PickedUnitLoc[udg_ZS_OmniCurrentIndex])
                        • Special Effect - Create a special effect at ZS_PickedUnitLoc[ZS_OmniCurrentIndex] using war3mapImported\blazingwind.MDX
                        • Special Effect - Destroy (Last created special effect)
                        • Custom script: call RemoveLocation( udg_ZS_PickedUnitLoc[udg_ZS_OmniCurrentIndex])
                        • Custom script: set udg_ZS_PickedUnitLoc[udg_ZS_OmniCurrentIndex] = null
                        • Animation - Play ZS_Caster[ZS_OmniCurrentIndex]'s ZS_Omnislash_AttackAnim animation
                        • Unit - Cause ZS_Caster[ZS_OmniCurrentIndex] to damage ZS_PickedUnit[ZS_OmniCurrentIndex], dealing ZS_Omnislash_Damage damage of attack type ZS_Omnislash_AttackType and damage type ZS_Omnislash_DamageType
                        • Unit Group - Remove ZS_PickedUnit[ZS_OmniCurrentIndex] from ZS_TempGroup2[ZS_OmniCurrentIndex]
                        • Special Effect - Create a special effect attached to the ZS_Omnislash_AttachPoint of ZS_Caster[ZS_OmniCurrentIndex] using ZS_Omnislash_Sfx
                        • Special Effect - Destroy (Last created special effect)
                    • Custom script: call DestroyGroup( udg_ZS_TempGroup1[udg_ZS_OmniCurrentIndex])
                    • Custom script: call DestroyGroup( udg_ZS_TempGroup2[udg_ZS_OmniCurrentIndex])
                    • Animation - Change ZS_Caster[ZS_OmniCurrentIndex]'s vertex coloring to (100.00%, 100.00%, 100.00%) with 0.00% transparency
                    • Animation - Change ZS_Caster[ZS_OmniCurrentIndex]'s animation speed to 100.00% of its original speed
                    • Set ZS_Omniboolean[ZS_OmniCurrentIndex] = True
                  • Else - Actions
                    • Custom script: call DestroyGroup( udg_ZS_TempGroup1[udg_ZS_OmniCurrentIndex])
                    • Custom script: call DestroyGroup( udg_ZS_TempGroup2[udg_ZS_OmniCurrentIndex])
                    • Set ZS_Omniboolean[ZS_CurrentIndex] = False
            • Set ZS_OmniCounter[ZS_OmniCurrentIndex] = ZS_OmniCounter[ZS_OmniMaxIndex]
            • Set ZS_OmniMaxIndex = (ZS_OmniMaxIndex - 1)
            • Set ZS_OmniCurrentIndex = (ZS_OmniCurrentIndex - 1)
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • ZS_MaxIndex Equal to 0
              • Then - Actions
                • Set ZS_OmniCounter[ZS_OmniCurrentIndex] = 0
                • Trigger - Turn off (This trigger)
              • Else - Actions
          • Else - Actions

 

[deathismyfriend]

u shouldnt of split it up. Reals are inaccurate so the 2 loops wont sync up like that. Also since u use a .03 its not gonna be the right interval in time.

 

[MasterTrainer]

How about if I both use .03 as events?

 

[deathismyfriend]

the lower the time the more inaccurate. it will never be exactly .03 for both triggers. The time ranges but when using .03 if the one keeps going at .031 and the other keeps going at .030. It will be quiet a bit off. Enough to notice in a long spell. It may also be frowned upon to add an extra trigger. Also it can cause ur trigger to bug up if a unit is moved in both of these.

Either way u should switch it back to one trigger it would be easier to manage and control

 

[MasterTrainer]

Okay... but before I split it up I did do something.
I tried this:

• Set ZS_Wait[ZS_CurrentIndex] = 0.50
• Wait - Wait ZS_wait[ZS_CurrentIndex] seconds

Although waits are inaccurate, what I'm still trying to figure out is why it did not wait. Btw I put it in the loop in the Omnislash phase.

 

[deathismyfriend]

it probably didnt wait because the wait got overwritten.

You should never need a wait in a spell. use a counter to count up the time and then do actions when timer hits the time u want.

 

[MasterTrainer]

How about if I use a countdown timer- nah it's not going to work because I have to make another trigger...

Hmm... how do I use a counter in the Omnislash phase?

 

[deathismyfriend]

every iteration increase counter by 1. When it hits the number do the actions

 

[MasterTrainer]

Just to clarify I'm going to use an integer counter right?

 

[deathismyfriend]

yes.

 

[MasterTrainer]

Okay I tried using the counter, but no matter how high I go, it just won't wait. Help?

Show Trigger

• ZS Loop
  • Events
    • Time - Every 0.03 seconds of game time
  • Conditions
  • Actions
    • For each (Integer ZS_CurrentIndex) from 1 to ZS_MaxIndex, do (Actions)
      • Loop - Actions
        • Set ZS_Counter[ZS_CurrentIndex] = (ZS_Counter[ZS_CurrentIndex] + 1)
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ZS_Counter[ZS_CurrentIndex] Equal to 30
          • Then - Actions
            • -------- [START] Circle War Stomp [START] --------
            • Set ZS_CasterLoc[ZS_CurrentIndex] = (Position of ZS_Caster[ZS_CurrentIndex])
            • For each (Integer ZS_CirclInt) from 1 to ZS_StartCircleNumber, do (Actions)
              • Loop - Actions
                • Set ZS_TempPoint[ZS_CurrentIndex] = (ZS_CasterLoc[ZS_CurrentIndex] offset by ZS_StartCircleOffset towards ((Real(ZS_CirclInt)) x (360.00 / (Real(ZS_StartCircleNumber)))) degrees)
                • Unit - Create 1 ZS_StartDummy for ZS_TempPlayer[ZS_CurrentIndex] at ZS_TempPoint[ZS_CurrentIndex] facing Default building facing degrees
                • Set ZS_Dummy[ZS_CirclInt] = (Last created unit)
                • Unit - Add a 0.30 second Generic expiration timer to ZS_Dummy[ZS_CirclInt]
            • Set ZS_TempGroup1[ZS_CurrentIndex] = (Units within 300.00 of ZS_CasterLoc[ZS_CurrentIndex] matching (((Matching unit) belongs to an enemy of ZS_TempPlayer[ZS_CurrentIndex]) Equal to True))
            • Unit Group - Pick every unit in ZS_TempGroup1[ZS_CurrentIndex] and do (Actions)
              • Loop - Actions
                • Unit - Cause ZS_Caster[ZS_CurrentIndex] to damage (Picked unit), dealing ZS_StartCircleDamage damage of attack type Chaos and damage type Divine
            • Custom script: call DestroyGroup(udg_ZS_TempGroup1[udg_ZS_CurrentIndex])
            • Custom script: call RemoveLocation(udg_ZS_TempPoint[udg_ZS_CurrentIndex])
            • -------- [END] Circle War Stomp [END] --------
            • -------- [START] Omnislash[START] --------
            • For each (Integer ZS_LoopInt) from 1 to ZS_Omnislash_Loop, do (Actions)
              • Loop - Actions
                • Set ZS_TempCounter[ZS_CurrentIndex] = 0
                • For each (Integer ZS_TempInt) from 1 to 50, do (Actions)
                  • Loop - Actions
                    • Set ZS_TempCounter[ZS_CurrentIndex] = (ZS_TempCounter[ZS_CurrentIndex] + 1)
                    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                      • If - Conditions
                        • ZS_TempCounter[ZS_CurrentIndex] Equal to 50
                      • Then - Actions
                        • Set ZS_TempGroup1[ZS_CurrentIndex] = (Units within ZS_Omnislash_Range of ZS_CasterLoc[ZS_CurrentIndex] matching ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) is alive) Equal to True) and ((((Matching unit) belongs to an enemy of ZS_TempPlayer[ZS_CurrentIndex]) Equal t
                        • Set ZS_TempGroup2[ZS_CurrentIndex] = (Random 1 units from ZS_TempGroup1[ZS_CurrentIndex])
                        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                          • If - Conditions
                            • (Number of units in ZS_TempGroup1[ZS_CurrentIndex]) Greater than 0
                          • Then - Actions
                            • Animation - Change ZS_Caster[ZS_CurrentIndex]'s vertex coloring to (100.00%, 100.00%, 100.00%) with 50.00% transparency
                            • Animation - Change ZS_Caster[ZS_CurrentIndex]'s animation speed to 50.00% of its original speed
                            • Unit Group - Pick every unit in ZS_TempGroup2[ZS_CurrentIndex] and do (Actions)
                              • Loop - Actions
                                • Set ZS_PickedUnit[ZS_CurrentIndex] = (Picked unit)
                                • Set ZS_PickedUnitLoc[ZS_CurrentIndex] = (Position of ZS_PickedUnit[ZS_CurrentIndex])
                                • Custom script: call SetUnitPositionLoc( udg_ZS_Caster[udg_ZS_CurrentIndex], udg_ZS_PickedUnitLoc[udg_ZS_CurrentIndex])
                                • Special Effect - Create a special effect at ZS_PickedUnitLoc[ZS_CurrentIndex] using war3mapImported\blazingwind.MDX
                                • Special Effect - Destroy (Last created special effect)
                                • Custom script: call RemoveLocation( udg_ZS_PickedUnitLoc[udg_ZS_CurrentIndex])
                                • Custom script: set udg_ZS_PickedUnitLoc[udg_ZS_CurrentIndex] = null
                                • Animation - Play ZS_Caster[ZS_CurrentIndex]'s ZS_Omnislash_AttackAnim animation
                                • Unit - Cause ZS_Caster[ZS_CurrentIndex] to damage ZS_PickedUnit[ZS_CurrentIndex], dealing ZS_Omnislash_Damage damage of attack type ZS_Omnislash_AttackType and damage type ZS_Omnislash_DamageType
                                • Unit Group - Remove ZS_PickedUnit[ZS_CurrentIndex] from ZS_TempGroup2[ZS_CurrentIndex]
                                • Special Effect - Create a special effect attached to the ZS_Omnislash_AttachPoint of ZS_Caster[ZS_CurrentIndex] using ZS_Omnislash_Sfx
                                • Special Effect - Destroy (Last created special effect)
                            • Custom script: call DestroyGroup( udg_ZS_TempGroup1[udg_ZS_CurrentIndex])
                            • Custom script: call DestroyGroup( udg_ZS_TempGroup2[udg_ZS_CurrentIndex])
                            • Animation - Change ZS_Caster[ZS_CurrentIndex]'s vertex coloring to (100.00%, 100.00%, 100.00%) with 0.00% transparency
                            • Animation - Change ZS_Caster[ZS_CurrentIndex]'s animation speed to 100.00% of its original speed
                            • Set ZS_Omniboolean[ZS_CurrentIndex] = True
                          • Else - Actions
                            • Custom script: call DestroyGroup( udg_ZS_TempGroup1[udg_ZS_CurrentIndex])
                            • Custom script: call DestroyGroup( udg_ZS_TempGroup2[udg_ZS_CurrentIndex])
                            • Set ZS_Omniboolean[ZS_CurrentIndex] = False
                      • Else - Actions
            • -------- [END] Omnislash[END] --------
            • -------- [START] Final Circle War Stomp [START] --------
            • Set ZS_CasterLoc[ZS_CurrentIndex] = (Position of ZS_Caster[ZS_CurrentIndex])
            • For each (Integer ZS_CirclInt) from 1 to ZS_FinalCircleNumber, do (Actions)
              • Loop - Actions
                • Set ZS_TempPoint[ZS_CurrentIndex] = (ZS_CasterLoc[ZS_CurrentIndex] offset by ZS_FinalCircleOffset towards ((Real(ZS_CirclInt)) x (360.00 / (Real(ZS_FinalCircleNumber)))) degrees)
                • Unit - Create 1 ZS_FinalDummy for ZS_TempPlayer[ZS_CurrentIndex] at ZS_TempPoint[ZS_CurrentIndex] facing Default building facing degrees
                • Set ZS_Dummy[ZS_CirclInt] = (Last created unit)
                • Unit - Add a 0.30 second Generic expiration timer to ZS_Dummy[ZS_CirclInt]
            • Unit Group - Pick every unit in ZS_TempGroup1[ZS_CurrentIndex] and do (Actions)
              • Loop - Actions
                • Unit - Cause ZS_Caster[ZS_CurrentIndex] to damage (Picked unit), dealing ZS_FinalCircleDamage damage of attack type Chaos and damage type Divine
            • -------- [END] Final Circle War Stomp [END] --------
            • Custom script: call DestroyGroup(udg_ZS_TempGroup1[udg_ZS_CurrentIndex])
            • Custom script: call RemoveLocation(udg_ZS_TempPoint[udg_ZS_CurrentIndex])
            • Custom script: call RemoveLocation(udg_ZS_CasterLoc[udg_ZS_CurrentIndex])
            • Custom script: set udg_ZS_TempPoint[udg_ZS_CurrentIndex] = null
            • -------- Recycling --------
            • Set ZS_Caster[ZS_CurrentIndex] = ZS_Caster[ZS_MaxIndex]
            • Set ZS_CasterLoc[ZS_CurrentIndex] = ZS_CasterLoc[ZS_MaxIndex]
            • Set ZS_Counter[ZS_CurrentIndex] = ZS_Counter[ZS_MaxIndex]
            • Set ZS_TempPlayer[ZS_CurrentIndex] = ZS_TempPlayer[ZS_MaxIndex]
            • Set ZS_Omniboolean[ZS_CurrentIndex] = ZS_Omniboolean[ZS_MaxIndex]
            • Set ZS_MaxIndex = (ZS_MaxIndex - 1)
            • Set ZS_CurrentIndex = (ZS_CurrentIndex - 1)
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • ZS_MaxIndex Equal to 0
              • Then - Actions
                • Trigger - Turn off (This trigger)
              • Else - Actions
            • -------- Instance Recycled --------
            • -------- End Loop --------
            • -------- End Cast --------
          • Else - Actions

 

[deathismyfriend]

this is ur problem right here.....

• For each (Integer ZS_LoopInt) from 1 to ZS_Omnislash_Loop, do (Actions)
• Loop - Actions
  • Set ZS_TempCounter[ZS_CurrentIndex] = 0
  • For each (Integer ZS_TempInt) from 1 to 50, do (Actions)
    • Loop - Actions
    • Set ZS_TempCounter[ZS_CurrentIndex] = (ZS_TempCounter[ZS_CurrentIndex] + 1)
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ZS_TempCounter[ZS_CurrentIndex] Equal to 50

every .03 seconds u increase this integer by 50. so it runs every .03 seconds. You need to get rid of all of these integer loops

 

[MasterTrainer]

this is ur problem right here.....

• For each (Integer ZS_LoopInt) from 1 to ZS_Omnislash_Loop, do (Actions)
• Loop - Actions
  • Set ZS_TempCounter[ZS_CurrentIndex] = 0
  • For each (Integer ZS_TempInt) from 1 to 50, do (Actions)
    • Loop - Actions
    • Set ZS_TempCounter[ZS_CurrentIndex] = (ZS_TempCounter[ZS_CurrentIndex] + 1)
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ZS_TempCounter[ZS_CurrentIndex] Equal to 50

every .03 seconds u increase this integer by 50. so it runs every .03 seconds. You need to get rid of all of these integer loops

If I get rid of all of those integer loops the Omnislash will literally hit only one enemy... what do you mean?

 

[deathismyfriend]

u only make it hit one enemy every .5 seconds or so. Dont hit every unit every .03 seconds.

 

[MasterTrainer]

So do I remove the two loops?

 

[deathismyfriend]

u have to remove them both but u still have to change quiet a bit to get it to work again.
Im gonna make up a quick example of how this should be done. Give me 10 to 15 minutes and i should have an example u could look at.

 

[MasterTrainer]

Okay, going to wait for it.
Thanks.

 

[deathismyfriend]

here is a quick example just go to the mage and cast the ability. Then watch what happens.

Note: i didnt add any effects. The caster will just move next to the unit then the unit will die.

 

[MasterTrainer]

Okay I'm starting to see your point, but if I remove the loop, the caster will hit every enemy unit in range, and will only stop when there are no more enemy units in range. It's supposed to only hit units as many times as ZS_OmnislashLoop can, in this case, 8 times, means the caster will only slash 8 times, not as long as there are units in range.

EDIT: I tried it, here's the trigger:

Show

• ZS Loop
  • Events
    • Time - Every 0.03 seconds of game time
  • Conditions
  • Actions
    • For each (Integer ZS_CurrentIndex) from 1 to ZS_MaxIndex, do (Actions)
      • Loop - Actions
        • Set ZS_Counter[ZS_CurrentIndex] = (ZS_Counter[ZS_CurrentIndex] + 1)
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ZS_Counter[ZS_CurrentIndex] Equal to 30
          • Then - Actions
            • -------- [START] Circle War Stomp [START] --------
            • Set ZS_CasterLoc[ZS_CurrentIndex] = (Position of ZS_Caster[ZS_CurrentIndex])
            • For each (Integer ZS_CirclInt) from 1 to ZS_StartCircleNumber, do (Actions)
              • Loop - Actions
                • Set ZS_TempPoint[ZS_CurrentIndex] = (ZS_CasterLoc[ZS_CurrentIndex] offset by ZS_StartCircleOffset towards ((Real(ZS_CirclInt)) x (360.00 / (Real(ZS_StartCircleNumber)))) degrees)
                • Unit - Create 1 ZS_StartDummy for ZS_TempPlayer[ZS_CurrentIndex] at ZS_TempPoint[ZS_CurrentIndex] facing Default building facing degrees
                • Set ZS_Dummy[ZS_CirclInt] = (Last created unit)
                • Unit - Add a 0.30 second Generic expiration timer to ZS_Dummy[ZS_CirclInt]
            • Set ZS_TempGroup1[ZS_CurrentIndex] = (Units within 300.00 of ZS_CasterLoc[ZS_CurrentIndex] matching (((Matching unit) belongs to an enemy of ZS_TempPlayer[ZS_CurrentIndex]) Equal to True))
            • Unit Group - Pick every unit in ZS_TempGroup1[ZS_CurrentIndex] and do (Actions)
              • Loop - Actions
                • Unit - Cause ZS_Caster[ZS_CurrentIndex] to damage (Picked unit), dealing ZS_StartCircleDamage damage of attack type Chaos and damage type Divine
            • Custom script: call DestroyGroup(udg_ZS_TempGroup1[udg_ZS_CurrentIndex])
            • Custom script: call RemoveLocation(udg_ZS_TempPoint[udg_ZS_CurrentIndex])
            • -------- [END] Circle War Stomp [END] --------
            • -------- [START] Omnislash[START] --------
            • Set ZS_TempGroup1[ZS_CurrentIndex] = (Units within ZS_Omnislash_Range of ZS_CasterLoc[ZS_CurrentIndex] matching ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) is alive) Equal to True) and ((((Matching unit) belongs to an enemy of ZS_TempPlayer[ZS_CurrentIndex]) Equal t
            • Set ZS_TempGroup2[ZS_CurrentIndex] = (Random 1 units from ZS_TempGroup1[ZS_CurrentIndex])
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Number of units in ZS_TempGroup1[ZS_CurrentIndex]) Greater than 0
              • Then - Actions
                • Animation - Change ZS_Caster[ZS_CurrentIndex]'s vertex coloring to (100.00%, 100.00%, 100.00%) with 50.00% transparency
                • Animation - Change ZS_Caster[ZS_CurrentIndex]'s animation speed to 50.00% of its original speed
                • Unit Group - Pick every unit in ZS_TempGroup2[ZS_CurrentIndex] and do (Actions)
                  • Loop - Actions
                    • Set ZS_PickedUnit[ZS_CurrentIndex] = (Picked unit)
                    • Set ZS_PickedUnitLoc[ZS_CurrentIndex] = (Position of ZS_PickedUnit[ZS_CurrentIndex])
                    • Custom script: call SetUnitPositionLoc( udg_ZS_Caster[udg_ZS_CurrentIndex], udg_ZS_PickedUnitLoc[udg_ZS_CurrentIndex])
                    • Set ZS_Counter[ZS_CurrentIndex] = 0
                    • Special Effect - Create a special effect at ZS_PickedUnitLoc[ZS_CurrentIndex] using war3mapImported\blazingwind.MDX
                    • Special Effect - Destroy (Last created special effect)
                    • Custom script: call RemoveLocation( udg_ZS_PickedUnitLoc[udg_ZS_CurrentIndex])
                    • Custom script: set udg_ZS_PickedUnitLoc[udg_ZS_CurrentIndex] = null
                    • Animation - Play ZS_Caster[ZS_CurrentIndex]'s ZS_Omnislash_AttackAnim animation
                    • Unit - Cause ZS_Caster[ZS_CurrentIndex] to damage ZS_PickedUnit[ZS_CurrentIndex], dealing ZS_Omnislash_Damage damage of attack type ZS_Omnislash_AttackType and damage type ZS_Omnislash_DamageType
                    • Unit Group - Remove ZS_PickedUnit[ZS_CurrentIndex] from ZS_TempGroup2[ZS_CurrentIndex]
                    • Special Effect - Create a special effect attached to the ZS_Omnislash_AttachPoint of ZS_Caster[ZS_CurrentIndex] using ZS_Omnislash_Sfx
                    • Special Effect - Destroy (Last created special effect)
                • Custom script: call DestroyGroup( udg_ZS_TempGroup1[udg_ZS_CurrentIndex])
                • Custom script: call DestroyGroup( udg_ZS_TempGroup2[udg_ZS_CurrentIndex])
                • Animation - Change ZS_Caster[ZS_CurrentIndex]'s vertex coloring to (100.00%, 100.00%, 100.00%) with 0.00% transparency
                • Animation - Change ZS_Caster[ZS_CurrentIndex]'s animation speed to 100.00% of its original speed
                • Set ZS_Omniboolean[ZS_CurrentIndex] = True
              • Else - Actions
                • Custom script: call DestroyGroup( udg_ZS_TempGroup1[udg_ZS_CurrentIndex])
                • Custom script: call DestroyGroup( udg_ZS_TempGroup2[udg_ZS_CurrentIndex])
                • Set ZS_Omniboolean[ZS_CurrentIndex] = False
            • -------- [END] Omnislash[END] --------
            • -------- [START] Final Circle War Stomp [START] --------
            • Set ZS_CasterLoc[ZS_CurrentIndex] = (Position of ZS_Caster[ZS_CurrentIndex])
            • For each (Integer ZS_CirclInt) from 1 to ZS_FinalCircleNumber, do (Actions)
              • Loop - Actions
                • Set ZS_TempPoint[ZS_CurrentIndex] = (ZS_CasterLoc[ZS_CurrentIndex] offset by ZS_FinalCircleOffset towards ((Real(ZS_CirclInt)) x (360.00 / (Real(ZS_FinalCircleNumber)))) degrees)
                • Unit - Create 1 ZS_FinalDummy for ZS_TempPlayer[ZS_CurrentIndex] at ZS_TempPoint[ZS_CurrentIndex] facing Default building facing degrees
                • Set ZS_Dummy[ZS_CirclInt] = (Last created unit)
                • Unit - Add a 0.30 second Generic expiration timer to ZS_Dummy[ZS_CirclInt]
            • Unit Group - Pick every unit in ZS_TempGroup1[ZS_CurrentIndex] and do (Actions)
              • Loop - Actions
                • Unit - Cause ZS_Caster[ZS_CurrentIndex] to damage (Picked unit), dealing ZS_FinalCircleDamage damage of attack type Chaos and damage type Divine
            • -------- [END] Final Circle War Stomp [END] --------
            • Custom script: call DestroyGroup(udg_ZS_TempGroup1[udg_ZS_CurrentIndex])
            • Custom script: call RemoveLocation(udg_ZS_TempPoint[udg_ZS_CurrentIndex])
            • Custom script: call RemoveLocation(udg_ZS_CasterLoc[udg_ZS_CurrentIndex])
            • Custom script: set udg_ZS_TempPoint[udg_ZS_CurrentIndex] = null
            • -------- Recycling --------
            • Set ZS_Caster[ZS_CurrentIndex] = ZS_Caster[ZS_MaxIndex]
            • Set ZS_CasterLoc[ZS_CurrentIndex] = ZS_CasterLoc[ZS_MaxIndex]
            • Set ZS_Counter[ZS_CurrentIndex] = ZS_Counter[ZS_MaxIndex]
            • Set ZS_TempPlayer[ZS_CurrentIndex] = ZS_TempPlayer[ZS_MaxIndex]
            • Set ZS_Omniboolean[ZS_CurrentIndex] = ZS_Omniboolean[ZS_MaxIndex]
            • Set ZS_MaxIndex = (ZS_MaxIndex - 1)
            • Set ZS_CurrentIndex = (ZS_CurrentIndex - 1)
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • ZS_MaxIndex Equal to 0
              • Then - Actions
                • Trigger - Turn off (This trigger)
              • Else - Actions
            • -------- Instance Recycled --------
            • -------- End Loop --------
            • -------- End Cast --------
          • Else - Actions

But still there are no delays.

 

[deathismyfriend]

so u want each unit to get hit 8 times then ? 8 times in a row ? or just 8 times

 

[MasterTrainer]

No I mean 8 units are hit, anyways 8 is not constant because 8 is a configurable integer.
Let's say there are 8 units around the caster, that means 8 units are hit once.
Let's say there are only 7 units are around the caster, that means 6 units are hit once and 1 unit is hit twice.
Let's say there are only 6 units are around the caster, that means 5 units are hit once, and two units are hit thrice.

The algorithm is like that.

 

[deathismyfriend]

here ya go this will pick 8 units everytime. if there r 7 units one will get hit twice.
You will have to change the puase / unpause to a stun. so it works.
it will work now but if there is 7 units the one unit will get unpaused early.