Meat Hook System [GUI] v4.2

[Łapin Viktus]

I don't know how fix this bug, the function FilterLockedUnit is bugged ?

function FilterLockedUnit takes nothing returns boolean
return ( GetFilterUnit() == udg_MeatHLockOn[udg_MeatHRef] )
endfunction

or it's the custom script in the trigger ?

call GroupEnumUnitsInRange(udg_Temp_Targets, udg_MeatHChainX[udg_MeatHRef], udg_MeatHChainY[udg_MeatHRef], udg_MeatHAoE[udg_MeatHRef], function FilterLockedUnit)

 

[Pyrogasm]

I replied to you before at the beginning of January explaining how to fix this line. It's literally the reply in between your two posts:

It should be Filter(function FilterLockedUnit) ... in that line.

 

[JJhonJames]

There's a function that doesn't load if you import this to any other Map.

 

[Pyrogasm]

For the third time I come here to make necessary changes to this resource because it was not done properly by the author. The use of an unecapsulated function called "distance" is a massive problem for integrating this with other existing code that also try to use "distance" as a variable or function name. The other functions in the Custom Script section are also unecapsulated though their names are a bit more arcane.

Fixing this requires making the functions themselves public functions of the library I added on the previous page, which then need to have their references throughout this system updated. Here is what needs to be changed (this is GUI so I can't just put a fix in the code myself):

• Meathook Loop trigger: below the "Add / Remove chains" comment add "MeatHookUtils_" to the distance function call:
  
  • Custom script: set udg_Temp_Real = MeatHookUtils_distance(udg_MeatHCX, udg_MeatHChainX[udg_MeatHChainRef[udg_MeatHSize[udg_MeatHRef]]], udg_MeatHCY, udg_MeatHChainY[udg_MeatHChainRef[udg_MeatHSize[udg_MeatHRef]]]) - udg_MeatHOffset[udg_MeatHRef]
• MeatHook Loop trigger: below the "Search for a target to hook" heading change the line to read as follows:
  
  • Custom script: call GroupEnumUnitsInRange(udg_Temp_Targets, udg_MeatHChainX[udg_MeatHRef], udg_MeatHChainY[udg_MeatHRef], udg_MeatHAoE[udg_MeatHRef], Condition(function MeatHookUtils_FilterLockedUnit))
• IsOutsideMap seems not to be used anywhere so idk on that one.

library MeatHookUtils
public function distance takes real x1, real x2, real y1, real y2 returns real
return SquareRoot((x1 - x2) * (x1 - x2) + (y1 - y2) * (y1 - y2))
endfunction

//determine wheather a point is inside the configured map bounds
public function IsOutsideMap takes real x, real y returns boolean
return x < udg_minX or y < udg_minY or x > udg_maxX or y > udg_maxY
endfunction

//If MeatHLockOn != null and MeatHIgnore == true, this function is called to filter the locked unit
public function FilterLockedUnit takes nothing returns boolean
return ( GetFilterUnit() == udg_MeatHLockOn[udg_MeatHRef] )
endfunction
endlibrary

There are other problematic things with this resource, like hardcoded references to gg_ trigger variables. IMO this resource either needs to be re-reviewed and fully fixed or moved to Substandard.

 

[MasterWarlord]

For the third time I come here to make necessary changes to this resource because it was not done properly by the author. The use of an unecapsulated function called "distance" is a massive problem for integrating this with other existing code that also try to use "distance" as a variable or function name. The other functions in the Custom Script section are also unecapsulated though their names are a bit more arcane.

Fixing this requires making the functions themselves public functions of the library I added on the previous page, which then need to have their references throughout this system updated. Here is what needs to be changed (this is GUI so I can't just put a fix in the code myself):

• Meathook Loop trigger: below the "Add / Remove chains" comment add "MeatHookUtils_" to the distance function call:
  
  • Custom script: set udg_Temp_Real = MeatHookUtils_distance(udg_MeatHCX, udg_MeatHChainX[udg_MeatHChainRef[udg_MeatHSize[udg_MeatHRef]]], udg_MeatHCY, udg_MeatHChainY[udg_MeatHChainRef[udg_MeatHSize[udg_MeatHRef]]]) - udg_MeatHOffset[udg_MeatHRef]
• MeatHook Loop trigger: below the "Search for a target to hook" heading change the line to read as follows:
  
  • Custom script: call GroupEnumUnitsInRange(udg_Temp_Targets, udg_MeatHChainX[udg_MeatHRef], udg_MeatHChainY[udg_MeatHRef], udg_MeatHAoE[udg_MeatHRef], Condition(function MeatHookUtils_FilterLockedUnit))
• IsOutsideMap seems not to be used anywhere so idk on that one.

library MeatHookUtils
public function distance takes real x1, real x2, real y1, real y2 returns real
return SquareRoot((x1 - x2) * (x1 - x2) + (y1 - y2) * (y1 - y2))
endfunction

//determine wheather a point is inside the configured map bounds
public function IsOutsideMap takes real x, real y returns boolean
return x < udg_minX or y < udg_minY or x > udg_maxX or y > udg_maxY
endfunction

//If MeatHLockOn != null and MeatHIgnore == true, this function is called to filter the locked unit
public function FilterLockedUnit takes nothing returns boolean
return ( GetFilterUnit() == udg_MeatHLockOn[udg_MeatHRef] )
endfunction
endlibrary

There are other problematic things with this resource, like hardcoded references to gg_ trigger variables. IMO this resource either needs to be re-reviewed and fully fixed or moved to Substandard.

You changed the system to vJass. The original trigger is directly made as not vJass. As a non vJass user it took me far too long to see why it was still not working with your fixes.

For anyone else coming in to this thread, here is a fixed version that is still just ordinary GUI and JASS, and does not use the public or library functions.