Maelstrom v3

[Moderator]

18:35, 16th Jul 2012
Magtheridon96: Approved.

But you forgot to delete this line (Custom script: call RemoveLocation(udg_M_PickedVLoc))
inside the if statement of the loop because it is not needed.

 

[Mr_Bean]

I think the descriptions are a bit too ... yellow ... for me. Perhaps make the font normal size and colour after the heading.

Looks like a nice spell though!

 

[KnnO]

Review

First, please use smaller font, and it doesn't need to be all yellow.
Also add hidden BBCodes to your description better than a huge table.

______________________________________________________________

	<Maelstrom Loop> trigger Should be initialy off, enabled due to <Maelstrom Cast> trigger firing, and disabled there too
	For more efficiency: Change some actions ... (See Suggestions)

[TD] [TD]

Trigger	Position	Action
<Maelstrom Cast> trigger	Line 7	Set M_TornadoLoc = (Position of M_Tornado) -------- Change ^ this action to v this action -------- Set M_TornadoLoc = M_TargetLoc

 

[Mr_Bean]

First, please use smaller font, and it doesn't need to be all yellow.

That's like exactly what I said...

 

[KhaosMachine]

That's like exactly what I said...

Hidden

 

[Almia]

the line are just the same,i didnt get what are you saying about it mr KnnO

 

[KnnO]

Pfft sorry, My bad, edited it
(I didn't notice that sorry)

 

[Mr. Reez]

REALLY APPRECIATED!! Thank you
I'm trying it right now

Seriously though credits can only be given you!

 

[Almia]

Pfft sorry, My bad, edited it
(I didn't notice that sorry)

oh now understand,hmmmm maybe ill just remove the tornadoloc then ill replace it with targetloc

 

[CoLd Bon3]

LOL! Radamantus copied his logo idea from KhaosMachine :O even the font is the same... #off-topic

The spell is good, i like it. I am lazy to look at the code, but the overall look is good! Perhaps the tornado should make random moves or something at the cost of reduced AoE.. i don't know, i just suggest.

 

[Almia]

LOL! Radamantus copied his logo idea from KhaosMachine :O even the font is the same... #off-topic

The spell is good, i like it. I am lazy to look at the code, but the overall look is good! Perhaps the tornado should make random moves or something at the cost of reduced AoE.. i don't know, i just suggest.

ahahahah,KhaosMachine made it for me!!!(i requested it!)
About the random move,maybe ill put that cause ive been thinking that every day(putting it or not,putting it or not,etc)DILEMMA

 

[Tank-Commander]

You need to use co-ordinates for this, considering that you can suck an infinite number of enemy units at a time, you could easily cause a player to have to alt+F4 there way out of a game because it was sucking too many units. Also: this goes for a lot of your spells:

When you pick units and have a large amount of conditions it's better to pick all nearby units first, set a variable to them, then run the variable through conditions, this way it makes it much easier to read and configure for other people - especially moderators, since they can't see the whole line in the format which you're using.

As a side note, incase you do not know what the co-ordinate functions are they are:

SetUnitX(Unit, Where)
SetUnitY(Unit, Where)

Example:

Set udg_Angle = udg_DesiredAngle * bj_DEGTORAD
SetUnitX(udg_Unit, GetUnitX(udg_Unit) + udg_Speed * Cos(udg_Angle))
SetUnitT(udg_Unit, GetUnitY(udg_Unit) + udg_Speed * Sin(udg_Angle))

 

[Almia]

Sorry about those examples,cause i dont understand sin cos and tan (15 yrs old)

 

[Tank-Commander]

Sorry about those examples,cause i dont understand sin cos and tan (15 yrs old)

I'm 16 now and was 14 when I started using them. You don't need to know the ins and out of Sin and Cos, just what the custom script looks like to use them correctly.

 

[Almia]

In Philippines no,i think its from trigonometry right?
ok il try it

 

[maddeem]

In Philippines no,i think its from trigonometry right?
ok il try it

Geometry. Really simple stuff actually

 

[defskull]

Sorry about those examples,cause i dont understand sin cos and tan (15 yrs old)

Compare Magtheridon96's age, you'll be amazed (he's 16, 1 year older than you) and he understand most of the scripts/calculations/etc.
Age is never the excuse.

Also, you don't need to know what are those Cos and Sin function, just follow the script and you're done.

SetUnitX(udg_YourUnit, GetUnitX(udg_YourUnit) + udg_SpeedPerInterval * Cos(udg_MovingAngle * bj_DEGTORAD))
SetUnitY(udg_YourUnit, GetUnitY(udg_YourUnit) + udg_SpeedPerInterval * Sin(udg_MovingAngle * bj_DEGTORAD))

The thing you need to manipulate are;
udg_YourUnit (moving unit)
udg_SpeedPerInterval (this is the distance moved per X interval - depends on your Event)
udg_MovingAngle (this is the angle in which you want the unit to move to)

That's all.

 

[Mr_Bean]

Compare Magtheridon96's age, you'll be amazed (he's 16, 1 year older than you) and he understand most of the scripts/calculations/etc.
Age is never the excuse.

I must disagree with this. Depending on your age you may not have learnt trigonometry yet. It can be quite confusing at first and you could confuse yourself if you try learning it by yourself.

If you aren't doing trig yet you just need to understand the basics; such as cos is used to get the x-component of angles and sin for the y-component.

 

[defskull]

I must disagree with this. Depending on your age you may not have learnt trigonometry yet. It can be quite confusing at first and you could confuse yourself if you try learning it by yourself.

If you aren't doing trig yet you just need to understand the basics; such as cos is used to get the x-component of angles and sin for the y-component.

Please don't take the word "Age is never the excuse" LITERALLY.
You can't even turn on PC if you're 6 months old.

Be logic.

Also, as I said, (in this case), just follow the script, you don't have to think about "what is cos ? is it cost of a candy ? and what is sin ? I do not make any sins ".
All you have to do is follow (with some value manipulations of course).

 

[Mr_Bean]

Please don't take the word "Age is never the excuse" LITERALLY.

Hmmm, which other way is there to take that phrase?

Also, as I said, (in this case), just follow the script, you don't have to think about "what is cos ? is it cost of a candy ? and what is sin ? I do not make any sins ".
All you have to do is follow (with some value manipulations of course).

I don't know about him, but I like to understand what the code is doing. Perhaps he will be happy with just using the script and not knowing what it does...

 

[Oljin]

nice spell! works fine - I use it as an ulti (for Lady Vashji) but I haven't found yet the right balancing for this spell.
the drag into the maelstrom is extremely strong, because if the damage is high enough this is kind of a one-shot killer.

i try to reduce the drag speed and how often one gets dragged, in order to allow players to have a possibility to leave the maelstrom.