[Trigger] made eclipse (luna's ult from dota) but doesnt work

[pbnjamma]

hey im trying to make eclipse, which is a slam spell which then calls down a lucent beem (basicaly dmg and a .1 second stun) to a random nearby enemy unit. It calls down 8 beams with about .5 seconds between each beam. the caster can run around for a few seconds and the beams will only be called down to hit the units it is by, ie the beams do not just hit random units at the location of casting. so here is my trigger (trying to stay in GUI). it doesnt seem to be multi-insticable and it doesnt always seem to hit 8 times.

• eclipse
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to eclipse (Neutral Hostile 1)
  • Actions
    • Custom script: local unit udg_unit
    • Set unit = (Triggering unit)
    • For each (Integer A) from 1 to 8, do (Actions)
      • Loop - Actions
        • Wait 0.50 seconds
        • Set point = (Position of unit)
        • Set group = (Units within 400.00 of point)
        • Unit Group - Pick every unit in group and do (Actions)
          • Loop - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • ((Picked unit) belongs to an enemy of (Owner of (Triggering unit))) Equal to True
                • (Unit-type of (Picked unit)) Not equal to dummy
                • (Unit-type of (Picked unit)) Not equal to scatter shot dum
                • (Unit-type of (Picked unit)) Not equal to chilling armor dum
                • (Unit-type of (Picked unit)) Not equal to tinker bomb dum
                • (Unit-type of (Picked unit)) Not equal to web
                • (Unit-type of (Picked unit)) Not equal to web dum
                • (Unit-type of (Picked unit)) Not equal to march of the machines dum
                • (Unit-type of (Picked unit)) Not equal to machine def lvl 1 dum
              • Then - Actions
                • Unit Group - Add (Picked unit) to group2
              • Else - Actions
        • Unit - Create 1 dummy for (Owner of (Triggering unit)) at point facing Default building facing degrees
        • Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
        • Unit - Add eclipse dum to (Last created unit)
        • Unit - Order (Last created unit) to Human Mountain King - Storm Bolt (Random unit from group2)
    • Custom script: call RemoveLocation(udg_point)
    • Custom script: call DestroyGroup(udg_group2)
    • Custom script: call DestroyGroup(udg_group)

 

[Yngwie]

Maybe I'm missing somthing but all I see is you pick alot of units and then storm bolt one random unit in group2. Did you leave stuff out?

 

[donut3.5]

Waits don't work well in Loops.
--donut3.5--

 

[PurplePoot]

Waits don't work well in Loops.

Lies.

Anyhow, erm, are you sure you created group2?

 

[donut3.5]

They don't work well for me... although I guess that's only under 0.50 seconds..
Isn't there like, a limit to how small a wait is?
--donut3.5--

 

[PurplePoot]

0 is ~.1s, .01 is ~.27s (then delay, which can add tons)

And if they don't work for you, you're doing something really really really really really really (really) weird.

 

[pbnjamma]

waht it does is creates a group consistiing of units around the caster, then checks if the units in group are enemies, non dummies etc, then picks one at random for a dummy to cast storm bolt (lucent beam ) on then waits .5 secs, then does it again , supposedly, 8 times. does anyone see why it wont work

 

[PurplePoot]

Why don't you just use Random Unit from group and skip group2 altogether? (with all those fancy conditions, ofc)

 

[Yngwie]

How do you know it will do it 8 times? It looks like it will just do it once then it stops by the trigger.

 

[Razorbrain]

enhancing GUI triggers with locals has never worked for me, becouse my triggers seem to get cut in half whenever i use them

however, i might do have a solusion for you. Instead of having a Loop, why dont you try and create a Dummy, and make the Loop Actions when the Dummy unit dies?

this way, it can be MUI as well

 

[PurplePoot]

locals don't exist in Unit Group blocks (you have to recreate them), but that doesn't look like it would matter here.

 

[FamousPker49]

i have never been able to get a wait to work in a loop first off, what does it actually do, cus if we dont know the exact way the trigger is functioning, we can only make stupid guesses at what is wrong, you should say exactly how many times it actually lucent beams, and other information that could be useful

 

[Turtles]

I may be wrong, but I think that when you destroy a group using "Custom script: call DestroyGroup(udg_group)" that it literally destroys it, and it cant be referenced again. i might be thinking of something else.


Ohh, "integer A" does not run the functions eight times. right now your integer A function isn't doing anything. I would repeat the trigger, then have an execution count function stop it when it reaches 8. also, you could use 8 different triggers that run the next one after each one.

 

[FamousPker49]

the integer a should be running eight times, because that is how you repeat something an X amount of times is with integer a or b, but i do think that destroying the group does permanently get rid of it, because i have had the same problem with it

 

[Turtles]

integer A is an all-purpose variable... it doesn't run the actions eight times.

 

[FamousPker49]

yes it will, i have used in numerous times, it allows you to run multiple functions in a loop, and set different things to the number of times it has run by referencing "Integer A" like you could set an Integer Variable[Index] to display Integer Variable[Integer A] and it will give you which loop it is on like for example Integer Variable [4]

 

[Razorbrain]

i say

Dummy Unit Die Loops FTW

 

[Turtles]

I know. using For each Integer A from 1-10, for instance, in "Player - Give player [Integer A] 100 gold" would give player 1-10 100 gold each. it does not run the function 10 times, it just replaces [Integer A] with 1-10.

If by a chance i'm wrong, then i still go by my other statement. have you tried not clearing the variables?

 

[Xelephant]

Use the

• Custom script: set bj_wantDestroyGroup = true

instead of the manual destory stuff. Place it in front of your Groups. Or if those Groups are used in more than one Trigger don't destroy it, set it to null. (set udg_group = null)

@Turtels on the loop Topic
I think it repeats the Action 8 Times, add a Game Message in a Loop and it will show up 8 times, so it repeats it [Interger A] is the Index of the Loop which will increase or decrease (only Jass) so you can refer with help of this to different Player/Array-Index Numbers.

 

[FamousPker49]

Thank you godless, that is what i was going to say, actually everything you posted is what i was going to put

 

[Turtles]

Thank you for correcting me.. I wasnt sure, so i figured it was worth a try.