1. Updated Resource Submission Rules: All model & skin resource submissions must now include an in-game screenshot. This is to help speed up the moderation process and to show how the model and/or texture looks like from the in-game camera.
    Dismiss Notice
  2. DID YOU KNOW - That you can unlock new rank icons by posting on the forums or winning contests? Click here to customize your rank or read our User Rank Policy to see a list of ranks that you can unlock. Have you won a contest and still havn't received your rank award? Then please contact the administration.
    Dismiss Notice
  3. We have recently started the 16th edition of the Mini Mapping Contest. The theme is mini RPG. Do check it out and have fun.
    Dismiss Notice
  4. Dismiss Notice
  5. The Highway to Hell has been laid open. Come along and participate in the 5th Special Effect Contest.
    Dismiss Notice
  6. Check out the Staff job openings thread.
    Dismiss Notice
Dismiss Notice
60,000 passwords have been reset on July 8, 2019. If you cannot login, read this.

[Lua]Obliterate all GUI leaks with 1 trigger!

Discussion in 'The Lab' started by Dr Super Good, Jun 5, 2019.

  1. JC Helas

    JC Helas

    Joined:
    Oct 19, 2014
    Messages:
    127
    Resources:
    3
    Maps:
    1
    Spells:
    2
    Resources:
    3
    Edit:
    you create too much locations,groups.one mistake like you forgot to import this system,, totally dead XD
     
  2. Dr Super Good

    Dr Super Good

    Spell Reviewer

    Joined:
    Jan 18, 2005
    Messages:
    25,804
    Resources:
    3
    Maps:
    1
    Spells:
    2
    Resources:
    3
    This will only fix leaks. It cannot fix if one keeps references to the objects.
     
  3. George Stinz

    George Stinz

    Joined:
    Jan 12, 2020
    Messages:
    5
    Resources:
    0
    Resources:
    0
    Hello and thanks for writing this. I am unable to test your map (or mine with your triggers). The game just sits there forever on the door knocker screen (with a small blue square on the bottom left).

    Can you confirm this still works with current patch?
     
  4. Dr Super Good

    Dr Super Good

    Spell Reviewer

    Joined:
    Jan 18, 2005
    Messages:
    25,804
    Resources:
    3
    Maps:
    1
    Spells:
    2
    Resources:
    3
    Yes it works with 1.31.

    It may not work with 1.32 which is currently in beta. Blizzard may have implemented something similar natively so it is no longer required. I cannot test 1.32 beta (do not have Reforged) but the synchronized garbage collector certainly does not work from what other people have said.
     
  5. George Stinz

    George Stinz

    Joined:
    Jan 12, 2020
    Messages:
    5
    Resources:
    0
    Resources:
    0
    I am in fact using 1.32. I don't see anything in the patch notes. However, I did find a few people complaining about lua in recent patch notes feedback.
    Anyway, it sounded so lovely to me. Maybe closer to release, it will work again. Thanks.
     
  6. Anachron

    Anachron

    Joined:
    Sep 9, 2007
    Messages:
    6,221
    Resources:
    66
    Icons:
    49
    Packs:
    2
    Tools:
    1
    Maps:
    3
    Spells:
    9
    Tutorials:
    1
    JASS:
    1
    Resources:
    66
    Sorry to say this but for me this is a nice gimmick, nothing more.

    Yes it works, yes it helps but in my opinion this should never replace correct cleanup handling. This will cause additional stress on the game which can be prevented by doing cleanups correctly in the first place.

    I like the idea/concept, but I fear this will lead to even worse coding in maps.
     
  7. Dr Super Good

    Dr Super Good

    Spell Reviewer

    Joined:
    Jan 18, 2005
    Messages:
    25,804
    Resources:
    3
    Maps:
    1
    Spells:
    2
    Resources:
    3
    Additional stress?
    Locations, groups and forces should never have leaked to begin with. In StarCraft II there are no such problems.
     
  8. verstefyren

    verstefyren

    Joined:
    Jun 6, 2015
    Messages:
    37
    Resources:
    0
    Resources:
    0
    This is so nice for lazyasses like myself. I hope this will work on reforged in the future.
     
  9. Dr Super Good

    Dr Super Good

    Spell Reviewer

    Joined:
    Jan 18, 2005
    Messages:
    25,804
    Resources:
    3
    Maps:
    1
    Spells:
    2
    Resources:
    3
    The underlying concept should at least still work. But the garbage collector synchronization does not. Hopefully Blizzard is synchronizing it so the system does work, otherwise it will cause OoS in multiplayer.
     
  10. Kyrbi0

    Kyrbi0

    Joined:
    Jul 29, 2008
    Messages:
    7,942
    Resources:
    1
    Models:
    1
    Resources:
    1
    Is... Is it.. True?

    Has the Blessed Day thusly come upon us?