Lot of simple triggers or one complicated?

[Frosty5]

Well this is the question. Is is better to have triggers sepperate into simple ones like this example:

• Trigger 1
  • Events
    • Unit - A unit owned by Player 1 (Red) Gains a level
  • Conditions
    • (Hero level of (Leveling Hero)) Equal to 5
  • Actions
    • Unit - Remove Heal (stage 1) from Storage Area 0000 <gen>
    • Unit - Add Heal (stage 2) to Storage Area 0000 <gen>
    • Trigger - Turn off (This trigger)

• Trigger 2
  • Events
    • Unit - A unit owned by Player 1 (Red) Gains a level
  • Conditions
    • (Hero level of (Leveling Hero)) Equal to 10
  • Actions
    • Unit - Remove Heal (stage 2) from Storage Area 0000 <gen>
    • Unit - Add Heal (stage 3) to Storage Area 0000 <gen>
    • Trigger - Turn off (This trigger)

Or to have both triggers in one like this:

• Only Trigger
  • Events
    • Unit - A unit owned by Player 1 (Red) Gains a level
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Hero level of (Leveling Hero)) Equal to 5
      • Then - Actions
        • Unit - Remove Heal (stage 1) from Storage Area 0000 <gen>
        • Unit - Add Heal (stage 2) to Storage Area 0000 <gen>
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Hero level of (Leveling Hero)) Equal to 10
          • Then - Actions
            • Unit - Remove Heal (stage 2) from Storage Area 0000 <gen>
            • Unit - Add Heal (stage 3) to Storage Area 0000 <gen>
          • Else - Actions

Does that make any difference?

 

[PlasmaSnake]

I personally like it in one trigger, it gets confusing when you have a bunch of triggers doing practically the same thing, but for a different person, unit, etc..

 

[SanKakU]

i say cram the triggers together as much as possible. but then, i use jass which is a lot more fun.

 

[defskull]

A single trigger does more performance as it fires 1 part of trigger, rather than 2
Performing CHECKS (1 single trigger) will perform better than firing TRIGGER (2 separate trigger that can be related to one another)

 

[mckill2009]

trigger 2 is faster in my opinion...

 

[defskull]

trigger 2 is faster in my opinion...

There are 3 triggers in post 1
Trigger 1 and Trigger 2 does not combine
Method 2 is combined
So, are you saying Trigger 2 works faster or METHOD 2 works faster? =p

 

[mckill2009]

method 2

 

[Dr. Boom]

Moin moin =)

I know only, that the map has a bigger size when you do every time a single trigger instead of combine them. I made a test map with 10 single triggers (event, condition, action) [16,9 kb] and a test map with one trigger and 10 if - then - else [15,9 kb].

Also I think it's faster if you have 2 trigger in 1 instead of having 2 different triggers, because the if you do an action in game, the game checks if one of the trigger match the current action and this would be faster if only one trigger is executed instead of two and more.

The only thing I can say for sure is that it's better to have one initialization trigger instead of more triggers with the map initialization event!

Greetings and Peace
Dr. Boom

 

[defskull]

Plus, creating 2 things inside 1 trigger makes it easier to manage, rather than 2 activities going on, it's hard to keep track and manage it