Limited unit attack angle

[Fingolfin]

I'm trying to make a system that forbids units to attack enemies that are not standing within 150 degrees infront of it.

For this i am using Vexorians "GetAngleDifference" system:

Code

function GetAngleDifference takes unit u1, unit u2 returns real
     local location l1 = GetUnitLoc(u1)
     local location l2 = GetUnitLoc(u2)
     local real a1 = AngleBetweenPoints(l1, l2)
     local real a2 = GetUnitFacing(u1)
     local real x
     call RemoveLocation(l1)
     call RemoveLocation(l2)
     set l1 = null
     set l2 = null
        // The Modulo will get the co-terminal angle if the angle is less than -360 or greater than 360.
        set a1=ModuloReal(a1,360)
        set a2=ModuloReal(a2,360)
        // makes sure angle 1 is the smaller angle.  If it isn't it switches them.
        if a1>a2 then
            set x=a1
            set a1=a2
            set a2=x
        endif
        // Subtracts 360, to get the first negative co-terminal angle, this is then used in a comparison to check if the angle is greater than 180
        set x=a2-360
        if a2-a1 > a1-x then
            //  If it is, use the negative angle instead
            set a2=x
        endif
        //  Now, get the difference between the 2 angles.
        set x=a1-a2
        //  If the difference is negative, make it positive and return it.  If its positive, return it.
        if (x<0) then
            return -x
        endif
     return x
    endfunction

Combined with this trigger:

• Attack Angles
  • Events
    • Unit - A unit Is issued an order targeting an object
  • Conditions
    • (Issued order) Equal to (==) (Order(attack))
  • Actions
    • Custom script: local Parent P = Parents[GetUnitUserData(GetTriggerUnit())]
    • Custom script: if not(GetAngleDifference(P.controller, GetOrderTargetUnit()) >150.) then
    • Unit - Order (Triggering unit) to Stop
    • Custom script: endif

(I replaced the struct/array names to "parent" since that's basically what you need to know - it retrieves a "parent unit", which is what we get the facing angle from. Otherwise, the unit would procedurally spin around since he changes facing everytime he attacks a units within the allowed field thus changing the field itself.)

I was told by a friend that the "unit is issued an order" event also detects auto-attacks caused by aquisition range.
The problem is, obviously, that it doesn't work. I would be very thankful if someone helped me out on this.

EDIT: +2 rep to whoever solves this for me. :O

 

[PB_L]

Mby if you use attack event. Unit is issued an order will only work if player gives order, but if enemy comes in range of unit and unit auto attack him it will not work.

 

[Fingolfin]

But doesn't the attack event fire when the unit has already attacked? (or at least commenced it's attack animation?).

 

[PurgeandFire]

• Attack Angles
  • Events
    • Unit - A unit Is issued an order targeting an object
  • Conditions
    • (Issued order) Equal to (==) (Order(attack))
  • Actions
    • Custom script: local Parent P = Parents[GetUnitUserData(GetTriggerUnit())]
    • Custom script: if not(GetAngleDifference(P.controller, GetOrderTargetUnit()) >150.) then
    • Unit - Order (Triggering unit) to Stop
    • Custom script: endif

(I replaced the struct/array names to "parent" since that's basically what you need to know - it retrieves a "parent unit", which is what we get the facing angle from. Otherwise, the unit would procedurally spin around since he changes facing everytime he attacks a units within the allowed field thus changing the field itself.)

I was told by a friend that the "unit is issued an order" event also detects auto-attacks caused by aquisition range.
The problem is, obviously, that it doesn't work. I would be very thankful if someone helped me out on this.

EDIT: +2 rep to whoever solves this for me. :O

You should add these debug messages and test it to see exactly what the problem is:

• Attack Angles
  • Events
    • Unit - A unit Is issued an order targeting an object
  • Conditions
    • (Issued order) Equal to (==) (Order(attack))
  • Actions
    • Custom script: local Parent P = Parents[GetUnitUserData(GetTriggerUnit())]
    • Custom script: call BJDebugMsg("Struct: "+I2S(P))
    • Custom script: call BJDebugMsg("AngleDiff: "+R2S(GetAngleDifference(P.controller,GetOrderTargetUnit())))
    • Custom script: if not(GetAngleDifference(P.controller, GetOrderTargetUnit()) >150.) then
    • Unit - Order (Triggering unit) to Stop
    • Custom script: endif

If the messages are shown, that means the event is being registered. Otherwise, the trigger is not being fired.

If the "Struct: #" shows a number greater than 0, then the struct instance is fine. If it is 0, then it isn't retrieving the proper instance for some reason.

If the "AngleDiff: #" shows properly and doesn't return 0, then it should work fine. Else, it might be not functioning or one of the input values are null.

Runs those tests and that will help us figure out what is wrong.

 

[Fingolfin]

Thank you, i will tomorrow. Smart call there.

 

[Fingolfin]

LOL!!

I tried using "a unit is attacked" instead, and it worked much better.
However, the trigger was fired like.. every second for each some 100 units fighting, since the aquisition range will cause untis to be given attack orders constantly as long as there is a unit within range. It caused massive lag and i was forced to shut the game down.

Is there any way to trigger the aquisition range instead? I mean, if you set it to 0. and have a trigger that register units coming within range of another, and then order the unit to attack it? Or will that also cause lag?
It would be good if it did, since i could integrate it with many other systems in the map.

 

[Bribe]

Rather than a stop order, have the unit issue a move-order to the target instead.

 

[Fingolfin]

To the target he's firing at? :S
Or the coordinates he's standing on?
I don't understand how it solves the problem.

 

[PB_L]

I have done some test, and unit will attack even if you set aquisition range to 0. You can create loop trigger that will check if there are units in front of your unit. If there are nor units then make unit unable to attack (I think if you add ability from Orc Burrow they will not be able to attack). If there are units then make your unit able to attack ( just remove ability) and order him to attack unit. Also add 2 more triggers :
1. When your unit attack check if unit is in front of unit (because when it's able to attack mby it will attack enemy that is not in range.
2. Use if unit is in order, and in loop check if ordered unit is in front of your unit and then order your unit to attack ordered unit (because if player ordered to attack some unit)

I hope you have understand this, if you need i will make triggers for you

 

[Bribe]

Instead of:

Unit - Order (Attacking unit) to Stop

Use:

call IssuePointOrder(GetAttacker(), "move", GetUnitX(GetTriggerUnit()), GetUnitY(GetTriggerUnit()))

In Custom script tag.

 

[Fingolfin]

Sounds good, but adding "battle stations" (assuming that's teh ability you meant) to a unit caused the game to crash for me. Perhaps it is because it requires a cargo hold. Let me know if you were refering to some other ability (would love to know an ability that disarms a unit without having to be cast).

EDIT: @Bribe: why would i want the attacker to move to the target? I just want it to be unable to attack it.

 

[Bribe]

It would prevent the lag you're experiencing with units constantly re-acquiring the target unit and ordering the unit to move, disabling the infinite loop.

 

[Fingolfin]

But it would also have the side effects of having my units move towards the enemy... :O

 

[PB_L]

I have done triggers. Unit will only attack if enemy is in front of unit (angle is 40).
I did not fine any bug, if you find plz inform me so i can fix them.
View attachment LimitedAttack.w3x

 

[Fingolfin]

i tried the map and it seems to work properly. I liked the idea of having disabled spellbooks with the orc burrow abilities in though, that helped me a lot on another issue i had.

I will inspect it closer later when i have time, but +rep and thank you very much for now.