Lightfall v0.03

[Moderator]

Bribe:

You use a lot of arrays which impair readability and in-game performance. More specific names would be beneficial here, to make it easier to follow what's happening with the code.

Set Real[1], for example, could be "FlyingHeight"

Same with Integer[1] = 10, could be "FX_Count"

While arrays may remove bloat from the variable editor, they add bloat to everything else.

I also recommend hashing function call results before repeat-referencing them. For example, using integer variable loops instead of integer A loops, and you use (Key (Picked unit)) a lot which could instead be set to a variable. Variables execute much faster in-game than function calls.

Overall could use some under-the-hood work, but the result is nice.

Maker, v0.01, 14.07.2011
Approved. But you should do as Bribe said to improve performance a bit. The spell is also a bit heavy with effects, but they look good.
GetForLoopIndexA() -> bj_forLoopAIndex
Do the Ray is empty check only after you remove a unit from the group.

 

[G00dG4m3]

Suggestions, flaming and alike are all waited here.
Enjoy

 

[Magtheridon96]

When i saw this spell in the Queque, i thought it was just another one of those noob spells that use waits.

Anyways, you shouldn't use Integer A loops cuz they can cause some really wierd bugs.
Try using integer variable loops.

I forgot to mention this:

Good job!
5/5

 

[G00dG4m3]

Well, I guess I could change those A Loops, but got no warcraft III installed here
Oh, and should I use another number of Integer[x]?

 

[Magtheridon96]

no actually you dont have to array the integer variable integer. Just create a variable like "Light_Fall_int"

One more thing i just realized: It would be much better if you give better names for your variables cuz they have really common names and might overwrite other variables. You should give them names like LF_Points, LF_Caster,.... To be on the safe side, give them names like Light_Fall_Points, Light_Fall_Caster....

Other than that, this spell is great

EDIT:
I felt i was a bit unclear. You should use Integer "variable", then every place that you used (integer A) in should be replaced with that variable you used in the integer "variable".

 

[G00dG4m3]

Like I said in my Spellpack, it can look that imma insolent or ignorant, but I think that users should rename variables whatever they like before copy->Pasting the spell.

Just my 2 cents

Oh, and thank you. I thought over and over again how to make this spell really cool. I like when the falling speed is like 50/loop and there is no AoE marking part in cast trigger. It just looks nice, modeled starfall star

 

[Magtheridon96]

*waiting for someone else to reply to break awkward silence*


EDIT:
4 hours later... Still waiting

 

[88WaRCraFT3]

I'll break it ... XD
5/5 NO MORE TO SAY, MAN I LOVE YOUR SPELLS, AND IDK WHY YOU HAVE SO LITTLE +REPS... so take 1 mine

 

[Weep]

The spell's basic operation is a simple delayed AOE, similar to the default spell Inferno and not especially unique, to be brutally honest.

Mostly, it's a bunch of custom visuals to go along with it. That said, it is quite pretty, and easy to reconfigure for inexperienced mappers.

 

[Maker]

I saw no leaks, it is MUI, the tooltip is ok and so are things object editor. Good job there.

The effects look good, but are a bit over the top. And like Weep said it is not very original.

Trigger-wise, you could add an initialization trigger where you set the constants and init hashtable.

You could store the Key(Picked unit) into a variable and use the variable.

GetForLoopIndexA() -> bj_forLoopAIndex

This

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (Rays is empty) Equal to True
  • Then - Actions
    • Trigger - Turn off (This trigger)
  • Else - Actions

should be after this

• Unit Group - Remove (Picked unit) from Rays

And remember to put two units in ability maps so one can test whether the ability is MUI or not

 

[G00dG4m3]

The spell's basic operation is a simple delayed AOE, similar to the default spell Inferno and not especially unique, to be brutally honest.

Mostly, it's a bunch of custom visuals to go along with it. That said, it is quite pretty, and easy to reconfigure for inexperienced mappers.

Exactly, I hadn't idea to make smt very hugely unique, just wanted to make my own model w/e moddeling

EDIT:

I saw no leaks, it is MUI, the tooltip is ok and so are things object editor. Good job there.

Ty

The effects look good, but are a bit over the top. And like Weep said it is not very original.

As I said, I didn't intend doing smt very original

You could store the Key(Picked unit) into a variable and use the variable.

Dunno, for me I already am used to pressing several 'hotkeys' for Key(Picked Unit)

This

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (Rays is empty) Equal to True
  • Then - Actions
    • Trigger - Turn off (This trigger)
  • Else - Actions

should be after this

• Unit Group - Remove (Picked unit) from Rays

Should I check it once or 20 times per 0.03 seconds? I don't know, I put it there, every1 says put it at loop and, put it at the end of loop, and you say put it after removing the unit from group -_-. I'll stick to checking once.

And remember to put two units in ability maps so one can test whether the ability is MUI or not

OOORr. you could simply cast it several times quickly, there is no CD/Mana cost in test map


_____________________________________________________________________________

Off Topic: Who is Spell Section Moderator? I'd like to have a pair of words w/ him

 

[Magtheridon96]

When i saw this spell in the Queque, i thought it was just another one of those noob spells that use waits.

Anyways, you shouldn't use Integer A loops cuz they can cause some really wierd bugs.
Try using integer variable loops.

I forgot to mention this:

Good job!
5/5

Did I actually sound like that?
WOW I was nooby xD

-----------
New comments:

Looks pretty good.
You could get rid of those arrays though.
Arrays are much slower than normal variables

 

[x3GlikE]

Looks very cool with the effects. 0.0

 

[Rogue_11]

nice... everyone won't leave this one for their map. good job 5/5