Approved
Moderator
M
Moderator
12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.
16:20, 17th Jul 2012
Magtheridon96:
There's a lot of room for improvement here :/
IcemanBo: Too long as NeedsFix. Rejected.
16:20, 17th Jul 2012
Magtheridon96:
- You shouldn't use Custom value. Custom value is reserved for unit indexers. Like Maker said, imagine if all spells and systems used custom values. None of them would work.
- Try as much as you can to reduce the number of function calls you have and use variables wherever possible. For example:
-
Set GushTarget = (Target unit of ability being cast)
-
Set GushPoint = (Position of (Target unit of ability being cast))
-
Set GushTarget = (Target unit of ability being cast)
-
Set GushPoint = (Position of GushTarget)
-
- Learning hero -> Triggering unit
- Use Bribe's Damage Engine to detect damage because it's not good to have your own mini-damage detection inside one spell rather than having one system that will do everything for all spells and systems.
- Use Bribe's Unit Indexer instead of setting the custom values. Bribe's unit indexer will set custom values for you, so each unit will have a unique index. This way, you could attach data to a unit by creating an array and using the custom value of that unit as an array index.
- NEVER use (Integer A). Use your own integer. (Integer A) will most certainly bug everything in your map if you don't use it right.
There's a lot of room for improvement here :/
