Leaks-custom script syntax

[AGNO12]

Hey,

Sorry for such a basic question, but does the syntax for custom scripts to remove groups and points matter? For instance, I have seen:

Custom script: call RemoveLocation(udg_Point)
Custom script: call RemoveLocation( udg_Point )
Custom script: call RemoveLocation (udg_Point)


I currently have perhaps 15 triggers that use the last syntax for a unit spawn trigger every 65 secs. I am experiencing alot of lag, and am wondering if it is because I am not properly removing leaks or if my old machine just cant handle that many units (which to be honest really isnt that much, using melee food cap, about 400 worth of units at any given time).

Any help would be great, thanks.

An example of my unit spawn trigger:

• Ancient Spawn lvl1
  • Events
    • Time - Every 65.00 seconds of game time
  • Conditions
    • (Player 5 (Yellow) Food used) Less than or equal to 300
  • Actions
    • Set Point2 = (Center of Ancient Spawn Zone <gen>)
    • If ((Ancient of Wind 0064 <gen> is alive) Equal to True) then do (Unit - Create 1 Druid of the Talon (Night Elf Form) for Player 5 (Yellow) at Point2 facing 90.00 degrees) else do (Do nothing)
    • If ((Ancient of Lore 0063 <gen> is alive) Equal to True) then do (Unit - Create 3 Dryad for Player 5 (Yellow) at Point2 facing 90.00 degrees) else do (Do nothing)
    • Custom script: call RemoveLocation (udg_Point2)

 

[Almia]

the spaces between parentheses doesn't matter.
Example : call RemoveLocation( udg_Point )
But these:

call RemoveLocation (udg_Point)
call RemoveLocation(udg_ Point)

causes syntax error,because functions are case-sensitive

 

[AGNO12]

Thanks. I had another question: Why does this trigger only add gold once?

• gold
  • Events
    • Time - Every 4.00 seconds of game time
  • Conditions
  • Actions
    • Set PlayerGroup = (All players)
    • Player Group - Pick every player in PlayerGroup and do (Actions)
      • Loop - Actions
        • Player - Add 1000 to (Picked player) Current gold
    • Custom script: call DestroyForce (udg_PlayerGroup)

This trigger works, but i believe it leaks:

• gold2
  • Events
    • Time - Every 4.00 seconds of game time
  • Conditions
  • Actions
    • Player Group - Pick every player in (All players) and do (Actions)
      • Loop - Actions
        • Player - Add 1000 to (Picked player) Current gold

 

[EmoBrother]

Because it has been destroyed ?? I don't know about Jass and vJass :b
Replace the last custom script with

• Player Group - Remove all players from PlayerGroup

 

[AGNO12]

Will that leak? Most of the tutorials say to use Custom script: call DestroyForce( udg_TempForce ). When I dont have the custom script it works, so you may be right. Since it is periodic, i want to make sure it does not leak

 

[Almia]

You don't need to destroy All Players because it doesn't leak.

 

[AGNO12]

Would "all allies of player x" leak?

 

[Almia]

Correct.
Only All Players in forces doesn't leak

 

[Maker]

Correct.
Only All Players in forces doesn't leak

Each player is also set in a force -> bj_FORCE_PLAYER[index].