Leaderboard doesn't appear

[Craphter]

Im trying to make a leaderboard with everyone's kills, but it doesn't appear... I have it like this:

• Inicio
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Leaderboard - Create a leaderboard for (All players) titled Kills
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Player 1 (Red) controller) Equal to User
        • (Player 1 (Red) slot status) Equal to Is playing
      • Then - Actions
        • Player Group - Add Player 1 (Red) to JugadoresConectados
        • Unit - Create 1 Builder for Player 1 (Red) at (Center of Construccion 1 <gen>) facing 270.00 degrees
        • Leaderboard - Add Player 1 (Red) to (Last created leaderboard) with label (Name of Player 1 (Red)) and value Kills1
      • Else - Actions
        • Do nothing
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Player 2 (Blue) controller) Equal to User
        • (Player 2 (Blue) slot status) Equal to Is playing
      • Then - Actions
        • Player Group - Add Player 2 (Blue) to JugadoresConectados
        • Leaderboard - Add Player 2 (Blue) to (Last created leaderboard) with label (Name of Player 2 (Blue)) and value Kills1
      • Else - Actions
        • Do nothing
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Player 3 (Teal) controller) Equal to User
        • (Player 3 (Teal) slot status) Equal to Is playing
      • Then - Actions
        • Player Group - Add Player 3 (Teal) to JugadoresConectados
        • Leaderboard - Add Player 1 (Red) to (Last created leaderboard) with label (Name of Player 3 (Teal)) and value Kills1
      • Else - Actions
        • Do nothing
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Player 4 (Purple) controller) Equal to User
        • (Player 4 (Purple) slot status) Equal to Is playing
      • Then - Actions
        • Player Group - Add Player 4 (Purple) to JugadoresConectados
        • Leaderboard - Add Player 4 (Purple) to (Last created leaderboard) with label (Name of Player 4 (Purple)) and value Kills4
      • Else - Actions
        • Do nothing
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Player 5 (Yellow) controller) Equal to User
        • (Player 5 (Yellow) slot status) Equal to Is playing
      • Then - Actions
        • Player Group - Add Player 5 (Yellow) to JugadoresConectados
        • Leaderboard - Add Player 5 (Yellow) to (Last created leaderboard) with label (Name of Player 5 (Yellow)) and value Kills5
      • Else - Actions
        • Do nothing
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Player 6 (Orange) controller) Equal to User
        • (Player 6 (Orange) slot status) Equal to Is playing
      • Then - Actions
        • Leaderboard - Add Player 6 (Orange) to (Last created leaderboard) with label (Name of Player 6 (Orange)) and value Kills6
        • Player Group - Add Player 6 (Orange) to JugadoresConectados
      • Else - Actions
        • Do nothing
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Player 7 (Green) controller) Equal to User
        • (Player 7 (Green) slot status) Equal to Is playing
      • Then - Actions
        • Leaderboard - Add Player 7 (Green) to (Last created leaderboard) with label (Name of Player 7 (Green)) and value Kills7
        • Player Group - Add Player 7 (Green) to JugadoresConectados
      • Else - Actions
        • Do nothing
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Player 8 (Pink) controller) Equal to User
        • (Player 8 (Pink) slot status) Equal to Is playing
      • Then - Actions
        • Player Group - Add Player 8 (Pink) to JugadoresConectados
        • Leaderboard - Add Player 8 (Pink) to (Last created leaderboard) with label (Name of Player 8 (Pink)) and value Kills8
      • Else - Actions
        • Do nothing
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Player 9 (Gray) controller) Equal to User
        • (Player 9 (Gray) slot status) Equal to Is playing
      • Then - Actions
        • Player Group - Add Player 9 (Gray) to JugadoresConectados
        • Leaderboard - Add Player 9 (Gray) to (Last created leaderboard) with label (Name of Player 9 (Gray)) and value Kills9
      • Else - Actions
        • Do nothing
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Player 10 (Light Blue) controller) Equal to User
        • (Player 10 (Light Blue) slot status) Equal to Is playing
      • Then - Actions
        • Player Group - Add Player 10 (Light Blue) to JugadoresConectados
        • Leaderboard - Add Player 10 (Light Blue) to (Last created leaderboard) with label (Name of Player 10 (Light Blue)) and value Kills10
      • Else - Actions
        • Do nothing
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Player 11 (Dark Green) controller) Equal to User
        • (Player 11 (Dark Green) slot status) Equal to Is playing
      • Then - Actions
        • Player Group - Add Player 11 (Dark Green) to JugadoresConectados
        • Leaderboard - Add Player 11 (Dark Green) to (Last created leaderboard) with label (Name of Player 11 (Dark Green)) and value Kills11
      • Else - Actions
        • Do nothing
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Player 12 (Brown) controller) Equal to User
        • (Player 12 (Brown) slot status) Equal to Is playing
      • Then - Actions
        • Player Group - Add Player 12 (Brown) to JugadoresConectados
        • Leaderboard - Add Player 12 (Brown) to (Last created leaderboard) with label (Name of Player 12 (Brown)) and value Kills12
      • Else - Actions
        • Do nothing
    • Leaderboard - Change the display style for (Last created leaderboard) to Show the title, Show labels, Show values, and Show icons
    • Leaderboard - Show (Last created leaderboard)
    • Visibility - Create an initially Enabled visibility modifier for Player 1 (Red) emitting Visibility across Construccion 1 <gen>
    • Visibility - Create an initially Enabled visibility modifier for Player 2 (Blue) emitting Visibility across Construccion 1 <gen>
    • Visibility - Create an initially Enabled visibility modifier for Player 3 (Teal) emitting Visibility across Construccion 1 <gen>
    • Visibility - Create an initially Enabled visibility modifier for Player 4 (Purple) emitting Visibility across Construccion 1 <gen>
    • Visibility - Create an initially Enabled visibility modifier for Player 5 (Yellow) emitting Visibility across Construccion 1 <gen>
    • Visibility - Create an initially Enabled visibility modifier for Player 6 (Orange) emitting Visibility across Construccion 1 <gen>
    • Visibility - Create an initially Enabled visibility modifier for Player 7 (Green) emitting Visibility across Construccion 1 <gen>
    • Visibility - Create an initially Enabled visibility modifier for Player 8 (Pink) emitting Visibility across Construccion 1 <gen>
    • Visibility - Create an initially Enabled visibility modifier for Player 9 (Gray) emitting Visibility across Construccion 1 <gen>
    • Visibility - Create an initially Enabled visibility modifier for Player 10 (Light Blue) emitting Visibility across Construccion 1 <gen>
    • Visibility - Create an initially Enabled visibility modifier for Player 11 (Dark Green) emitting Visibility across Construccion 1 <gen>
    • Visibility - Create an initially Enabled visibility modifier for Player 12 (Brown) emitting Visibility across Construccion 1 <gen>
    • Camera - Pan camera for Player 1 (Red) to (Center of Construccion 1 <gen>) over 0.00 seconds
    • Camera - Pan camera for Player 2 (Blue) to (Center of Construccion 1 <gen>) over 0.00 seconds
    • Camera - Pan camera for Player 3 (Teal) to (Center of Construccion 1 <gen>) over 0.00 seconds
    • Camera - Pan camera for Player 4 (Purple) to (Center of Construccion 1 <gen>) over 0.00 seconds
    • Camera - Pan camera for Player 5 (Yellow) to (Center of Construccion 1 <gen>) over 0.00 seconds
    • Camera - Pan camera for Player 6 (Orange) to (Center of Construccion 1 <gen>) over 0.00 seconds
    • Player - Set Player 1 (Red) Current gold to 10
    • Player - Set Player 2 (Blue) Current gold to 10
    • Player - Set Player 3 (Teal) Current gold to 10
    • Player - Set Player 4 (Purple) Current gold to 10
    • Player - Set Player 5 (Yellow) Current gold to 10
    • Player - Set Player 6 (Orange) Current gold to 10
    • Player - Set Player 7 (Green) Current gold to 10
    • Player - Set Player 8 (Pink) Current gold to 10
    • Player - Set Player 9 (Gray) Current gold to 10
    • Player - Set Player 10 (Light Blue) Current gold to 10
    • Player - Set Player 11 (Dark Green) Current gold to 10
    • Player - Set Player 12 (Brown) Current gold to 10

What am I missing?

 

[tagg1080]

Change "Map initialization" to "elapsed time is .01 seconds"

That helps with a lot of things.

 

[Craphter]

Thanks a lot tagg1080, it worked...
Only a little detail, beside my kills appears an image:

What is it?

 

[tagg1080]

• Leaderboard
  • Events
  • Conditions
  • Actions
    • Leaderboard - Change the display style for (Last created leaderboard) to Show the title, Show labels, Show values, and Show icons

Use that, change what you want to show/hide.
Am pretty sure you want to hide icons.

 

[Craphter]

Thnks a lot dude

 

[tagg1080]

NP, just ask if you have any other questions.

 

[yioup]

I reccomend organizing that trigger... maybe make 2 or 3 at the least, unless you are sure you won't change any of the triggers. just something to make your life easier later on.

 

[Craphter]

Errr... y is that?

 

[yioup]

*sigh* simply having one trigger will make it difficult to detect errors... things like that!!
Im not ane encyclopedia I can't define why organization is important. once you try to update your game (if you do) it will be tougher... just try it.

 

[En_Fuego]

No. One trigger is good when you're using it at initialization. It's not difficult to organize. Just understand what you're coding and what you've coded.

 

[Aesthetics]

Since your problem is solved, I'll add a suggestion instead.

The trigger is horrible. I'm assuming you don't know how to use Loop Integers A & B and Player Groups with "And" conditions. If you would, the trigger would be 4/5 shorter and easier on your eyes.

 

[Craphter]

Well, no, i never used a loop...
How would it help?

 

[reason 3]

You could create a loop for all players(or those you want),and you don't have to make the trigger for each player individually.

 

[Galm]

just a little help

Check out your third player "if conditions then do actions else actions" Player teal is on it, just look at your second action, it has player red, if you havent fixed it then you need to, just to make your map the way you wanted it to be.

 

[Craphter]

@reason_3, thnks a lot, i was wondering if there wasn't a shorter way to do all this
@Glam thnks for pointing the mistake =)
I really wanted the trigger to be shorter anyway
Again, thanks all for ur help, allready gave rep =D


Edit: i really looked around but i cant find where the loop action is...
Help?

 

[reason 3]

No problem,glad i helped.If you need anything else,feel free to PM me.

 

[manstie]

Never use Do Nothing.

Every time you use this function:

call DoNothing()
Do Nothing

You call this JASS function:

function DoNothing takes nothing returns nothing
endfunction

Which takes up valuable processing time.
By choosing not to use call DoNothing(), you win 12.3% speed increase!

call DoNothing()+return executed 2162 times per milisecond.
//null+return executed 26668 times per milisecond.
The real benefit of not using call DoNothing() is 0.00046 ms per call.

Posted by 3ICE @ 6:26 am

Aka. It creates lag.

 

[reason 3]

Not exactly!The Do Nothing exists to make triggers more safe,cause there are possibilities for some errors when you don't use it.But most times it isn't required and in fact it slows game speed.

 

[En_Fuego]

Not exactly!The Do Nothing exists to make triggers more safe,cause there are possibilities for some errors when you don't use it.

This is a lie.

 

[reason 3]

This is a lie?Can you tell me exactly where i am wrong?

 

[En_Fuego]

Yes. The part that's wrong is the part that I quoted.

 

[reason 3]

Well in fact if this is just useless why does it exist?So many updates have been made in Wc3 world editor lately,wouldn't just they remove it?

 

[En_Fuego]

Because when you use "If/Then/Else--" you can use it for the Else if you don't want Else to do anything. However, must people use "If/Then/Else Do Multiple Actions" because they've wised up and it doesn't require an Else if you don't want it to.

Please, do tell me how not using it will cause errors. I'm interested.

 

[reason 3]

That's exactly what i am saying...I use If/Then/Else--" a lot in my map and i leave the Else part without adding nothing...Some people claim that by leaving it blank you make an unsafe coding.I'm not sure of it...but i leave it blank too in my map,cause it slows me down.

 

[En_Fuego]

If you're not sure, then don't say things like

The Do Nothing exists to make triggers more safe,cause there are possibilities for some errors when you don't use it.

 

[reason 3]

Forums exist in order to express our opinions and get answers...

 

[En_Fuego]

So now you're saying your opinion is that it's safer to use Do Nothing? I'm confused. You're contradicting yourself.

 

[reason 3]

Well i'm saying what i have heard,that using Do Nothing make code safer.BUT although i don't use it either causes it slows me down.That's all...

 

[En_Fuego]

Not exactly!The Do Nothing exists to make triggers more safe,cause there are possibilities for some errors when you don't use it.But most times it isn't required and in fact it slows game speed.

Here, you're saying that using Do Nothing makes your trigger safer.

That's exactly what i am saying...I use If/Then/Else--" a lot in my map and i leave the Else part without adding nothing...Some people claim that by leaving it blank you make an unsafe coding.I'm not sure of it...but i leave it blank too in my map,cause it slows me down.

Now you're saying that you don't know and that it's just something you've heard. Which is fine, but...

Forums exist in order to express our opinions and get answers...

you're saying that about your second post I quoted, which makes no sense in response to what I posted. unless you're saying that about your first post I quoted, which still makes no sense because you're not giving an opinion or asking.

Well i'm saying what i have heard,that using Do Nothing make code safer.BUT although i don't use it either causes it slows me down.That's all...

you couldn't say that 10 minutes ago? Here are some tips:

I know English isn't your primary language, and that's ok (however, if it is I suggest you take some grammar tutoring). BUT, learn about things like punctuation and how you space after periods (.), commas (,), and other punctuation. Also, try to explain your thoughts more clearly. There's a difference between "I heard" and "I know".

 

[reason 3]

Wow,now i even got confused...Nevermind let's leave it as is.Although you seem to have been carefully listening to everything i said.I would +rep you,but you have rep off ^^

 

[En_Fuego]

You can rep me if you like. I can still see it ^.^

 

[reason 3]

ok,done!Check the msg that comes with it too

 

[manstie]

If you used JASS, it would make a bit more sense.