Knives Attack v1.1

[Moderator]

Approved

This is a useful alternative for Fan of Knives. The spell is triggered quite well and it is easily configurable.

The blood effetc could be adjusted or changed, it could look a bit better.

Old review

Required changes:

• Make the caster deal the damage

Suggested changes:

• Save the Cos and Sin values of the angle, then you don't need to
  calculate them during each loop, also cuts off the degtorad conversion
• • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • And - All (Conditions) are true
        • Conditions
          • (KA_TempUnit[2] is dead) Equal to False
          • (KA_TempUnit[2] belongs to an ally of KA_Owner)...
  ->
  
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • (KA_TempUnit[2] is dead) Equal to False
      • (KA_TempUnit[2] belongs to an ally of KA_Owner)...
• Get rid of Remove Dummy trigger, the dummy is set to not decay and
  has 1 second death time. It will be removed quickly automatically
• With low cooldown values, KA_Group index keeps on growing and
  it can eventually grow too high and the spell won't work correctly

 

[Ofel]

Tell me if you find bugs...

 

[Ofel]

~~Updated~~

 

[CoLd Bon3]

The "Remove Dummy" trigger is not needed. Just set this field "Combat - Death Type" (in object editor) to "Can't rise, Does not decay" (which you have did) and you will be okay.
Because when a unit dies, it automatically gets removed from the game after it decays. Since the dummy doesn't decay, it is immediately removed from the game.
I will also give a suggestion. Make a configurable that defines if the knives go in random directions or in specified angles (as you did). Because if they spawn randomly, it looks a bit more cooler. The user will still be able to change between the two types, though.
This is only a suggestion, remember.

Overall, the spell is great, i like it. The code also appears to be good. Good job! I will give it a 4/5 and +rep to you.

EDIT : Also, use the "hidden" BB code function for your trigger so that the hivers can show/hide whatever is inside. With extremely long triggers, it's really annoying to scroll like mad.

 

[Ofel]

The "Remove Dummy" trigger is not needed. Just set this field "Combat - Death Type" (in object editor) to "Can't rise, Does not decay" (which you have did) and you will be okay.
Because when a unit dies, it automatically gets removed from the game after it decays. Since the dummy doesn't decay, it is immediately removed from the game.
I will also give a suggestion. Make a configurable that defines if the knives go in random directions or in specified angles (as you did). Because if they spawn randomly, it looks a bit more cooler. The user will still be able to change between the two types, though.
This is only a suggestion, remember.

Overall, the spell is great, i like it. The code also appears to be good. Good job! I will give it a 4/5 and +rep to you.

EDIT : Also, use the "hidden" BB code function for your trigger so that the hivers can show/hide whatever is inside. With extremely long triggers, it's really annoying to scroll like mad.

Accepted...
Thx....so i just need to kill the dummy without removing it with trigger ??

 

[Almia]

Review #1
1)If you are going to use SUXY(SetUnitX/Y),never use locations.
2)Some variables should have prefixes.Ex. PR_MyVar
3) Animation - Change KA_TempUnit[2]'s size to (KA_Scale[KA_Level]%, KA_Scale[KA_Level]%, KA_Scale[KA_Level]%) of its original size
Only stretch X(meaning just put 0 on the other 2 real arguements,just put the scale on the first real)
4)If you are going to create dummies while cacheing,use coordinates instead.
5) Hashtable - Save 0.00 as (Key distance) of KA_Handle_Id in KA_Hashtable
you can remove this line,because loading it defaults to 0 so it is equal to 0 when you remove this.
6) Custom script: call DestroyEffect(AddSpecialEffectLoc(udg_KA_End_Effect, udg_TempLoc))
create the effect on coordinates.
7)If you are going to use an arc method,you dont need to save/load flying height(dunno becauses i havent tested this yet)
8)just like Cold_Bon3 said,remove the units after killing it.Because corpse leaks.
9)Are you using dummy.mdx? if so,credit Vexorian

This spell is marked as Needs Fix

 

[Ofel]

I don't know exactly who's the creator of dummy.mdx...that i know there is 3 person....
But i only knew 1, Vexorian, so i don't give him credit yet....but i'll give it now....

If you are going to use an arc method,you dont need to save/load flying height

I am not going to use that....

 

[Almia]

the 3 person:
Anitarf,Vexorian,Infrane
but Vexorian started it.

 

[Ofel]

If you are going to create dummies while cacheing,use coordinates instead.

What's the reason and example...!!!???

Custom script: call DestroyEffect(AddSpecialEffectLoc(udg_KA_End_Effect, udg_TempLoc))
create the effect on coordinates.

What's the reason and example...!!!???

just like Cold_Bon3 said,remove the units after killing it.Because corpse leaks.

Need example...!!!???

 

[CoLd Bon3]

@Ofel The Editor, dude, to remove dummies you need only one single action, no triggers, no other things. Use this :
"Unit - Add Generic Expiration Timer"
If you give a timer like this, after X seconds the dummy is out of the game. It's game over for it!!

 

[Ofel]

Just a little question :
Can i save values with

• Custom script: Save...(....)

I mean without

• Custom script: Save...BJ(....)

Also, do i need to remove the "If" for turning on the loop trigger ??

 

[Almia]

^ Yes you can.
Save w/ bjs are Blizzard made,while those who havent are commons

In creating the dummy,you know it.You told me how to do it.
set udg_Dummy = CreateUnit(Player(15), 'hpea', 0, 0, 0)

In creating sfx:
call DestroyEffect(AddSpecialEffect(sfx,x,y))

After killing the unit,it isnt enough.Remove the unit.

Unit - Remove (which unit)

 

[BUP]

@Ofel The Editor, dude, to remove dummies you need only one single action, no triggers, no other things. Use this :
"Unit - Add Generic Expiration Timer"
If you give a timer like this, after X seconds the dummy is out of the game. It's game over for it!!

Hey,dude I think you're wrong.After giving the Expiration Timer,the unit only dies.It's not removed from the game.So it leaks.

 

[Ofel]

Get rid of Remove Dummy trigger, the dummy is set to not decay and
has 1 second death time. It will be removed quickly automatically

Moderator has said..!!

 

[BUP]

I don't understand.
Once,Mag rejected my spell for not removing the dummy

 

[CoLd Bon3]

I asked Maker yesterday especially for this and for BUP's spellpack. This is what he said

I tested with creating 12000 units and adding expiration timer. I saw no major leaks anyway. If there was a leak it was very small. Don't worry about it.

I took 4 data points, at 4k, 6k, 8k and 10k. After pausing the test for a while and checking the memory reseved, it was exactly 94352 K at all data points.

According to Maker, an expiration timer is enough.

 

[.OmG.]

Nice spell. Will use it in my map as upgraded fan of knives=)