Fan of Knives v1.1

[Moderator]

10:01, 22nd Jul 2012
Magtheridon96: This is a very adequate spell despite it's simplicity.

It would be better if (Owner of caster) is cached into a variable because it's being called inside a loop and thus will be repeated again and again and again though.
What would be also be nice is having the ability to easily configure the height range of the blades and the damage AoE too.

I guess I will approve this.
(If I set it to "Rejected", I would forget to get back to it after the contest.)

edit
One other thing, you forgot to give this a decent tooltip.

 

[Jazztastic]

Post reserved.

Lol I CnP'd the contest description. Looks fancy doesn't it?

 

[Almia]

This will be marked as needs fix by mag.
even if you see my spell entry or defskull's entry

 

[Jazztastic]

If everything works appropriately he could just say "No rating until after contest". Happens all the time.

 

[Magtheridon96]

Actually Radamantus, could you give me a link to your resource? Nevermind, done.

There's no logical reason as to why I shouldn't approve these resources.

 

[Almia]

Actually Radamantus, could you give me a link to your resource? Nevermind, done.

There's no logical reason as to why I shouldn't approve these resources.

Still rejected

 

[eubz]

trigger

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• (Number of units in (Units within 80.00 of point2 matching ((((Matching unit) belongs to an enemy of (Owner of target)) Equal to True) and ((((Matching unit) is alive) Equal to True) and (((Matching unit) is A structure) Equal to False))))) Greater than 0
• Then - Actions
• Custom script: set bj_wantDestroyGroup = true
• Unit - Cause caster to damage (Random unit from (Units within 80.00 of point2 matching ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) is alive) Equal to True) and (((Matching unit) belongs to an enemy of (Owner of target)) Equal to True))))), dealing knivesdamage[level] damage of attack type Pierce and damage type Normal
• Unit - Kill target
• Hashtable - Clear all child hashtables of child handle in FoK_hashtable
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• (Number of units in FanofKnivesGroup) Equal to 0
• Then - Actions
• Trigger - Turn off (This trigger)
• Else - Actions
• Else - Actions
• Hashtable - Save (timer - 0.03) as 2 of handle in FoK_hashtable

A unit group in this part leaks.

 

[CoLd Bon3]

Just one thing : set the movement type of the Fan of Knives unit to NONE (in the Object Editor). This way they can pass trough cliffs and non-playable map area. Otherwise the knives fly over cliffs like flying units, which is just crap. Also, when they reach the end of the map, they just maintain their angle, moving to the left or right, but they don't move forward. Test this and see what i'm talking about.

This is not a big problem but i thought you should know this. I haven't looked at the code... otherwise the spell is not bad.

 

[Magtheridon96]

@eubz: Not true, the "set bj_wantDestroyGroup = true" tells the enumeration that the group should be destroyed.

@CoLd_Bon3: That can be fixed using another method:


@Jazztastic: The method you can use here is factoring in the terrain Z.
Terrain Z + Flying height = Unit Z

To maintain a constant Unit Z for a varying, you should set the flying height to your height - Terrain Z.

You can get terrain Z by using the native GetLocationZ which takes a location. (set udg_z = GetLocationZ(udg_TempLoc).

 

[Jazztastic]

Just one thing : set the movement type of the Fan of Knives unit to NONE (in the Object Editor). This way they can pass trough cliffs and non-playable map area. Otherwise the knives fly over cliffs like flying units, which is just crap. Also, when they reach the end of the map, they just maintain their angle, moving to the left or right, but they don't move forward. Test this and see what i'm talking about.

This is not a big problem but i thought you should know this. I haven't looked at the code... otherwise the spell is not bad.

If they kept going into the edge of the map and actually went off the map it would bug and crash the game.

If the movement was set to none they could go through cliffs and still hit units when they are under the cliffs. That's a no-no aswell.

@Mag I might fix that up specifically for the contest. I'm going to have to change the tooltips and a few small things anyways.

 

[CoLd Bon3]

If they kept going into the edge of the map and actually went off the map it would bug and crash the game.

I set the movement type to none and everything worked well, the knives went off the map but the game didn't crashed. If the movement type is none, you can solve the problem with the cliffs too. Simply check if the knife is nearing a cliff and remove it, so that it can't pass trough it. Otherwise the knives increase height and fly over cliffs which is just.. crap.

 

[Flopfish]

Or you could set it to Hover so instead of flying above terrain or passing through solid material like real knives do, it actually stops when it hits something.

 

[CoLd Bon3]

Or you could set it to Hover so instead of flying above terrain or passing through solid material like real knives do, it actually stops when it hits something.

Yes but there will still be a problem.

Also, when they reach the end of the map, they just maintain their angle, moving to the left or right, but they don't move forward. Test this and see what i'm talking about.

The same thing will happen but when reaching a cliff instead. This will still happen at the end of the map...