Moderator
M
Moderator
12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.
28th Feb 2012
Maker: You still have memory leaks, systems are not MUI.
20 Feb 2012
Bribe: You still have memory leaks.
18 Feb 2012
Bribe: This leaks two locations (forward/backward move trigger):
Left/right key face (leak highlighted):
You leak a lot in other triggers too. Please read:
Things that Leak
How to detect leaks
IcemanBo: Too long as NeedsFix. Rejected.
28th Feb 2012
Maker: You still have memory leaks, systems are not MUI.
20 Feb 2012
Bribe: You still have memory leaks.
18 Feb 2012
Bribe: This leaks two locations (forward/backward move trigger):
JASS:
SetUnitPositionLoc( gg_unit_hfoo_0032, PolarProjectionBJ(GetUnitLoc(gg_unit_hfoo_0032), (udg_forward_speed), GetUnitFacing(gg_unit_hfoo_0032)) )
Left/right key face (leak highlighted):
JASS:
Unit - Move gg_unit_hfoo_0032 instantly to @(Position of gg_unit_hfoo_0032)@ facing ((Facing of gg_unit_hfoo_0032) + 5.00) degrees
You leak a lot in other triggers too. Please read:
Things that Leak
How to detect leaks
Reviewed by Maker, keyboard jump and movement + camera System v0.01, 16th Feb 2012
If you are trying to get a keboard jump/movement system approved, then you really need to do something impressive. Currently the systems are too simple.
- Only upload completed resources, v0.01 isn't complete
- Camera and keyboard systems leak locations and are not MUI
- Jump system leaks locations, uses bad indexing method and the jump arc is done is a very simple way
Are the other systems there just fr the map or should they be reviewed also?