KB3D - MMS 3D Extended

[Antares]

Please add the original author to the list of authors.

The new features you introduced look solid, but you should make it easier to figure out how to test them specifically. It took me quite some time to understand how to test the onHit trigger.

Once these changes I made, I will approve this and add a link to your version in the original.

 

[KitsuneTailsPrower]

Please add the original author to the list of authors.

The new features you introduced look solid, but you should make it easier to figure out how to test them specifically. It took me quite some time to understand how to test the onHit trigger.

Once these changes I made, I will approve this and add a link to your version in the original.

I would add him but his name won't show up. If you can figure out what I'm doing wrong feel free to add him.

I looked into it before. I adjusted the tooltips so you can see which abilities test the new features

 

[Antares]

I see, I can't get it to work either. Just add his name without a link for now.

 

[KitsuneTailsPrower]

I see, I can't get it to work either. Just add his name without a link for now.

Done

 

[Aldeia]

IS there something specific we need to copy/paste to a map that was using the old KB3D system?

---

I know that the system was not created for 24 players initially - did you account for that? (in terms of improvements)

set udg_KB3D_Harvester = CreateUnit(Player(15), 'hpea', 0, 0, 0)

For example, in this line the unit is still created for player 15 (but in reforged this is no longer a neutral player)

---

function KB3D_GetCoordinatesZ takes real x, real y returns real
    local location L = Location(x,y)
    local real r = 0
    local integer I = 0
    local integer t = 12
    local boolean B = true
    loop
    exitwhen I == 12
        if GetPlayerSlotState(Player(I)) != ConvertPlayerSlotState(1) then
            set t = t - 1
        else
            if IsLocationFoggedToPlayer( L , Player(I)) then
                set B = false
                set t = t - 1
            endif
        endif
        set I = I + 1
    endloop
    if B or t == 0 then
        set r = GetLocationZ(L)
    endif
    call RemoveLocation(L)
    set L = null
    return r
endfunction

The same goes for Get Z coordinates
Would be nice to have such things fixed too.

---

Not trying to be negative - just pointing on some flaws I noticed - though I am not big of a jass knower myself.

 

[Antares]

A small extension of an older knockback system.

Approved

 

[Ralle]

Take a look at the authors now.

 

[Antares]

IS there something specific we need to copy/paste to a map that was using the old KB3D system?

---

I know that the system was not created for 24 players initially - did you account for that? (in terms of improvements)

set udg_KB3D_Harvester = CreateUnit(Player(15), 'hpea', 0, 0, 0)

Yes, if you could fix that, that would be great.

 

[Daffa]

I recommend to use the NEUTRAL_PASSIVE Player instead of specific player so it can preserve backward compatibility if it matters