JMS's Elemental SpellPack

[Moderator]

15:22, 16th Jun 2010
Hanky:
Full of leaks and not even MPI or MUI. Before you submit a spell please read at first the spell submission rules.

 

[jms]

I Knw The Description of the spells isnt that good but the spells are... the spells are GUI , MPI but not MUI...x$

 

[-Berz-]

Lies: "the spells are GUI , MPI" spells aren't MPI at all, all spells supports only one level, they leak every single location, unit group,.. bunch of "do nothing", waits... I could go on but you get the idea.

Anyway badly coded spell pack, I suggest you read some tutorials about triggering(leaks, variables...), and spell uploading rules(level support...).

I vote for rejection until update.

Sorry man, but this is how it is.

 

[jms]

wtf man,.. they are MPI and there is no " waits " and " do nothing " ..!!

 

[-Berz-]

Wait example

• FlameThrower
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to FlameThrower
  • Actions
    • Set FT_Caster = (Casting unit)
    • Set FT_Point[1] = (Position of FT_Caster)
    • Set FT_Point[2] = (Target point of ability being cast)
    • Unit - Pause FT_Caster
    • For each (Integer A) from 1 to 5, do (Actions)
      • Loop - Actions
        • Animation - Play FT_Caster's spell 1 animation
        • Unit - Create 1 Caster Dummy for (Owner of FT_Caster) at FT_Point[1] facing (Facing of FT_Caster) degrees
        • Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
        • Unit - Order (Last created unit) to Neutral Pandaren Brewmaster - Breath Of Fire FT_Point[2]
        • Wait 0.10 seconds
        • Unit - Create 1 Caster Dummy for (Owner of FT_Caster) at FT_Point[2] facing (Facing of FT_Caster) degrees
        • Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
        • Unit - Order (Last created unit) to Neutral Pandaren Brewmaster - Breath Of Fire (FT_Point[2] offset by 256.00 towards (Facing of FT_Caster) degrees)
        • Wait 0.10 seconds
        • Unit - Create 1 Caster Dummy for (Owner of FT_Caster) at (FT_Point[2] offset by 256.00 towards (Facing of FT_Caster) degrees) facing (Facing of FT_Caster) degrees
        • Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
        • Unit - Order (Last created unit) to Neutral Pandaren Brewmaster - Breath Of Fire (FT_Point[2] offset by 500.00 towards (Facing of FT_Caster) degrees)
    • Unit - Unpause FT_Caster

Do nothing example

• Angels Strike Loop
  • Events
    • Time - Every 1.00 seconds of game time
  • Conditions
  • Actions
    • Special Effect - Create a special effect at AS_Point[2] using Abilities\Spells\Other\Awaken\Awaken.mdl
    • Environment - Create a 1.00 second Temporary crater deformation at AS_Point[2] with radius 300.00 and depth 30.00
    • Unit Group - Pick every unit in (Units within 300.00 of AS_Point[2] matching (((Matching unit) belongs to an enemy of (Owner of AS_Caster)) Equal to True)) and do (Actions)
      • Loop - Actions
        • Unit - Cause AS_Caster to damage (Picked unit), dealing 100.00 damage of attack type Spells and damage type Divine
    • Set AS_Point[2] = (AS_Point[1] offset by (Random real number between 0.00 and 300.00) towards (Random real number between 0.00 and 300.00) degrees)
    • Set AS_Times = (AS_Times + 1.00)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • AS_Times Equal to 6.00
      • Then - Actions
        • Trigger - Turn off (This trigger)
        • Set AS_Times = 0.00
      • Else - Actions
        • Do nothing

You don't get the meaning of MPI don't you? Means that one unit of any player is able to cast this spell at the same time and these spells can't be well they can but they would bug.

I think I said enough.

 

[jms]

i only did the " wait exemple " just for fun,look at the others there is no wait.. and what does the " do nothing " make go wrong..!!

 

[-Berz-]

Nothing compared to all of your leaks :/

 

[jms]

what leaks..??

 

[-Berz-]

Locations and unit groups.

You set the variables correctly but you don't remove them:

CustonScript: call RemoveLocation(udg_<Your_Loc_Var>) [for points]
CustonScript: call DestroyGroup(udg_<Your_Group_Var>) [for unit groups]

Also you can get this tool http://www.hiveworkshop.com/forums/tools-560/leak-check-1-3-a-62951/ here and It will help you fix the leaks on your map

And it's really simple to use:
copy your trigger in the box, press scan and there it is, it tells you where and how to fix it

 

[Kazzo]

Well i dont know about trigering and coding but i think the spell's are good with the effects and with the idea's i think you do a good job

 

[jms]

thx kazzo..xD and berzerker thx ill fix it and update it..xD

 

[-Berz-]

You do that =)

 

[jms]

but how to copy the trigger to this proggram..?!

 

[-Berz-]

Open trigger editor then click on some trigger, so it opens the trigger actions, then you slide your mouse up to the event, but do not copy event but move your mouse a bit up and right-click on the trigger name and then "copy as text", and bam you can copy the whole trigger text

 

[jms]

thank you