[JASS] Item Stack JASS - Please Verify

[Bloodbane7]

I have this JASS trigger, can I just copy and paste it into another map err right? And items will still stack? AND does this trigger stack every item that is acquired?
JASS trigger-

function Combine_Items_Conditions takes nothing returns boolean
    return GetItemCharges(GetManipulatedItem()) > 0 
endfunction

function Combine_Items_Actions takes nothing returns nothing
    local item NEWITEM = GetManipulatedItem()
    local unit OURUNIT = GetManipulatingUnit()
    local integer MAXIMUM = 15  //The max no. of charges allowed
    local integer ITEMCOUNT = 0
    local integer ITEMLOOP = 0
    local integer CHARGES = 0
    
    loop
        exitwhen ITEMLOOP > 6
        if GetItemTypeId(NEWITEM) == GetItemTypeId(UnitItemInSlot(OURUNIT, ITEMLOOP)) then
            if GetItemCharges(UnitItemInSlot(OURUNIT, ITEMLOOP)) + GetItemCharges(NEWITEM) <= MAXIMUM then
                if not (UnitItemInSlot(OURUNIT, ITEMLOOP) == NEWITEM) then                
                    set CHARGES = GetItemCharges(UnitItemInSlot(OURUNIT, ITEMLOOP)) + GetItemCharges(NEWITEM)
                    call SetItemCharges(UnitItemInSlot(OURUNIT, ITEMLOOP), CHARGES)
                    call RemoveItem(NEWITEM)
                    set ITEMLOOP = 7
                endif
            endif
        endif
        if (ITEMLOOP < 7) then
            set ITEMLOOP = ITEMLOOP + 1
        endif
    endloop

EDIT:
probably should have put this under Triggering and Script= sorry people

 

[MortAr]

Line 28: syntax error
Line 28: Missing endloop
Line 28: Missing endfunction

 

[TriggerHappy]

A little better.

function Combine_Items_Conditions takes nothing returns boolean
    return GetItemCharges(GetManipulatedItem()) > 0
endfunction

function Combine_Items_Actions takes nothing returns nothing
    local item NEWITEM = GetManipulatedItem()
    local unit OURUNIT = GetManipulatingUnit()
    local integer id = GetItemTypeId(NEWITEM) // saves function calls
    local integer c  = GetItemCharges(NEWITEM) // saves function calls
    local integer MAXIMUM = 15  //The max no. of charges allowed
    local integer ITEMCOUNT = 0
    local integer ITEMLOOP = 0
    local integer CHARGES = 0

    loop
        exitwhen ITEMLOOP > 6
        if id == GetItemTypeId(UnitItemInSlot(OURUNIT, ITEMLOOP)) then
            if GetItemCharges(UnitItemInSlot(OURUNIT, ITEMLOOP)) + c <= MAXIMUM then
                if not (UnitItemInSlot(OURUNIT, ITEMLOOP) == NEWITEM) then
                    set CHARGES = GetItemCharges(UnitItemInSlot(OURUNIT, ITEMLOOP)) + GetItemCharges(NEWITEM)
                    call SetItemCharges(UnitItemInSlot(OURUNIT, ITEMLOOP), CHARGES)
                    call RemoveItem(NEWITEM)
                    set ITEMLOOP = 7
                endif
            endif
        endif
        if (ITEMLOOP < 7) then
            set ITEMLOOP = ITEMLOOP + 1
        endif
    endloop
    
    set OURUNIT = null // Leaks otherwise.
    set NEWITEM = null
endfunction

 

[Bloodbane7]

So now it works? And yes I was aware of the errors before, just not until after the post =p.

 

[Adiktuz]

yeah, you can just copy-paste it....

 

[Bloodbane7]

Ok...I guess this works better than the GUI version I made while waiting for this reply- Although I will have other uses for this...Thanks!

 

[Adiktuz]

I guess its better if you use the one posted by TriggerHappy187 as it cleans the leaks your trigger has.

 

[Bloodbane7]

Lol ok ill could just disable my 10 GUI triggers and use this one...much cleaner and where it says "max number of charges" what happens when the player reaches max? Do they start another stack? Because I dont want 2 stacks.

 

[Adiktuz]

On the current trigger it will cause another stack... but you can add some ELSE line for the

IfGetItemCharges(UnitItemInSlot(OURUNIT, ITEMLOOP)) + c <= MAXIMUM

so that it will drop the item if the charges will reach max.... I'm not sure about that but It may work... anyway change

setCHARGES=GetItemCharges(UnitItemInSlot(OURUNIT, ITEMLOOP))+GetItemCharge(NEWITEM)

to

set CHARGES = GetItemCharges(UnitItemInSlot(OURUNIT, ITEMLOOP)) + c

I think he just forgot it...

 

[Bloodbane7]

which function would i put this in? or would i just paste it at the bottom?

 

[Adiktuz]

which function would i put this in? or would i just paste it at the bottom?

before the second endif if I'm correct..

if id == GetItemTypeId(UnitItemInSlot(OURUNIT, ITEMLOOP)) then            
   if GetItemCharges(UnitItemInSlot(OURUNIT, ITEMLOOP)) + c <= MAXIMUM then               
          if not (UnitItemInSlot(OURUNIT, ITEMLOOP) == NEWITEM) then                    
          set CHARGES = GetItemCharges(UnitItemInSlot(OURUNIT, ITEMLOOP)) + c                  
          call SetItemCharges(UnitItemInSlot(OURUNIT, ITEMLOOP), CHARGES)                    
          call RemoveItem(NEWITEM)                    
          set ITEMLOOP = 7                
          endif
    else
    //actions            
    endif        
endif

 

[Bloodbane7]

like this?

endif
(your post
endif
In that space? lol?

 

[Adiktuz]

like this?

endif
(your post
endif
In that space? lol?

yeah.. see my post above, i've edited it.

 

[Bloodbane7]

I tried to rap it in JASS and ask you but it comes out wrong when I copy and paste it... lol so im not going to ask you to re-type the whole thing....so i have to add

else
(your script?)

 

[Adiktuz]

what problem do you get? do you only paste the trigger you posted?

it should have some line at the bottom...

make a trigger with the event Unit-Acquires an item and convert it to custom script then copy paste all lines after the
//====================================

then change some of the values to your trigger's
like this

set gg_Trig_xxxx = CreateTrigger() //set the xxxx to your trigger's name
call TriggerResgisterEvent = xxx //only change the trigger name not the event
//for all function names change it to the names of the functions in your trigger... I think you can do it yourself, I'm not with my WE so I cannot check the right ones for you.. sorry.

and yes, just add (your script) after the else