Item and Unit Cost System v1.0.1.0

[Moderator]

18th Apr 2016

Your resource has been reviewed by BPower.
In case of any questions or for reconfirming the moderator's rating,
please make use of the Quick Reply function of this thread.

Review:

In theory a useful piece of code.
In fact it was coded many times on TheHelper and also here on TheHiveWorkshop.
There are versions without the issues listed below, therefore I altered my previous
moderator review and set this resource back to Need Fix.
I was a greenhorn 2 years before...

Using a pre-defined area to detect bought items is acceptable as long
as no other actions take part in this rect. Don't forget that items have a pathing size aswell.

I don't see the need to track all these player unit events.
Object cost should be calculated and cached on demand, not by default.

Items neither influence the food amount nor the food cap. What the heck are you doing there?

Troubleshooting:

• The function arguments don't make sense at all.
  It should be either the item handle or the item type id and not both.
  For example: function RCSGetItemGoldCostById takes item itm, integer id returns integer
  ---
• The merchant should preferably belong to a neutral player and not player 0.
  ---
• As naming convention I would prefer RSC_DoThis over RSCDoThis.
  ---

•     function RCSGetItemInitialChargesById takes item itm, integer id returns integer
          local integer charges = GetItemCharges(itm)
          if not HaveSavedInteger( udg_RCSHashtable, 4, id * -1) then
              call RCSStoreItemCosts( id)
          endif
          if charges > 0 then
              return LoadInteger( udg_RCSHashtable, 4, id * -1) * charges
          endif
          return LoadInteger( udg_RCSHashtable, 4, id * -1)
      endfunction

  ^This doesn't look correct to me.

Review changelog:

1. -

 

[Kazeon]

very nice and simply useful..
thought it can be used for various unique systems..

don't know about the code..

I lol-ed a little about your changelog inside the map..

 

[deathismyfriend]

I always put changelog in map lol.

 

[Kazeon]

yeah, but why did you give some code tags like

Hidden

there?

 

[deathismyfriend]

It makes it easier to copy and paste the changelog to the description when i add to it.

 

[Rheiko]

• Set RCSHashtable = (Last created hashtable)

when did you create the hashtable?

 

[BPower]

What's wrong with native GetUnitGoldGost(unitid) and GetUnitWoodCost(unitid) ?

Natives

native GetUnitGoldCost takes integer unitid returns integer
native GetUnitWoodCost takes integer unitid returns integer

Edit: Nice system, I could be useful if you want to substitute for instance gold with wood, wood with gold , gold with a custom resource, sort units by costs or food, ....

And it doesn't have to run on top speed, so forget about what I've posted above.

 

[deathismyfriend]

• Set RCSHashtable = (Last created hashtable)

when did you create the hashtable?

I create the hashtable in the jass code. I use one hashtable for all my RCS systems. I have this one and the kills counter. I am coming up with one maybe two more. Since i don't want to create it over and over it is easier to manage in jass i use an ITE and check if it is null if it is null then i create it. That way it won't be created twice or more if both systems are used. It also allows my systems to only use one hashtable.

I create the hashtable here.

if udg_RCSHashtable == null then
            set udg_RCSHashtable = InitHashtable()
        endif

Also the variables trigger is to simply make it easier to import into a map. It is meant to be deleted or disabled like in my map.

 

[Chaosy]

this could indeed be useful.
I guess that you somehow buys an item / unit and then calculate how much gold/lumber are missing compared to what you had. Atleast that's the only way I can think of. Doesnt this use a lot of space in a hashtable?

 

[deathismyfriend]

This indeed uses a decent amount of space in a hashtable but only the higher portion.

The medium portion which is used by GetHandleId is untouched. Also the low portion which is mainly used by GetUnitUserData with a unit indexer is untouched. So it leaves a lot of space left to be used.

 

[IcemanBo]

I tested this a bit, and generally it worked fine for me.

Onle one note I would make.. stacked items wont be registered with higher costs. They still seem to cost as only 1 of it's type.

But anyway, this might be useful for some special maps.

 

[deathismyfriend]

I'll take a look at stacked items i knew i forgot something.

I tested this a bit, and generally it worked fine for me.

Onle one note I would make.. stacked items wont be registered with higher costs. They still seem to cost as only 1 of it's type.

But anyway, this might be useful for some special maps.

Edit: Updated and fixed.

 

[BPower]

- Training a not registered unit doesn't increase used food.
- Constructing the first farm does decrease the food cap, by the amount the farm should provide.
- Once you reach low or high costs, you get the Blizzard message, if you create a not registered unit :/ ( because you set the food to 0 and back to current)
- In did CnP the API for each function and didn't change it for each individually. It's always written Get....ById
- For items it seems to work well.
- In my opinion you should change function names to: RCSGetItemGoldCostById --> GetItemGoldCostById.
- You may explain in your demo, why any UnitIndexer could be paused.

Just run the system with Player(PLAYER_NEUTRAL_PASSIVE) instead Player(0) and all mentioned problems vanish.

 

[deathismyfriend]

Updated to fix the bugs you have noted.
Food cap is not decreased and is recorded correctly.
You can now record food cost and food cap increase / decrease for items and units.
The names will not change.
The blizzard message will no longer appear.

 

[BPower]

The ouput of LoadInteger( udg_RCSHashtable, 0, id * -1) * charges is charges times too high.
In Example a stack of sentry wards costs 150 gold, but the system will return
an item gold cost fee of 450. Obviously wrong because 1 sentry wards actually only costs 50 gold.
Once you store an item price, you have to devide the value with the number of charges, if that item has charges.

 

[deathismyfriend]

It should not do that since I create the item. It should create an item with only 1 charge. I will check that out when I can.

 

[BPower]

I think an item is created with the default amout of charges set in the object editor.

 

[deathismyfriend]

I think an item is created with the default amout of charges set in the object editor.

That makes sense.

Edit: I just tested it. You were correct.

Fixed the bugs and the API.
Also added a new function which allows a person to get the initial charges an item has when it is created.

 

[deathismyfriend]

You do not list the complete API in the comment head. For instance GetItemCostById is missing. Please fix this.

They are not meant to be there. If you take a look they take item and integer id. It is a lot safer for a GUIer to call the other function.

 

[GywGod133]

You can create a GUI System for this??

This will be Useful for all GUIers

 

[deathismyfriend]

This is GUI friendly. You don't have to touch anything in Jass.

In the jass script it shows the custom scripts that you need to call the functions.
Example:
Custom script: RCSGetItemGoldCost( udg_tempItem)
Put the item in question into a tempItem variable.
Then use the custom script above to get that items gold cost.

 

[Deleted member 219079]

What's wrong with native GetUnitGoldGost(unitid) and GetUnitWoodCost(unitid) ?

Couldn't you say you're referring to http://warcraft.ingame.de/maps/mappedia/Common.ai ?

 

[blancfaye7]

Some of the items do not work with this system. Some return a wrong lumber cost value.

Or is there something I'm doing wrong... I am using custom items.

 

[deathismyfriend]

Can you post the map so I can see what is wrong ? There shouldn't be any problems in my code but there is still a chance. I will look at it around Tuesday or Wednesday as I don't have a pc atm.

 

[blancfaye7]

Ack! Let me re-set the system as how I have set it up, then I will send it to you WHEN I am on my computer as well. Many thanks.

Let me add how I set it up though:

I have set the Marketplace Unit Type with the proper abilities to set up the system.
I have placed a region in the game where it is unreachable by the player.

I pasted (including all variables) the trigger folder system to mine.