[vJASS] Issue with nested loops, possible bug

[lolreported]

I'm currently having a massive issue with a nested loop, see code (some irrelevant code removed):

library JustAnotherLibrary initializer Init
    globals
        //...
        private constant integer PLAYER_MAX_CELLS_ROW = 3 // Max cells up/down
        private constant integer PLAYER_MAX_CELLS_COL = 5 // Max cells left/right
        //...
    endglobals

    //... irrelevant code here

    private function Init takes nothing returns nothing
        local integer i = 0
        local integer cX = 0
        local integer cY = 0

        //...

        set battleCellUniqueID = 0
        set i = 0
        loop
        exitwhen(i > 24)
            // Player init stuff

            if (GetPlayerController(Player(i)) == MAP_CONTROL_USER and GetPlayerSlotState(Player(i)) == PLAYER_SLOT_STATE_PLAYING) then
                // Setup player battle cells
                set playerBattleAreaX[i] = -450.0 //temp
                set playerBattleAreaY[i] = -700.0
  
                set cX = 0
                loop

                    loop
                        set battleCellUniqueID = battleCellUniqueID + 1
                        call DisplayTextToPlayer( GetLocalPlayer(), 0, 0, I2S(battleCellUniqueID ) )
                        //set playerBattleCell[battleCellUniqueID] = PlayerBattleCell.create(battleCellUniqueID, UNIT_CELL_RAW_CODE, i, playerBattleAreaX[i] + (CELL_SIZE * cX), playerBattleAreaY[i] + (CELL_SIZE * cY))

                        set cY = cY + cY
                        exitwhen(cY > PLAYER_MAX_CELLS_ROW)
                    endloop

                    set cY = 0
                    set cX = cX + cX
                    exitwhen(cX > PLAYER_MAX_CELLS_COL)
                endloop

            endif

        set i = i + 1
        endloop

    endfunction

    //...

endlibrary

When this function runs the game freezes a couple of seconds and then displays "93635" and the thread crashes.


How is it even possible when it should loop at maximum 15 times?
PLAYER_MAX_CELLS_ROW * PLAYER_MAX_CELLS_COL = 15

What am I missing? Is it something the library does in the backend?

 

[lolreported]

...and just as I posted this I saw the issue.

set cY = cY + cY and set cX = cX + cX

I love the World Editor text editor with 0 syntax highlight...

 

[Ceday]

I would suggest either use a separate editor for coding, or use old newgen editor.

 

[lolreported]

I would suggest either use a separate editor for coding, or use old newgen editor.

I do have a vJASS add-on for Notepad++, but I rarely use it as formatting becomes an issue. Guess using another world editor with syntax highlight could be a good idea and avoid silly mistakes like these, thanks.

 

[Pyrogasm]

but I rarely use it as formatting becomes an issue

In what way? I changed my np++ settings so I can use tab == 2 spaces and I have no formatting issues (but maybe that's not what bothers you).

 

[lolreported]

In what way? I changed my np++ settings so I can use tab == 2 spaces and I have no formatting issues (but maybe that's not what bothers you).

Encoding is wrong and I haven't figured out what I should use; when I copy and paste I get characters as 仰࿆턀ᛔ in my code.

I'm also for some reason unable to modify the vJass language in Notepad++. Tab are not spaces, which gives me a lot of whitespace in world editor after pasting.

 

[Pyrogasm]

Encoding is wrong and I haven't figured out what I should use; when I copy and paste I get characters as 仰࿆턀ᛔ in my code.

If you paste into a trigger with text you get this encoding. If you paste into a blank trigger it comes out correct. I delete the whole trigger and paste, no problems.

I'm also for some reason unable to modify the vJass language in Notepad++. Tab are not spaces, which gives me a lot of whitespace in world editor after pasting.

I changed this in the main np++ format settings, not in vJASS language settings. Google it if you can’t find it.