[Trigger] Is this spell efficient?

[Jay the Editor]

Nature Shield

• NS effect
  • Events
    • Unit - A unit Is attacked
  • Conditions
    • ((Triggering unit) has buff Nature Shield ) Equal to True
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Random integer number between 1 and 100) Less than or equal to (10 + (5 x (Level of Nature Shield for (Triggering unit))))
      • Then - Actions
        • Set NS_point = (Position of (Attacking unit))
        • Unit - Create 1 dummy unit (instant spell) for (Owner of (Triggering unit)) at NS_point facing Default building facing degrees
        • Set NS_dummy = (Last created unit)
        • Unit - Add Nature Shield_dummy to NS_dummy
        • Unit - Set level of Nature Shield_dummy for NS_dummy to (Level of Nature Shield for (Triggering unit))
        • Unit - Order NS_dummy to Night Elf Keeper Of The Grove - Entangling Roots (Attacking unit)
        • Custom script: call RemoveLocation (udg_NS_point)
      • Else - Actions

I've made this spell for my map but I'm not sure whether this will cause any bug or lag when many units have this spell functioning.

 

[mckill2009]

attacked event then creating units as the action causes lag, but not this coz it's passive...
to be more efficient, put level of nature shield in an integer variable, and Owner of (Triggering unit)) >>> GetTriggerPlayer()
make more conditions as well, such as the attacking is not structure, not flying, not invulnerable, etc...

 

[Jay the Editor]

put level of nature shield in an integer variable

If I store it into a variable during the attack, will it be more smooth?

GetTriggerPlayer()

Is this a custom script? If it is, then how to apply it?
'cause I rarely use custom script; only use in clearing leaks.

Your help is deeply appreciated.

 

[mckill2009]

if you're calling an action 2 or more, you should put it in a variable...yes it will be faster, thus smooth...
GetTriggerPlayer() is the same as TriggeringPlayer...

 

[Jay the Editor]

GetTriggerPlayer() is the same as TriggeringPlayer...

Oh I see. Thanks mckill2009.