[Trigger] Is taken damage from an attack and triggered evasion.

[Marsal]

Question one:
A few days ago I've found a very good system by Weep. I thought it's just an is unit already attacked detection system so I can easily make next attack spells. Yesterday I've found out that it detects ALL damage taken. So it bugs the map's next attack spells. I can't find any system that detects if a unit is taken damage from a single attack and not from a spell or dot or aura.
Could someone show me one that is GUI friendly?

Question two:
As I know the war3 evasion isn't so accurate. If I write 3.75% evasion it will be 5% for war3. If I write 12.1% it will be 10% and so on. How can I trigger an evasion that will really work like the war3 one so it won't disable non-combat consumables?

Question three:
How can I disable the resource sending in allies window?

 

[gorillabull]

1. For the damage detection system you could use just a different unit for each damage type, for example:
A unit begins casting an ability
set a variable to "Target Unit of Ability Being Cast"
then you have another trigger which uses "variable set for target unit Takes Damage"
as an event
a unit is attacked
set another variable equal to the attacked unit
variable set for attacked unit takes damage
it is really dependent on what u need this system for; just to display text or to damage a unit

2.The evasion passive is accurate in my opinion but you could use something with random numbers like:
a unit is attacked
attacked unit belongs to a player
set a variable to a random number between 1 and something <= the higher this is the less likely it is to happen so if its random number between 1 and 5 there will be a 20% chance, if its a random number 1 and 10 there will be a 10% chance, if its a random number between 1 and 20 there will be a 5% change Just divide 1 by a number and move the point two units to the right
then another condition
if variable equal to a specific number (like 2 ) order attacking unit to stop
but i still think you should use normal wc3 evasion

3. to disable trading just go to ally priorities in scenario tab and set ally priority for all players to NONE

 

[Marsal]

1. For the damage detection system you could use just a different unit for each damage type, for example:
A unit begins casting an ability
set a variable to "Target Unit of Ability Being Cast"
then you have another trigger which uses "variable set for target unit Takes Damage"
as an event
a unit is attacked
set another variable equal to the attacked unit
variable set for attacked unit takes damage
it is really dependent on what u need this system for; just to display text or to damage a unit

2.The evasion passive is accurate in my opinion but you could use something with random numbers like:
a unit is attacked
attacked unit belongs to a player
set a variable to a random number between 1 and something <= the higher this is the less likely it is to happen so if its random number between 1 and 5 there will be a 20% chance, if its a random number 1 and 10 there will be a 10% chance, if its a random number between 1 and 20 there will be a 5% change Just divide 1 by a number and move the point two units to the right
then another condition
if variable equal to a specific number (like 2 ) order attacking unit to stop
but i still think you should use normal wc3 evasion

3. to disable trading just go to ally priorities in scenario tab and set ally priority for all players to NONE

1. Erm, what? I can't really understand that. And the system is for detecting if a unit already made the attack.
2. This is not a solution.... The war3 critical strike only support values of the multiples of 5 given. So no matter if you write 4% it will be 5. As I know it's the same at the evasion. So no, it isn't accurate.
3. Thanks.

 

[Magtheridon96]

Use Bribe's DamageEngine.
Create a trigger with the event DamageEvent becomes equal to 1.00
Check if DamageEventType is equal to 0.
If it is, it was an attack.

 

[Marsal]

Oh, I thought it's just a damage detection system too. Thanks.
Also, is it able to detect if a unit(archer) just fired an arrow but no one got hit yet?

 

[Magtheridon96]

Nope :/

 

[Marsal]

That's a pity :/
Anyway, such a useful system.
edit:
FUCK YEAH it's not working....
It still triggers when it's not an attack just a spell damage...

 

[Magtheridon96]

You're going to have to consult Bribe on that one

It will only differentiate between attacks and spell damage if all the damage dealt by your spells is triggered.

If you're using JNGP for some odd reason, this is a quickfix:

function HookDamage takes unit source, unit target, real amount, boolean b1, boolean b2, attacktype at, damagetype dt, weapontype wt returns boolean
    set udg_DamageEventType = 1
endfunction

hook UnitDamageTarget HookDamage

I have no idea how he handles spell-damage checks.

 

[Marsal]

I'm using JNGP. I don't really know how to use that "quickfix"

 

[Bribe]

Maker sure you have JassHelper 0.A.2.B (http://www.wc3c.net/showthread.php?t=88142). Make a new trigger, convert to custom text, replace the contents with this:

function DamageEngine_HookSpell takes unit source, unit target, real amount, boolean b1, boolean b2, attacktype at, damagetype dt, weapontype wt returns boolean
    set udg_DamageEventType = udg_DamageTypeSpell
endfunction

function DamageEngine_HookSpellBJ takes unit c, unit t, real amt, attacktype attype, damagetype dmgtype returns nothing
    set udg_DamageEventType = udg_DamageTypeSpell
endfunction

hook UnitDamageTarget DamageEngine_HookSpell
hook UnitDamageTargetBJ DamageEngine_HookSpellBJ

 

[Marsal]

What´s the deal with this HookSpell thingie? For me it makes no sense :/ Should I replace it with my spell name or something?

As I know I have the latest JASS helper.

Now I can´t checkit because I´m not at home but as soon I can I´ll inform you.

 

[overcold_ice]

just copy it, no edits needed . .

it will run when you call UnitDamageTarget and UnitDamageTargetBJ . . .
and it makes sense ~_~

 

[Marsal]

just copy it, no edits needed . .

it will run when you call UnitDamageTarget and UnitDamageTargetBJ . . .
and it makes sense ~_~

Ty.
I guess it is, just not for me My JASS knowledge is near zero :/

 

[Bribe]

When you hook a function (it can be a native (purple) or BJ (red)), the function that you point to (in my case, DamageEngine_HookSpell and DamageEngine_HookBJ) will run before the native/BJ is called.

The intended use for DamageEventType is to set the damage type right before dealing triggered damage. So by using hooks, the hooks will do it for you automatically without you having to go in and change all your triggers.

The only downside is that object-editor damage from spells will count as physical damage. So you have to trigger all the spell damage.

 

[Marsal]

Well that´s not a problem since the object editor spells are cast by dummies and until the dummies don´t have the buff nothing happens. Now I´m just using this system to properly trigger next attack spells. However, this might be a downside when I make the rest of the systems ofthe map.

Edit:
When I add it, I get these errors.

 

[Bribe]

That's what happens when Macs don't allow JNGP to compile (using a Mac here at work).

Do this instead:

function DamageEngine_HookSpell takes unit source, unit target, real amount, boolean b1, boolean b2, attacktype at, damagetype dt, weapontype wt returns nothing
    set udg_DamageEventType = udg_DamageTypeSpell
endfunction

function DamageEngine_HookSpellBJ takes unit c, unit t, real amt, attacktype attype, damagetype dmgtype returns nothing
    set udg_DamageEventType = udg_DamageTypeSpell
endfunction

hook UnitDamageTarget DamageEngine_HookSpell
hook UnitDamageTargetBJ DamageEngine_HookSpellBJ

 

[Marsal]

Now just this error :/

Missing return is fixed.

 

[Bribe]

This would fix that problem:

function DamageEngine_HookSpell takes unit source, widget target, real amount, boolean b1, boolean b2, attacktype at, damagetype dt, weapontype wt returns nothing
    set udg_DamageEventType = udg_DamageTypeSpell
endfunction

function DamageEngine_HookSpellBJ takes unit c, unit t, real amt, attacktype attype, damagetype dmgtype returns nothing
    set udg_DamageEventType = udg_DamageTypeSpell
endfunction

hook UnitDamageTarget DamageEngine_HookSpell
hook UnitDamageTargetBJ DamageEngine_HookSpellBJ

 

[Marsal]

Zaaaaaa, thanks.