[INQUIRY] CreateNUnitsAtLoc

[sniper_zero]

Is it alright to use this? Or should I just stick with looping CreateUnit? And is there a list of good and bad BJs out there?

 

[Xonok]

Is it alright to use this? Or should I just stick with looping CreateUnit? And is there a list of good and bad BJs out there?

CreateNUnitsAtLocBJ is considered bad, because:
1. It puts the created units in a group and also saves the last created unit
2. It uses a location

It basically is a looping CreateUnit, except that it has some more stuff in it that often isn't needed.

 

[Maker]

Once you will learn more jass, you will learn to detect which are good and which are bad, so such a list is not necessary.

 

[sniper_zero]

So I suppose ctrl + clicking BJs is the only way to know if they're good or bad?

 

[Maker]

I can't remember what that does. I just find the function in the function list in JNGP.

 

[sniper_zero]

Ctrl + clicking a function shows you the parameters they take and what other functions they call. It's like looking at them through the function list, only you don't have to search for them.

 

[Almia]

This is bad. If you use this, there's no way you can retrieve the n - 1 units created. Perhaps, with a Unit Indexer

 

[sniper_zero]

What's bad if I use what? CreateNUnitsAtLoc? Or looping CreateUnit?

 

[Almia]

BJs. Some BJs are good, but most of them are bad.

 

[sniper_zero]

I don't suppose the BJs involving getting a random unit from a unit group are good as well?

 

[Dr Super Good]

CreateNUnitsAtLoc is bad because it creates the units at the same location. The result is a huge amount of strain on the game engine as it struggles to displace multiple units, even to the extent that frames have to be dropped.

CreateUnit should always be used when 1 unit is needed as it is the fastest.
If multiple units are needed you should create them throughout a rect, either randomly or in a grid to avoid excess displacement load.

WC3 can crash when trying to displace units near the edge of the map.

 

[sniper_zero]

Is there a function that lets you create them throughout rects? Or is that done with timers or loops?

 

[Dr Super Good]

No timers involved, just loops.

 

[sniper_zero]

Got it, thanks.

 

[Magtheridon96]

Just don't use any BJs except for TriggerRegisterAnyUnitEventBJ and maybe IMaxBJ, IAbsBJ and the other variants. ModuloInteger is fine too, but an alternative is simply a - a/b*b.

Also,

http://www.hiveworkshop.com/forums/jass-class-702/read-me-what-jass-class-239098/