Infernal Cyclone v. 1.3.2.0

[Moderator]

Infernal Cyclone v. 1.3.0.0 | Reviewed by Maker | 26th October 2013 [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" Concept[/COLOR]] The spell is quite creative, fun to cast and good looking Triggers[/COLOR]] Good configuration options No leaks and MUI Objects[/COLOR]] No unnecessary objects There is no follow through time, casting animation looks bad There ability uses "spell, channel" animation, but the hero does not have that animation Effects[/COLOR]] The effect looks great and the movement of the fire is well done Rating[/COLOR]] CONCEPT TRIGGERS OBJECTS EFFECTS RATING STATUS APPROVED Links[/COLOR]] Jass Proper Application Guide [COLOR="gray"

[/TD]

Old reviews Infernal Cyclone v. 1.2.0.0 | Reviewed by Maker | 23th Oct 2013 [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" [COLOR="gray" Concept[/COLOR]] The spell is quite creative, fun to cast and good looking Triggers[/COLOR]] Good configuration options No leaks and MUI The loop should not call the preload function Your initialization trigger has a leftover debug message You can use TriggerRegisterAnyUnitEventBJ instead of writing the contents of that function yourself. Unless you hate red colour with a passion Instead of a trigger, create a timer for preloading. Destroy the timer in the preload function Objects[/COLOR]] No unnecessary objects Set the learned icon position to [0,2] The learn tooltip could list the stats like standard Blizzard abilities do There is no follow through time, casting animation looks bad Effects[/COLOR]] The effect looks great and the movement of the fire is well done Rating[/COLOR]] CONCEPT TRIGGERS OBJECTS EFFECTS RATING STATUS NEEDS FIX Links[/COLOR]] Jass Proper Application Guide [COLOR="gray"

Old reviews

[/TD]

 

[chobibo]

Why are you using the ConditionalTriggerExecute function? The spell looks okay.

 

[T. D. W.]

Because if not, the KB3D won't work, it uses AddTriggerCondition remember?
Any way, can you please download the spell and see the effects and give a rate :3?

 

[Malhorne]

    local location L = GetSpellTargetLoc()
    local real x = GetLocationX(L)
    local real y = GetLocationY(L)

->

local real x = GetSpellTargetX()
local real y = GetSpellTargetY()

Instanciate locals only if the condition results true

 

[chobibo]

AddTriggerCondition remember?

I honestly don't, the code is too pro for me to read lol. Anyway, you can replace that with TriggerEvaluate, assuming your only using a triggercondition.

 

[Malhorne]

You can use TriggerEvaluate dude
Because if we see the code :

function ConditionalTriggerExecute takes trigger trig returns nothing
    if TriggerEvaluate(trig) then
        call TriggerExecute(trig)
    endif
endfunction

EDIT : I might be wrong anyway ^^'

 

[chobibo]

I might be wrong anyway ^^'

Blasphemer...

I'm never wrong anyway ^^'

 

[T. D. W.]

Update: 1.0.1.0

Changelogs Release Trigger Optimization

 

[chobibo]

What was optimized?

 

[T. D. W.]

Trigger Excecute and and GetSpellTargetLoc, oh sorry, i forgot to change the script here at hive... in a moment..

 

[Malhorne]

Blasphemer...

Yes you're right a wrong side of my human side took part of the god body during 2s : the time to write the edit D:

Put the local initialization in the if block.

1 - Declare locals
2 - If Block
3 - Initialize locals.

Otherwise each time a spell is fired the event declare those local and allocate....

 

[T. D. W.]

okay, updated again

 

[Malhorne]

Put the

set U = null

in the if block

 

[T. D. W.]

Updated, and with a bug fix...

 

[chobibo]

Dude, where is the configuration block for the spell, I think you forgot that.

 

[BPower]

May I recommend
http://www.hiveworkshop.com/forums/jass-resources-412/snippet-spelleffectevent-187193/

I like the effect and the spell idea.
The thing is five simultaneous casts drop FPS from 60 down to 15 (At leat on my PC). Consider efficiency on further updates, aswell.

 

[Malhorne]

SpellEffectEvent is vJASS...

 

[T. D. W.]

@chobibo, no i didn't it's the initial trigger in the first post

@hodenhelm, like malhorne said, this snippet is vJASS, the spell is and may rest JASS
Thanks, and the fps drop is common with my spells, it's not bad coding, it is HUGE eye-candy effects
so reducing that fps drop will eventually remove the eye-candyness of the spell (the thing i like most in spells)

 

[chobibo]

Oh, I forgot you didn't comply with the JESP manifesto. Sorry old habits.

 

[T. D. W.]

What is that JESP manifesto?

 

[chobibo]

Outdated standard for jass spells.

 

[T. D. W.]

Mmm, chobibo, banned users can still recieve VMs and PMs, so pleade can you at least enable one of them so i don't have to go through a thread to talk to you?

 

[Maker]

No need to null the local trigger, no need to not use the bj to register the event, check out JPAG

 

[nhocklanhox6]

Add
set udg_KB3D_DamageType = DAMAGE_TYPE_MAGIC
set udg_KB3D_AttackType = ATTACK_TYPE_MAGIC
set udg_KB3D_Fx_Attach = "origin"

on your configuration

this

loop
        exitwhen index == bj_MAX_PLAYER_SLOTS
        call TriggerRegisterPlayerUnitEvent(T, Player(index), EVENT_PLAYER_UNIT_SPELL_EFFECT, null)
        set index = index + 1
    endloop

instead of this

loop
        call TriggerRegisterPlayerUnitEvent(T, Player(index), EVENT_PLAYER_UNIT_SPELL_EFFECT, null)
        set index = index + 1
        exitwhen index == bj_MAX_PLAYER_SLOTS
    endloop

You forgot this line IC_Cast
call ConditionalTriggerExecute( udg_KB3D_Registration )
=>
You know that, i don't need to correct it.

Don't local varriable too much, optimized IC_Loop

this:

Click

 function IC_Loop takes nothing returns nothing
    local real T = 0
    local integer i = 1
    local unit U
    local unit U1
    local real x
    local real y
    local integer ix = 1
    local integer level
    loop
        exitwhen i > udg_IC_Counter
        if LoadBoolean(udg_IC_HA, i, 4) then
        set T = LoadReal(udg_IC_HA, i, 1) - 0.031250000
        call SaveReal(udg_IC_HA, i, 1, T)
        if T <= 0 then
            if LoadBoolean(udg_IC_HA, i, -1) then
                set level = LoadInteger(udg_IC_HA, i, 0)
                set x = LoadReal(udg_IC_HA, i, 2)
                set y = LoadReal(udg_IC_HA, i, 3)
                set U1 = LoadUnitHandle(udg_IC_HA, i, 5)
                set U = CreateUnit(GetOwningPlayer(U1), udg_IC_Dummy, x, y, 0)
                set udg_KB3D_AllowOutSiding = true
                set udg_KB3D_Angle = 0
                set udg_KB3D_AoE = udg_IC_AoE[level]
                set udg_KB3D_AoEEndDamage = udg_IC_EndDamage[level]
                set udg_KB3D_DamageType = DAMAGE_TYPE_MAGIC
                set udg_KB3D_AttackType = ATTACK_TYPE_MAGIC
                set udg_KB3D_Damager = U1
                set udg_KB3D_DestroyTree = true
                set udg_KB3D_AoEKB = true
                set udg_KB3D_Range = 1
                set udg_KB3D_Speed = 1/(udg_IC_Delay[level])
                set udg_KB3D_Unit = U
                set udg_KB3D_UnpathableStop = false
                set udg_KB3D_Zoffset = 0
                set udg_KB3D_KillatTime = udg_IC_Delay[level]
                call TriggerEvaluate( udg_KB3D_Registration )
                //
                set U = CreateUnit(GetOwningPlayer(U1), udg_IC_Dummy, x, y, GetRandomReal(0,360))
                call SaveEffectHandle(udg_IC_HA, i, 2, AddSpecialEffectTarget(udg_IC_MissileFx, U, "origin"))
                call SaveReal(udg_IC_HA, i, 1, udg_IC_Delay[level])
                call SaveReal(udg_IC_HA, i, 0, udg_IC_Delay[level])
                call SaveReal(udg_IC_HA, i, 6, x)
                call SaveReal(udg_IC_HA, i, 7, y)
                call SavePlayerHandle(udg_IC_HA, i, 8, GetOwningPlayer(U1))
                call SaveInteger(udg_IC_HA, i, 3, level)
                call SaveBoolean(udg_IC_HA, i, -1, false)
                call SetUnitFlyHeight(U, udg_IC_Zoffset[level], 0)
                call SetUnitFlyHeight(U, 0, udg_IC_Zoffset[level]/(udg_IC_Delay[level]))
                call SetUnitScale(U, 2, 0, 0)
                call UnitApplyTimedLife(U, 'BTLF', udg_IC_Delay[level])
                call RemoveSavedHandle(udg_IC_HA, i, 5)
            else
                set level = LoadInteger(udg_IC_HA, i, 3)
                set x = LoadReal(udg_IC_HA, i, 6)
                set y = LoadReal(udg_IC_HA, i, 7)
                call SaveBoolean(udg_IC_HA, i, 4, false)
                call DestroyEffect(LoadEffectHandle(udg_IC_HA, i, 2))
                set U = CreateUnit(Player(15), udg_IC_Dummy, x, y, 0)
                call SetUnitScale(U, udg_IC_AoE[level]*0.008, 0, 0)
                call DestroyEffect(AddSpecialEffectTarget(udg_IC_Fx1, U, "origin"))
                call KillUnit(U)
                //Boulders
                loop
                    exitwhen ix == udg_IC_Shards[level]
                    set udg_KB3D_Angle = GetRandomReal(0,360)
                    set U = CreateUnit(LoadPlayerHandle(udg_IC_HA, i, 8), udg_IC_Dummy, x, y, udg_KB3D_Angle)
                    set udg_KB3D_AllowOutSiding = true
                    set udg_KB3D_AoE = udg_IC_DAoE[level]
                    set udg_KB3D_AoEEndDamage = udg_IC_SpreadDamage[level]
                    set udg_KB3D_DamageType = DAMAGE_TYPE_MAGIC
                    set udg_KB3D_AttackType = ATTACK_TYPE_MAGIC
                    set udg_KB3D_Damager = U
                    set udg_KB3D_TrailFx = udg_IC_Fx2
                    set udg_KB3D_Fx_Attach = "origin"
                    set udg_KB3D_DestroyTree = true
                    set udg_KB3D_Range = GetRandomReal(udg_IC_XAoE[level]/4, udg_IC_XAoE[level])
                    set udg_KB3D_Speed = 450
                    set udg_KB3D_Unit = U
                    set udg_KB3D_UnpathableStop = false
                    set udg_KB3D_Zoffset = udg_IC_Zoffset[level]/1.5
                    set udg_KB3D_EndFx = udg_IC_Fx3
                    call TriggerEvaluate( udg_KB3D_Registration )
                    call UnitApplyTimedLife(U, 'BTLF', udg_KB3D_Time)
                    set ix = ix + 1
                endloop
                call FlushChildHashtable(udg_IC_HA, i)
                set udg_IC_Instances = udg_IC_Instances - 1
                if udg_IC_Instances == 0 then
                    call PauseTimer(udg_IC_Timer)
                    set udg_IC_Counter = 0
                    //call FlushParentHashtable(udg_IC_HA)
                endif
            endif
        endif
        endif
        set i = i + 1
    endloop
    set U = null
    set U1 = null
endfunction

instead of this

Click

 function IC_Loop takes nothing returns nothing
    local real T = 0
    local integer i = 1
    local unit U
    local unit U1
    local unit U2
    local unit u1
    local real x
    local real y
    local integer ix = 1
    local integer level
    loop
        exitwhen i > udg_IC_Counter
        if LoadBoolean(udg_IC_HA, i, 4) then
        set T = LoadReal(udg_IC_HA, i, 1) - 0.031250000
        call SaveReal(udg_IC_HA, i, 1, T)
        if T <= 0 then
            if LoadBoolean(udg_IC_HA, i, -1) then
                set level = LoadInteger(udg_IC_HA, i, 0)
                set x = LoadReal(udg_IC_HA, i, 2)
                set y = LoadReal(udg_IC_HA, i, 3)
                set U1 = LoadUnitHandle(udg_IC_HA, i, 5)
                set U = CreateUnit(GetOwningPlayer(U1), udg_IC_Dummy, x, y, 0)
                set udg_KB3D_AllowOutSiding = true
                set udg_KB3D_Angle = 0
                set udg_KB3D_AoE = udg_IC_AoE[level]
                set udg_KB3D_AoEEndDamage = udg_IC_EndDamage[level]
                set udg_KB3D_DamageType = DAMAGE_TYPE_MAGIC
                set udg_KB3D_AttackType = ATTACK_TYPE_MAGIC
                set udg_KB3D_Damager = U1
                set udg_KB3D_DestroyTree = true
                set udg_KB3D_AoEKB = true
                set udg_KB3D_Range = 1
                set udg_KB3D_Speed = 1/(udg_IC_Delay[level])
                set udg_KB3D_Unit = U
                set udg_KB3D_UnpathableStop = false
                set udg_KB3D_Zoffset = 0
                set udg_KB3D_KillatTime = udg_IC_Delay[level]
                call TriggerEvaluate( udg_KB3D_Registration )
                set U = null
                //
                set U2 = CreateUnit(GetOwningPlayer(U1), udg_IC_Dummy, x, y, GetRandomReal(0,360))
                call SaveEffectHandle(udg_IC_HA, i, 2, AddSpecialEffectTarget(udg_IC_MissileFx, U2, "origin"))
                call SaveReal(udg_IC_HA, i, 1, udg_IC_Delay[level])
                call SaveReal(udg_IC_HA, i, 0, udg_IC_Delay[level])
                call SaveReal(udg_IC_HA, i, 6, x)
                call SaveReal(udg_IC_HA, i, 7, y)
                call SavePlayerHandle(udg_IC_HA, i, 8, GetOwningPlayer(U1))
                call SaveInteger(udg_IC_HA, i, 3, level)
                call SaveBoolean(udg_IC_HA, i, -1, false)
                call SetUnitFlyHeight(U2, udg_IC_Zoffset[level], 0)
                call SetUnitFlyHeight(U2, 0, udg_IC_Zoffset[level]/(udg_IC_Delay[level]))
                call SetUnitScale(U2, 2, 0, 0)
                call UnitApplyTimedLife(U2, 'BTLF', udg_IC_Delay[level])
                set U1 = null
                set U2 = null
                call RemoveSavedHandle(udg_IC_HA, i, 5)
            else
                set level = LoadInteger(udg_IC_HA, i, 3)
                set x = LoadReal(udg_IC_HA, i, 6)
                set y = LoadReal(udg_IC_HA, i, 7)
                call SaveBoolean(udg_IC_HA, i, 4, false)
                call DestroyEffect(LoadEffectHandle(udg_IC_HA, i, 2))
                set u1 = CreateUnit(Player(15), udg_IC_Dummy, x, y, 0)
                call SetUnitScale(u1, udg_IC_AoE[level]*0.008, 0, 0)
                call DestroyEffect(AddSpecialEffectTarget(udg_IC_Fx1, u1, "origin"))
                call KillUnit(u1)
                set u1 = null
                //Boulders
                loop
                    exitwhen ix == udg_IC_Shards[level]
                    set udg_KB3D_Angle = GetRandomReal(0,360)
                    set u1 = CreateUnit(LoadPlayerHandle(udg_IC_HA, i, 8), udg_IC_Dummy, x, y, udg_KB3D_Angle)
                    set udg_KB3D_AllowOutSiding = true
                    set udg_KB3D_AoE = udg_IC_DAoE[level]
                    set udg_KB3D_AoEEndDamage = udg_IC_SpreadDamage[level]
                    set udg_KB3D_DamageType = DAMAGE_TYPE_MAGIC
                    set udg_KB3D_AttackType = ATTACK_TYPE_MAGIC
                    set udg_KB3D_Damager = u1
                    set udg_KB3D_TrailFx = udg_IC_Fx2
                    set udg_KB3D_Fx_Attach = "origin"
                    set udg_KB3D_DestroyTree = true
                    set udg_KB3D_Range = GetRandomReal(udg_IC_XAoE[level]/4, udg_IC_XAoE[level])
                    set udg_KB3D_Speed = 450
                    set udg_KB3D_Unit = u1
                    set udg_KB3D_UnpathableStop = false
                    set udg_KB3D_Zoffset = udg_IC_Zoffset[level]/1.5
                    set udg_KB3D_EndFx = udg_IC_Fx3
                    call TriggerEvaluate( udg_KB3D_Registration )
                    call UnitApplyTimedLife(u1, 'BTLF', udg_KB3D_Time)
                    set ix = ix + 1
                endloop
                call FlushChildHashtable(udg_IC_HA, i)
                set udg_IC_Instances = udg_IC_Instances - 1
                if udg_IC_Instances == 0 then
                    call PauseTimer(udg_IC_Timer)
                    set udg_IC_Counter = 0
                    //call FlushParentHashtable(udg_IC_HA)
                endif
            endif
        endif
        endif
        set i = i + 1
    endloop
    set U = null
    set U1 = null
    set U2 = null
    set u1 = null
endfunction

on IC_Cast
GetTriggerPlayer()
Instead
GetOwningPlayer(U)

Remove local unit u2

this

Click

 loop
            exitwhen i == udg_IC_Flames[level]
            //Register the KB3D
            set u1 = CreateUnit(GetTriggerPlayer(), udg_IC_Dummy, x, y, 0)
            set udg_KB3D_AllowOutSiding = true
            set udg_KB3D_Angle = 360/udg_IC_Flames[level] * i
            set udg_KB3D_AoE = udg_IC_DAoE[level]
            set udg_KB3D_Arc = udg_IC_Delay[level]*4
            set udg_KB3D_AoEDamage = udg_IC_DPS[level]
            set udg_KB3D_DamageType = DAMAGE_TYPE_MAGIC
            set udg_KB3D_AttackType = ATTACK_TYPE_MAGIC
            set udg_KB3D_Damager = U
            set udg_KB3D_DestroyTree = true
            set udg_KB3D_Range = udg_IC_Delay[level]*udg_IC_AoE[level]*2
            set udg_KB3D_Speed = udg_IC_AoE[level]
            set udg_KB3D_TrailFx = udg_IC_MissileFx
            set udg_KB3D_Fx_Attach = "origin"
            set udg_KB3D_Unit = u1
            set udg_KB3D_UnpathableStop = false
            set udg_KB3D_Zoffset = udg_IC_Zoffset[level]
            set udg_KB3D_KillatTime = udg_IC_Delay[level]
            call ConditionalTriggerExecute( udg_KB3D_Registration )
            set i = i + 1
        endloop

instead

click

 loop
            exitwhen i == udg_IC_Flames[level]
            //Register the KB3D
            set u2 = CreateUnit(GetOwningPlayer(U), udg_IC_Dummy, x, y, 0)
            set udg_KB3D_AllowOutSiding = true
            set udg_KB3D_Angle = 360/udg_IC_Flames[level] * i
            set udg_KB3D_AoE = udg_IC_DAoE[level]
            set udg_KB3D_Arc = udg_IC_Delay[level]*4
            set udg_KB3D_AoEDamage = udg_IC_DPS[level]
            set udg_KB3D_DamageType = DAMAGE_TYPE_MAGIC
            set udg_KB3D_AttackType = ATTACK_TYPE_MAGIC
            set udg_KB3D_Damager = U
            set udg_KB3D_DestroyTree = true
            set udg_KB3D_Range = udg_IC_Delay[level]*udg_IC_AoE[level]*2
            set udg_KB3D_Speed = udg_IC_AoE[level]
            set udg_KB3D_TrailFx = udg_IC_MissileFx
            set udg_KB3D_Fx_Attach = "origin"
            set udg_KB3D_Unit = u2
            set udg_KB3D_UnpathableStop = false
            set udg_KB3D_Zoffset = udg_IC_Zoffset[level]
            set udg_KB3D_KillatTime = udg_IC_Delay[level]
            call ConditionalTriggerExecute( udg_KB3D_Registration )
            set i = i + 1
            set u2 = null
        endloop

and then: null U and u1 in the end of function ....

That it's, 4/5 for great spell (Eye candy a little - When inferal fall, it look not cool too much :|).

 

[T. D. W.]

Wow, okay, On my way to fix them

 

[T. D. W.]

Update

Changelogs Release Trigger Optimization Trigger Optimization Bug Fix Attack Type and Damage Type are now configurable Many Trigger Optimization

 

[Maker]

I would use the bj for registering the event. It doesn't make any difference either way.

nhocklanhox6, to me it doesn't make sense to check the exitwhen condition before doing any actions. The actions are going to be run at least once.

 

[chobibo]

loop
        exitwhen index == bj_MAX_PLAYER_SLOTS
        call TriggerRegisterPlayerUnitEvent(T, Player(index), EVENT_PLAYER_UNIT_SPELL_EFFECT, null)
        set index = index + 1
    endloop

This is the same as this:

loop
        call TriggerRegisterPlayerUnitEvent(T, Player(index), EVENT_PLAYER_UNIT_SPELL_EFFECT, null)
        set index = index + 1
        exitwhen index == bj_MAX_PLAYER_SLOTS
    endloop

But, like Maker said, I'd use the TriggerRegisterAnyUnitEventBJ.

 

[nhocklanhox6]

loop
        exitwhen index == bj_MAX_PLAYER_SLOTS
        call TriggerRegisterPlayerUnitEvent(T, Player(index), EVENT_PLAYER_UNIT_SPELL_EFFECT, null)
        set index = index + 1
    endloop

Okay =.=!. Just a habit, don't care about that ..

 

[FUJI]

Nice and Excellent spell and you almost does use KB3D in the code xD, I'll rate it 4/5 and +Rep for nice system and spell.

Also a suggestion: Make the KB3D values to be configurable in the configuration trigger because some users want to change the speed, special effect, attachment fx and some booleans.

 

[T. D. W.]

thanks for the feedback,

all the KB3D configurations are configurable man, only one isn't : set udg_KB3D_Speed = 450 for the shards at the end
other values like unpathable stop and so can't be configured or else they will ruin the spell
And for the Love of HIVE, "origin" attach isn't configurable for the simple reason that the effects are attached on a dummy unit using the dummy model file...... it can't be changed to head or something!

 

[FUJI]

Oh, I see thanks for pointing it out ^^.

 

[T. D. W.]

you're welcome, and i forgot to mention something, all the values are configurable with only one: IC_Delay, everything turns around this, even that changing that value will ruin the Aspect of the Cyclone, this is how all the values are configured

 

[Maker]

And for the Love of HIVE, "origin" attach isn't configurable for the simple reason that the effects are attached on a dummy unit using the dummy model file...... it can't be changed to head or something!

The dummy has "origin", "chest" and "overhead" attachment points.

 

[T. D. W.]

The dummy has "origin", "chest" and "overhead" attachment points.

yes, but it doesn't matter -.-"
it's a dummy to attach the effect on it :/

EDIT: oh just realized my mistake in the first sentence, here it is now:

And for the Love of HIVE, "origin" attach isn't configurable for the simple reason that the effects are attached on a dummy unit using the dummy model file...... it doesn't matter if it is changed to head or something!

 

[FUJI]

The spell cause massive lag if casts on clusters of trees

 

[T. D. W.]

I think that's because 18 KBs are triggering the same AoE to destroy the Same trees... I'll check on that..

 

[FUJI]

Anyway, I have that same issue in my spell xD, but seems it's not your fault .

 

[T. D. W.]

I think i have a solution to reduce the lag, i will add it to KB3D v. 1.6.0 , the final version

 

[chobibo]

What spell jake?

 

[T. D. W.]

Update

Changelogs Release Trigger Optimization Trigger Optimization Bug Fix Attack Type and Damage Type are now configurable Many Trigger Optimization Small Changes in the Spell's configs Updated to KB3D v. 1.6.0 with iKB

 

[FUJI]

What spell jake?

Secret xD.

 

[Malhorne]

Lol.

 

[chobibo]

Hey you! I'm gonna get you for this! *grumble*

 

[T. D. W.]

Updated to v. 1.2.0.0

 

[Malhorne]

        if LoadBoolean(udg_IC_HA, i, 4) then
        set T = LoadReal(udg_IC_HA, i, 1) - 0.031250000
        call SaveReal(udg_IC_HA, i, 1, T)

Indent please

set U= null
//
set U = CreateUnit(GetOwningPlayer(U1), udg_IC_Dummy, x, y, GetRandomReal(0,360))

Why setting it to null ?

set U = null
//Boulders
loop
    exitwhen ix == udg_IC_Shards[level]
    set udg_KB3D_Angle = GetRandomReal(0,360)
    set U = CreateUnit(LoadPlayerHandle(udg_IC_HA, i, 8), udg_IC_Dummy, x, y, udg_KB3D_Angle)

Again ?

set u1 = null
loop
    exitwhen i == udg_IC_Flames[level]
    //Register the KB3D
    set u1 = CreateUnit(GetTriggerPlayer(), udg_IC_Dummy, x, y, 0)

Again xD ?

if (( GetSpellAbilityId() == udg_IC_Ability ) ) then

->

if GetSpellAbilityId() == udg_IC_Ability then

 

[T. D. W.]

:3
isn't it better to null a variable before seting it again? :3 lol

 

[FUJI]

^ There's no differences if you change the variable even you nulled it but you must null it if you're not using it anymore.

 

[T. D. W.]

okay, next time den xD