[JASS] Inefficient

[DistantHaze]

This code seems needless complex. The trigger just takes every item laying on the ground in the playable map area, and reduces its life at intervals. Is there a more efficient way to do this?

function Every30Seconds_Action02 takes nothing returns nothing
    call SetWidgetLife (GetEnumItem(), (GetWidgetLife (GetEnumItem()) - 20.00))
endfunction

function Every30Seconds_Action01 takes nothing returns nothing
    local rect r = Rect (-7424.000, -11776.000, 7424.000, 11264.000)
    call EnumItemsInRect (r, null, function Every30Seconds_Action02)
    call RemoveRect (r)
    set r = null
endfunction

function InitTrig_Every30Seconds takes nothing returns nothing
    set gg_trg_Every30Seconds = CreateTrigger ()
    call DisableTrigger (gg_trg_Every30Seconds)
    call TriggerRegisterTimerEventPeriodic (gg_trg_Every30Seconds, 30.00)
    call TriggerAddAction (gg_trg_Every30Seconds, function Every30Seconds_Action01)
endfunction

 

[Earth-Fury]

As far as i can see, thats as simplistic as it gets. You could use a timer instead of a trigger using a timed event, but thats pretty much as complicated. You could also use the bj_mapInitialPlayableArea rect instead of creating and destroying one every 30 seconds. (DON'T destroy that rect, of course)

 

[PurplePoot]

call TriggerRegisterTimerEvent(gg_trg_Every30Seconds, 30,true)

 

[DistantHaze]

So which line in

function InitTrig_Every30Seconds takes nothing returns nothing
set gg_trg_Every30Seconds = CreateTrigger ()
call DisableTrigger (gg_trg_Every30Seconds)
call TriggerRegisterTimerEventPeriodic (gg_trg_Every30Seconds, 30.00)
call TriggerAddAction (gg_trg_Every30Seconds, function Every30Seconds_Action01)

would

call TriggerRegisterTimerEvent (gg_trg_Every30Seconds, 30,true)

replace?

 

[PurplePoot]

Replaces the TriggerRegisterTimerEventPeriodic function, which is a BJ