Income System Error.

[ToP-Fouraces]

Hey everyone, i am having an issue with my gold income system and would like some help to fix it. This is the trigger i use to generate income:

• Gold building 1
  • Events
    • Time - Every 2.00 seconds of game time
  • Conditions
  • Actions
    • For each (Integer A) from 1 to 3, do (Actions)
      • Loop - Actions
        • Set Temp_Group = (Units in (Playable map area) matching (((Unit-type of (Matching unit)) Equal to Gold Base) and (((Owner of (Matching unit)) Equal to (Player((Integer A)))) and (((Matching unit) is alive) Equal to True))))
        • Player - Add ((Number of units in Temp_Group) x 10) to (Player((Integer A))) Current gold
        • Custom script: call DestroyGroup(udg_Temp_Group)

When the 'gold building' that generates income is upgraded, i have a new trigger which is:

• Gold building 2
  • Events
    • Time - Every 2.00 seconds of game time
  • Conditions
  • Actions
    • For each (Integer A) from 1 to 3, do (Actions)
      • Loop - Actions
        • Set Temp_Group = (Units in (Playable map area) matching (((Unit-type of (Matching unit)) Equal to Gold Base #2) and (((Owner of (Matching unit)) Equal to (Player((Integer A)))) and (((Matching unit) is alive) Equal to True))))
        • Player - Add ((Number of units in Temp_Group) x 15) to (Player((Integer A))) Current gold
        • Custom script: call DestroyGroup(udg_Temp_Group)

I understand where my problem is going wrong (i think) but i don't know how to fix it so any help would be appreciated.

Also, a secondary question about my income!
How would i display the gold gained through the building as text above (e.g. +10) (that floats up and dissapears after a certain amount of time) like in Troll vs Elves.

Cheers, +REP to everyone that helps.

 

[mckill2009]

why are you destroying group everytime?, just add all of it to one unique group and enumerate it in a looping trigger using ForGroup same as the second trigger, when the unit dies remove it from that group...

about the gold displey, use Floating text, it's easy to implement...

 

[Apheraz Lucent]

What's the problem in general? The gold is not gained, or not calculated properly?

Anyways, here's what you will need for Gold Text faking:

Trigger

• Gold Text Faking
  • Actions
    • Set Deny_Floating = (Position of (Your unit))
    • Floating Text - Create floating text that reads (|cffffcc00+ + ((String(GoldInteger)) + |r)) at Deny_Floating with Z offset 0.00, using font size 10.00, color (100.00%, 100.00%, 100.00%), and 0.00% transparency
    • Set Deny_Floating_Text = (Last created floating text)
    • Floating Text - Change Deny_Floating_Text: Disable permanence
    • Floating Text - Change the lifespan of Deny_Floating_Text to 2.00 seconds
    • Floating Text - Change the fading age of Deny_Floating_Text to 1.00 seconds
    • Floating Text - Set the velocity of Deny_Floating_Text to 80.00 towards 90.00 degrees

 

[ToP-Fouraces]

Thanks so much for that, +REP.

Anyways, the problem is with the group, so when the gold base is upgraded, instead of gaining 15 gold as the trigger shows, it gains 80 gold. Or, if gold earnt is set to 0 in trigger 2, 65 gold is still earnt. Gold earnt is per interval (2 seconds) btw.

 

[Apheraz Lucent]

Check your other triggers - it looks like you got an old copy of that trigger somewhere.

 

[Maker]

You can try Floating text - Create FT above unit instead of creating it at the positon of the unit. It might produce better result. Use which ever you like best.

If you create it at the position of the unit, remove the leak: https://www.hiveworkshop.com/forums/triggers-scripts-269/things-leak-35124/