Ice Temple

[Moderator]

21 Jan 2012
Bribe: I like the changes you made. The code is enormously difficult to read, though, and you have a sound variable which is not private for some reason so I feel like approving it but not "recommending" it yet, per say. Using structs with TimerUtils data attachment will make this much more readable, but it's up to you. Not doing so will not affect this thing's approval.

Approved 3/5.

 

[Magtheridon96]

CosBJ -> Cos
SinBJ -> Sin

The use of those bj globals makes this pretty sloppy. Using locals would be much more readable and much faster (Globals are way too slow)
Also, I recommend adding linebreaks and comments inside the functions for more readability.

And since this is vJass, you should take advantage of structs, else you could make it strictly vanilla Jass so that people using the WE could use it too.

The sound in the globals block should be private.

If you want to stick to using hashtables, I'd recommend implementing Table by Bribe.
It makes working with hashtables a piece of cake.
You'd need multiple Tables though (one for each handle/scalar variable you want to store)

Structs are way better in my opinion. If you're not that familiar with them:
- http://www.hiveworkshop.com/forums/jass-ai-scripts-tutorials-280/structs-dummies-197435/
- http://www.hiveworkshop.com/forums/...ls-280/coding-efficient-vjass-structs-187477/

 

[Final-Burn]

It looks Cool. I like it.
EDIT
I tested it again.
-->[broke="That's Goddamn Amazing! You made all the Models yourself? Dude, this is gold. except Icy, I love it so much. DotA Should Use this. But Dota heroes can kind of run out cant they? Anywho, its a Great Spell. 5/5"]Comment[/broke]<--

 

[Tirlititi]

Thx Final-Burn.

@ Magtheridon96
I said I will be extremely lazy . I'm not against making any update but the ones you suggest are only details.

CosBJ -> Cos
SinBJ -> Sin

Yeah, I'll think of it if I update...

The use of those bj globals makes this pretty sloppy. Using locals would be much more readable and much faster (Globals are way too slow)

I need globals for filters and I wanted to limit the global declaration, but that's true I would better use custom globals with good names. But I ask for prooves about the way-too-slowness of globals.

Also, I recommend adding linebreaks and comments inside the functions for more readability.

I just think it's the contrary : I never comment a function inside it. I only put comments inside a function to comment a line or a group of actions. I find it much more readable.

And since this is vJass, you should take advantage of structs, else you could make it strictly vanilla Jass so that people using the WE could use it too.

The main problem with jass is the global declaration... And I prefer to force someone to get the JNGP than letting him think he can do all with simple WE. I don't want to rewrite the code for using structs but I may eventually do that.

The sound in the globals block should be private.

Why?

If you want to stick to using hashtables, I'd recommend implementing Table by Bribe.
It makes working with hashtables a piece of cake.
You'd need multiple Tables though (one for each handle/scalar variable you want to store)

Again, I think the contrary : I find hashtable's API a lot better than Table's API (putting big integers into [] can only give bad habits ). I usually define more concise functions and use StringHash, but it's even not necessary for such a short scope.

 

[Atideva]

looks great, plz fix to make it approved

 

[Tirlititi]

Updated.

You could focus on making a lot of values like 1.44 or 1.4 configurable to keep your script more dynamic.

Waits are model related so I can't make them configurable. If I use SetUnitTimeScale, the water suddenly turns around faster and it's just wrong.

 

[Blood Raven]

wow... now, thats what i call awzum!
great job matey!

+repz