[General] how can i intercept a lack of orders

[andreasaspenberg]

i have a project where i want 1 unit to transform once it have no orders. how can i accomplish that?

 

[SAUS]

You might have to check periodically until it has no order. I think either null or it is an empty string is used, but I could be completely wrong.

Anyway, check what the order is for the unit when it has no orders and then check periodically for that.

 

[andreasaspenberg]

then i would need the proper trigger for it as all triggers i have tried in that regard have failed to run properly and instead run on any order.

 

[Zwiebelchen]

if GetUnitCurrentOrder(unit) == 0 then

Note: this does not mean that the unit is doing nothing. It just means it has no order.

 

[andreasaspenberg]

that did absolutely nothing.

 

[Arad MNK]

that did absolutely nothing.

Did you change the "Unit" in the Parenthesis to your Unit variable?

 

[andreasaspenberg]

i use no unit variable. i pick all units of a certain type and then check their orders. a unit variable only supports one unit anyway and as such it is useless for what i need as players can have lots of units.

 

[IcemanBo]

Show your trigger.

 

[andreasaspenberg]

why? i am willing to build an entirely new trigger so, why should i show the old one?

 

[IcemanBo]

You say

i pick all units of a certain type and then check their orders

and you say that it doesn't work was wanted, so maybe we can see a mistake if you show us the trigger.

Because as mentioned by Zwiebelchen if current order equals null the unit has no order.

 

[andreasaspenberg]

and i am telling you that i do not care about my current trigger. please tell me how can i build a new one.

 

[IcemanBo]

• (Current order of (Triggering unit)) Equal (Order(<Empty String>))

^This checks if triggering unit has currently no order. You need to adapt this to what you need.

So when you pick units in group then just do the check with PickedUnit.

 

[andreasaspenberg]

that worked partially. the problem i encountered is that after moving a short distance it transforms.(it does not finish its move order.)

 

[IcemanBo]

The unit will have it's move order until it reaches the move-target location. After that it will have no order. Where is the problem now?

 

[andreasaspenberg]

it does not reach its target but transforms after a specific time of moving.

 

[IcemanBo]

Can you post your test map?

 

[andreasaspenberg]

it is not a test map but a nearly finished project. the latest public alpha is here: https://www.hiveworkshop.com/forums/map-development-202/blood-magic-229830/

 

[IcemanBo]

I have absolutly no idea what to test with your map and I'm not willing to try everything around just to create a test scenario.

Create an easy to test scenario where you show that the trigger does not work.

 

[andreasaspenberg]

just try to move a basal golem around.

 

[IcemanBo]

Ya, I moved it around. Nothing happend.

 

[andreasaspenberg]

when i moved it it transformed at random.

 

[IcemanBo]

No test scenario -> no help from me.

 

[Zwiebelchen]

Seriously, if you want to get help, you need to be more cooperative with the guys trying to help you.

Just post the triggers.

 

[andreasaspenberg]

i did not think of that. here it is. Untitled Trigger 001
Events
Time - Every 2.00 seconds of game time
Conditions
Actions
Unit Group - Pick every unit in (Units of type Basal Golem created from blood forge) and do (Actions)
Loop - Actions
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Current order of (Picked unit)) Equal to (Order(<Empty String>))
Then - Actions
Unit - Order (Picked unit) to Night Elf Druid Of The Claw - Bear Form
Unit - Order (Picked unit) to Night Elf Druid Of The Claw - Night Elf Form
Else - Actions
Do nothing

 

[Zwiebelchen]

The above trigger should work properly.

Have you considered that the AI might interfere with that and cast bearform on it's own?

I suggest using https://www.hiveworkshop.com/forums...rials-278/hero-passive-transformation-198482/ instead of a dual-action bearform.

 

[andreasaspenberg]

what AI?

 

[Zwiebelchen]

That AI which controls computer players.

 

[andreasaspenberg]

there is no computer players present.

 

[LordDz]

Tested your map, placed some Basal Golem created from blood forge on the map and hit test.

They do transform when idle. It's just a 2 second delay since your trigger runs every 2 seconds.

Also, you should consider fixing your leaks now, as if you try to fix them when the map is nearly done, it's going to be a big pain to fix all the triggers.

 

[andreasaspenberg]

what leaks? my problem is that the basal golems transforms after 2 seconds wether or not they are idle. i order them to move and after 2 seconds they transform.(preventing them from reaching the destination.)

 

[LordDz]

Leaks:

• Untitled Trigger 001
  • Events
    • Time - Every 2.00 seconds of game time
  • Conditions
  • Actions
    • Unit Group - Pick every unit in (Units of type Basal Golem created from blood forge) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Or - Any (Conditions) are true
              • Conditions
                • (Current order of (Picked unit)) Equal to (Order(smart))
                • (Current order of (Picked unit)) Equal to (Order(attack))
                • (Current order of (Picked unit)) Equal to (Order(move))
                • (Current order of (Picked unit)) Equal to (Order(cloudoffog))
                • (Current order of (Picked unit)) Equal to (Order(charm))
          • Then - Actions
            • Do nothing
          • Else - Actions
            • Unit - Order (Picked unit) to Night Elf Druid Of The Claw - Bear Form
            • Unit - Order (Picked unit) to Night Elf Druid Of The Claw - Night Elf Form

unit group leak.

• construction on site 1
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • And - All (Conditions) are true
          • Conditions
            • (Foundation1 <gen> contains (Casting unit)) Equal to True
            • (Ability being cast) Equal to transform into arbor lodge new
            • (Number of units in (Units in Foundation1 <gen> matching ((Unit-type of (Matching unit)) Equal to Basal Golem created from blood forge))) Equal to 4
      • Then - Actions
        • Unit Group - Pick every unit in (Units in Foundation1 <gen>) and do (Item - Move (Item carried by (Picked unit) in slot 1) to ((Position of (Picked unit)) offset by (-200.00, 0.00)))
        • Unit Group - Pick every unit in (Units in Foundation1 <gen>) and do (Unit - Remove (Picked unit) from the game)
        • Unit - Create 1 Arbor Lodge for (Owner of (Casting unit)) at (Center of Foundation1 <gen>) facing Default building facing degrees
        • Unit Group - Add (Last created unit) to site1
        • Player - Add 250 to (Owner of (Last created unit)) Current lumber
      • Else - Actions
        • Do nothing
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • And - All (Conditions) are true
          • Conditions
            • (Foundation1 <gen> contains (Casting unit)) Equal to True
            • (Ability being cast) Equal to transform into barrracks new
            • (Number of units in (Units in Foundation1 <gen> matching ((Unit-type of (Matching unit)) Equal to Basal Golem created from blood forge))) Equal to 4
      • Then - Actions
        • Unit Group - Pick every unit in (Units in Foundation1 <gen>) and do (Item - Move (Item carried by (Picked unit) in slot 1) to ((Position of (Picked unit)) offset by (-200.00, 0.00)))
        • Unit Group - Pick every unit in (Units in Foundation1 <gen>) and do (Unit - Remove (Picked unit) from the game)
        • Unit - Create 1 Barracks custom for (Owner of (Casting unit)) at (Center of Foundation1 <gen>) facing Default building facing degrees
        • Unit Group - Add (Last created unit) to site1
        • Player - Add 250 to (Owner of (Last created unit)) Current lumber
      • Else - Actions
        • Do nothing
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • And - All (Conditions) are true
          • Conditions
            • (Foundation1 <gen> contains (Casting unit)) Equal to True
            • (Ability being cast) Equal to transform into crypt new
            • (Number of units in (Units in Foundation1 <gen> matching ((Unit-type of (Matching unit)) Equal to Basal Golem created from blood forge))) Equal to 4
      • Then - Actions
        • Unit Group - Pick every unit in (Units in Foundation1 <gen>) and do (Item - Move (Item carried by (Picked unit) in slot 1) to ((Position of (Picked unit)) offset by (-200.00, 0.00)))
        • Unit Group - Pick every unit in (Units in Foundation1 <gen>) and do (Unit - Remove (Picked unit) from the game)
        • Unit - Create 1 Crypt custom for (Owner of (Casting unit)) at (Center of Foundation1 <gen>) facing Default building facing degrees
        • Unit Group - Add (Last created unit) to site1
        • Player - Add 250 to (Owner of (Last created unit)) Current lumber
      • Else - Actions
        • Do nothing
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • And - All (Conditions) are true
          • Conditions
            • (Foundation1 <gen> contains (Casting unit)) Equal to True
            • (Ability being cast) Equal to transform into rune stone new
            • (Number of units in (Units in Foundation1 <gen> matching ((Unit-type of (Matching unit)) Equal to Basal Golem created from blood forge))) Equal to 4
      • Then - Actions
        • Unit Group - Pick every unit in (Units in Foundation1 <gen>) and do (Item - Move (Item carried by (Picked unit) in slot 1) to ((Position of (Picked unit)) offset by (-200.00, 0.00)))
        • Unit Group - Pick every unit in (Units in Foundation1 <gen>) and do (Unit - Remove (Picked unit) from the game)
        • Unit - Create 1 Rune stone for (Owner of (Casting unit)) at (Center of Foundation1 <gen>) facing Default building facing degrees
        • Unit Group - Add (Last created unit) to site1
        • Player - Add 250 to (Owner of (Last created unit)) Current lumber
      • Else - Actions
        • Do nothing
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • And - All (Conditions) are true
          • Conditions
            • (Foundation1 <gen> contains (Casting unit)) Equal to True
            • (Ability being cast) Equal to transform into temple new
            • (Number of units in (Units in Foundation1 <gen> matching ((Unit-type of (Matching unit)) Equal to Basal Golem created from blood forge))) Equal to 4
      • Then - Actions
        • Unit Group - Pick every unit in (Units in Foundation1 <gen>) and do (Item - Move (Item carried by (Picked unit) in slot 1) to ((Position of (Picked unit)) offset by (-200.00, 0.00)))
        • Unit Group - Pick every unit in (Units in Foundation1 <gen>) and do (Unit - Remove (Picked unit) from the game)
        • Unit - Create 1 Temple custom for (Owner of (Casting unit)) at (Center of Foundation1 <gen>) facing Default building facing degrees
        • Unit Group - Add (Last created unit) to site1
        • Player - Add 250 to (Owner of (Last created unit)) Current lumber
      • Else - Actions
        • Do nothing

Point leaks.

Okay, your golems will not transform if you tell them to move twice, just double click.
So after an obelisk uses the transform to golem ability, you have to the golem to move/attack to the same position the obelisk where ordered to move/attack to.

 

[andreasaspenberg]

double clicking to move will get people angry at me so i need the basal golem to move without double clicking. you are welcome to tell me how to fix the leaks but i do not know how.

 

[PublishedShadow]

So here's probably your problem (and i'm not sure if this is true or not). But let's Think of it this way:

A unit is issued a 'move' order to a target point. That 'Move' order has been received by the game - ordering him to MOVE to that point was the order. Actually getting to that point is NOT part the order. Since you are checking for an ORDER every two seconds, if the unit hasn't received a new order by the time it gets to the target point, it transforms regardless of where it is.

What you could do is set a temp point at the position of the order and check to see if he has gotten there or not before transforming.

As for leaks, check here:
https://www.hiveworkshop.com/forums/trigger-gui-editor-tutorials-279/memory-leaks-263410/

 

[andreasaspenberg]

a tutorial is too general. if i am to fix leaks i need knowledge on how to fix that specific leak. your solution would only work with one unit and i have lots of basal golems so, i need something better.

 

[Zwiebelchen]

So here's probably your problem (and i'm not sure if this is true or not). But let's Think of it this way:

A unit is issued a 'move' order to a target point. That 'Move' order has been received by the game - ordering him to MOVE to that point was the order. Actually getting to that point is NOT part the order. Since you are checking for an ORDER every two seconds, if the unit hasn't received a new order by the time it gets to the target point, it transforms regardless of where it is.

What you could do is set a temp point at the position of the order and check to see if he has gotten there or not before transforming.

As for leaks, check here:
https://www.hiveworkshop.com/forums/trigger-gui-editor-tutorials-279/memory-leaks-263410/

This is not true. The unit will keep the "move" (or "smart", depending on what you used) order until it reaches it's destination. The only exception to this is movement as part of the auto-engagement mechanics, which will still be considered as no order, as technically, that unit is acting out of free will.

So if you want your unit not to transform while moving because of auto-engage, you actually need to use the "IsUnitMoving" snippet.

 

[Bribe]

Use the IsUnitMoving resource (link in my sig) and when a unit stops moving do your periodic check to see if it has no order, then stop the check once it starts moving again.

 

[andreasaspenberg]

that is still a single unit script and i have lots of basal golems that is created from the blood forge. i need a solution that works independent of how many units the player controls.

 

[PublishedShadow]

Then you will probably need to add the golems for each player into a unit-group array and then have your trigger cycle through the units within your groups transforming those that meet all of your lack of order conditions.

 

[andreasaspenberg]

that is what i have been trying to do but i did not do it for individual players. i need the proper conditions in order to intercept a lack of orders.

 

[Bribe]

that is still a single unit script and i have lots of basal golems that is created from the blood forge. i need a solution that works independent of how many units the player controls.

Then add the non-moving units to a unit group. Pick all units in the group every .25 seconds, if they are still not moving do the order check - if they started moving remove them from the group.

That will work.