Holy Orb v1.1

[Moderator]

31 Jan 2012
Bribe: Rating amended to 4/5. Thanks for making the changes.

 

[bowser499]

Nice thingy we have here... Okay, let's show this to mod.

 

[A.N.D.R.E.I.C.H]

...
not bad...

 

[LuizBills]

nice spell =) great work

 

[Ruke]

Why are you using Widget instead of Unit?.

call GroupEnumUnitsInRange(udg_HolyOrbGroup, x, y, 500., null)
To enumerate, you can use bj_lastCreatedGroup.

I think that loops like this:
exitwhen index > maxindex

Should be:

set index = value of maxindex
// ...
exitwhen index == 0
// Actions here
set index = index - 1

In the Trig_HolyOrb_Conditions function:
GetOwningPlayer(caster)

->

GetTriggerPlayer()

IsUnitEnemy(target, GetOwningPlayer(caster)) and not IsUnitType(target, UNIT_TYPE_DEAD) and not IsUnitType(target, UNIT_TYPE_STRUCTURE) and not IsUnitType(target, UNIT_TYPE_MAGIC_IMMUNE)

Maybe you can make filters like this configurables for the user.

call GroupClear(udg_HolyOrbGroup)
When you work with group-loops, you don't need this. Remember, the loop exits when the group is empty.

//                  Spell settings                    //
function HolyOrb_SpellID takes nothing returns integer
    return 'A000' //Spell raw code
endfunction

function HolyOrb_BuffID takes nothing returns integer
    return 'B000' //Buff raw code
endfunction

function HolyOrb_DummyID takes nothing returns integer
    return 'e000' //Dummy raw code
endfunction

function HolyOrb_MaxDummy takes nothing returns integer
    return 5 //Amount of dummies
endfunction

function HolyOrb_SpellDamage takes nothing returns real
    return 500. //Damage
endfunction

function HolyOrb_OrbSpeed takes nothing returns real
    return 20. //Orb moving speed
endfunction

function HolyOrb_SpellEffect takes nothing returns string
    return "LightNova.mdx" //Final explode model
endfunction
//                          END                         //

This will be better on the top.

GetOwningPlayer(caster)

If you use something more time than twice, you should create a new variable. Is more easy to work and more efficient (you don't need to call the same functions two+ times).

I think that's all. Nice work.

 

[solff]

i try this skill with no cooldown, and create 3 orbs together.
then when they target the enemy unit (explode), the damage inflicted is still 1 orb.
i hope you can change the trigger so when 3 orbs explode together, the damage inflicted would be from the 3 orbs.

 

[Ty3uK]

Updated, thanks for all

 

[Kam]

The author seems to be inactive but it would be nice if there was a settings option to remove camera shake, and to remove the buff once the orb explodes.