Holy Dragging Spell v1.05

[Moderator]

16:52, 27th Nov 2009
TriggerHappy:

Approved.

 

[Axarion]

Looks nice, nice idea good documentation customizable... 5/5

Edit: Why is rating not possible?

 

[-Berz-]

Edit: Why is rating not possible?

What? -.-

 

[Slaydon]

yes, its not a rate system or somth anymore, looks interesting btw;D

Wut, after posting this it came back

 

[D4RK_G4ND4LF]

it is either not MUI or bugged
sometimes I cast it without anything happening

edit:
hashtables
of cause it's bugged
and 4 triggers for a channel spell....
you could check if the order is == channel and merge the other trigger somehow (usually every spell is possible with 2 triggers but sometimes 3 are easier)

however all the other stuff seems to be good
you remove leaks
LOTS of documentation
new idea
ingame screenshot


you don't have to make it with indexing but fix the bug mentioned on top
(gl finding it)
I just don't like hashtables

 

[Maker]

it is either not MUI or bugged
sometimes I cast it without anything happening

After testing a bit, I coudn't make it bug. Could you tell when it bugs for you? I'll try to test some more.

hashtables of cause it's bugged
and 4 triggers for a channel spell....
you could check if the order is == channel and merge the other trigger somehow (usually every spell is possible with 2 triggers but sometimes 3 are easier)

I've never had anything bug due to it being made with hashtables, and I've done a lot of spells. Don't let your bias cloud your vision.

The first trigger fires when the spell is cast, it is needed.
The second trigger takes care of dragging units in, it's needed.
The third trigger adds units entering the area into unit group of units being dragged. It also creates special effects. The time interval of trigger #3 is much greater than the interval of trigger #2 (0,25 s vs 0,03 s). It's actually better to divide these into two different trigger, to make the spell require less CPU time.
The fourth trigger just cancels the spell. Can't do without it.

To me it sounds like you don't know what you're talking about. The number of triggers by itself doesn't make a spell any better/worse.

Saying "OMG it haz 4 trigggers, make it less" isn't worth anything. If you can give some advice and/or idea how to actually squezze it in three triggers without compromizing performance too much, I'm all ears.

I thank you for taking the time to have a look at the spell.

 

[D4RK_G4ND4LF]

20 edits later....

you still forgot about the bug:

 

[Shdow89]

Well I like the spell, effects are good, and executed well. Though I really don't like GUI, 'cause of 1000 of variables and triggers.

I would just give one comment on how to improve:

- Try using SetUnitX(whichUnit, newX) and SetUnitY(whichUnit, newY) instead using Unit - Move Instantly. It's really simple to use and units (ofc. if the speed is reasonable) can still move and be dragged (pulled), and it doesn't reset their commands. Not to mention it looks nicer .

Anyway my rating for this spell would be 4/5.

 

[Revolve]

Again, thanks alot You really executed it well :3

 

[reason 3]

Awesome spell,i like it a lot.5/5 from me!
Nice work as usual Maker

 

[Maker]

put that

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (Holy_Dragging_Spell_Lightning is empty) Equal to True
  • Then - Actions
    • Trigger - Turn off (This trigger)
  • Else - Actions

to the end of the trigger
so it will be executed only once and have the same effect

Now it gets executed as many times as there are units in the group. It only gets executed when a unit is removed form the group. 6 units in a group -> executed 6 times per spell cast.

If it is at the end of the trigger, it gets executed 1/(0.03)*6=200 times per spell cast. This is for the "group trigger". For the other trigger, it is one time per spell cast as it is now, or 1/(0.25)*6=24 times per spell cast.

So no, I won't put it at the end of the trigger.

your variable names are weird
sometimes you call the HDS_ and sometimes Holy_Dragging_Spell_
Typo: Holy_Daragging_Spell_Group

All HDS_something are what you can configure. But yeah, I guess they could all begin with HDS_

the hotkey is wrong
you wrote Q but it is B

Thanks for pointing that out.

...check if the order of the caster is equal to channel and

That would be slower solution than what it is now. There's absolutely no need to squeeze it in three triggers, unless there's some performance gain to be had by doing so.

if random integer between x and y equal to x

What do you mean by that? What do I need to randomize?

-hashtables are SLOW
-arrays are FAST

In my eyes hashtables are fast enough.

-making the same unit be able to cast a spell more then once at a runtime is much easier with arrays...

Yeah, but this spell is meant to have longer cooldown than it's duration is. Otherwise it would be way overpowered.

Thanks for your comments

- Try using SetUnitX(whichUnit, newX) and SetUnitY(whichUnit, newY) instead using Unit - Move Instantly.

Thanks, I will look into it.

========================================================================

Update:

v1.01
Using SetUnitX and SetUnitY instead of Move unit instantly. The spell now constantly pulls, which is cool.
Hotkey fixed.
Set pull speed to customizeable variable.

That SetUnitX/Y tip was golden. Awesome really. +rep coming your way.

 

[Maiaencore]

can i use this on my map??.

=]

+credits

 

[Maker]

As long as you give credits, you're free to use it in your map

 

[Atami]

Hi,

spell looks realy nice, but i found a big bug.
If you set the spell point out of the map, in the black area around the map, the moving units, going to be bugged. please fix it!
BTW. nice idea.

Looks nice thumbs_up
Good Coding thumbs_up
Mui thumbs_up
Some Bugs thumbs_down
Easy to Customize thumbs_up

So my rate is >> 4/5 <<

enjoy

 

[Maker]

Thanks for noticing that.

Updated:

v1.02
Fixed location leak.
Fixed child hashtable clearing bug.
Added pathing walkability check when moving units.

 

[88WaRCraFT3]

Maker i cant open your map.
Are you using some tools?-Why?-please answer

 

[Maker]

Do you have version 1.24b of WC3:TFT?

 

[88WaRCraFT3]

No!!
Ohhh
That means i must download or buy new TFT version 1.24 or i can find somewhere that version like update?

 

[reason 3]

You can download the latest patches just by joining Bnet,or from Blizzard's site.

 

[88WaRCraFT3]

Ok! Thank You.

 

[Karaterat]

hmmm did i imported this spell, and all works except the special effects from the beam. What could of i did wrong?

And do i need the dummy model

 

[Maker]

Yeah, you need to import the dummy.mdx and use it for your dummy unit. The special effects are attached to the dummy model, that's why they won't work if you don't have that model/dummy.

 

[Karaterat]

ah alright thx.

Oo and, love your two spells you made 5/5!

 

[Ciebron]

Could use a better name, but other then that is a Sweet spell, Good Job.

EDIT: This spell isnt MUI, if there is two or more copies of the spell up when the first one ends the other will end aswell

 

[Maker]

Thanks for reporting. I think I screwed up that MUI thing you mentioned in the last update, since I updated that trigger.

I'll fix it when I have some time.

 

[Maker]

I fixed the issue of units not being picked again. It should now be fully MUI. And hopefully approved soon

 

[real138]

y isnt this approved?? its a great spell and uhh triggerhappy so what if it costs 5 mana seriously it takes 5 seconds to fix that...

 

[reason 3]

TriggerHappy:

You leak temp_loc_1 inside your cast trigger.

The name is very lacking and the spell only costs 5 mana.

Seriously this is a reason for not being approved?
The name can be edited by any user who downloads it and same for the mana cost.
And for the leak,ok..Maker can fix it...
BUT I have seen approved spells leaking...and not only once.

APPROVE THIS PLEASE

 

[Maker]

You leak temp_loc_1 inside your cast trigger.

The name is very lacking and the spell only costs 5 mana.

I updated the mana cost to 125, it was 5 for testing purposes and forgot to change it.

It does not leak to my knowledge, I save the handle of Temp_Loc_1 for all units that are picked (key = center), and then remove the location when the spell ends in Holy Dragging Spell Group -trigger.

 

[Arnadath]

Nice work, although testing it with benchmarks, i found another ther is a leak.
hmm... maybe some unit group... i dunno it seems very good and i trust you as triggerer

 

[Maker]

What did you test it with? Leak check programs can't identify leak removals that take place in another trigger.

 

[Arnadath]

generally monitored the memory consumpion in bytes for wc3. in normall, it takes memory in a special space for replay, but i used do not ssve replay. after that it shouldnt increase in space, but it did (a eakless map, does never increase in space after Donotsavereplay())

 

[Maker]

I identified one possible memory leak in the lightning trigger.

I'd appreciate it if you could check it again, I'll throw you some +rep for your effort.

 

[Crazed_seal2]

I just need the drag trigger. Either way still gonna give credit.

 

[Gronis93]

Hi Ive tried to add it to my map, and I dont get it work. Ive doublechecked it twice with yours and its exactly the same. help please?

Edit:
the only thing that works is the slow spell. otherwise, its dead

 

[King.Sky_Gem]

Hi Ive tried to add it to my map, and I dont get it work. Ive doublechecked it twice with yours and its exactly the same. help please?

Edit:
the only thing that works is the slow spell. otherwise, its dead

Same here :s

 

[D4RK_G4ND4LF]

generally monitored the memory consumpion in bytes for wc3. in normall, it takes memory in a special space for replay, but i used do not ssve replay. after that it shouldnt increase in space, but it did (a eakless map, does never increase in space after Donotsavereplay())

that's because every time you create a unitgroup and destroy it it will leak a little memory
you can't do much about it though
JASS functions don't create unitgroups but add all units passing a certain filter to a group instead of creating the group and then adding all the units to it
of cause you can access these enumeration functions in custom script but it might be slow in a special case

• Custom Script: call GroupEnumUnitsInRange(udg_Group, udg_x, udg_y, udg_aoe, null)

"null" is the place for the filter function
usually you create a function in JASS which is like the following

function  filter takes nothing returns boolean
    return  GetUnitLife(GetFilterUnit())>0.405
endfunction

and you convert it to a filter using "Condition(function filter)" and replace the "null" with it
but you can't declare functions in GUI so you will have to use the null-filter version
actually this is damn fast (faster than anything else) if there is no unit, or only a few units which would pass the filter anyway, around but if there are MANY (50+) units within the area of effect which do NOT fullfill the given conditions it will be slower
this is because if you use a null-filter all units are added to the group and you have to check every unit in the pick-all-units-in-group-loop
checking within the condition is waaaay faster
you also could just make a few JASS filter functions and continue using them in GUI but some dumbass will mostlikely reply that if you are using JASS already you should make the whole spell with JASS and if you do it you will have to switch to vJASS because another dumbass will reply that it is much easier than JASS (which is true anyway but requires JNGP) and so it would not be GUI anymore

Hi Ive tried to add it to my map, and I dont get it work

you mostlikely forgot something
are all triggers working?
did you check if the ability codes are correct?
what about the imports?
and dummy units? (but if the slow works it's unlikely that you forgot to copy them x)

 

[aider]

If I want this awesome spell to be 3 levels instead of 2, can I just add one more level at the ability in "Object Editor", and then the triggers will multiply dmg/duration/speed etc. with the ability level? Thanks

 

[Maker]

Yes, that's how it works

 

[Tomek320]

Its quite nice , i need that function on the black hole spell , i mean to pull function ,for ICC ,can i "borrow it" :?

 

[Maker]

Yes, you can.

 

[kimberker]

Problem

I imported the spell n i edit it, when i cast it, it wont work

 

[-Berz-]

I imported the spell n i edit it, when i cast it, it wont work

that comment really explains your problem, be more specific. But from my experience you most likely forget to reconnect the conditions with the spell in trigger editor.

 

[SpectreD]

Looks very good

 

[Levoo]

Great update !

 

[magIc_seeKer]

hello ! i imported your spell, everything seems to work fine but i got one problem. the spell description says that allies should also get healed, well they don't any idea what's the problem?

 

[TheFrenchLeprechaun]

hello ! i imported your spell, everything seems to work fine but i got one problem. the spell description says that allies should also get healed, well they don't any idea what's the problem?

Yes, same problem. Even with the test map. And I'm looking for a solution too ^^

EDIT : Allies in the area of the casted spell aren't added to the HDS group.

 

[yram44]

very nice holy spell!!!