[Trigger] Hero selecting trigger

[xFiReFoXx]

Im having a problem with my hero selecting trigger, When i go to select a hero it will remove the wisp (i want it to do that) But it wont spawn the hero... My old trigger worked, but in order to try and save room i tryed to fit it into 1 trigger

Old trigger:

• spawn archer OLD
  • Events
    • Unit - A unit enters hero archer <gen>
  • Conditions
    • ((Triggering unit) is A ground unit) Equal to True
    • (Unit-type of (Triggering unit)) Equal to Wisp
    • (Owner of (Triggering unit)) Equal to Player 1 (Red)
  • Actions
    • Unit - Remove (Triggering unit) from the game
    • Unit - Create 1 Sylvanas Windrunner for Player 1 (Red) at (Center of (Playable map area)) facing Default building facing degrees

New trigger:

• spawn archer NEW
  • Events
    • Unit - A unit enters hero archer <gen>
  • Conditions
    • ((Triggering unit) is A ground unit) Equal to True
    • (Unit-type of (Triggering unit)) Equal to Wisp
  • Actions
    • Unit - Remove (Triggering unit) from the game
    • Unit - Create 1 Sylvanas Windrunner for (Triggering player) at (Center of (Playable map area)) facing Default building facing degrees

Any help?

 

[takakenji]

its because you removed the owner of triggering unit...

 

[En_Fuego]

• Unit - Create 1 Sylvanas Windrunner for (Triggering player) at (Center of (Playable map area)) facing Default building facing degrees

This should be "...for (Owner of Triggering Unit)..."

 

[xFiReFoXx]

well i know, i did that on purpose, and i dont think it would actually effect it >< cause i was trying to slim down 40 triggers into 4......

edit: didnt see your post- en funego

 

[Adiktuz]

you dont have a triggering player because your event is unit based so follow their suggestions...

and you dont need that ground unit condition...

 

[Snuffy]

Wouldn´t it be better to use Entering Unit instead of Triggering Unit, cause of the Event?

 

[Saia_Djinn]

triggering is better(heard today by the Reborn DEvil so credit him)
but also you can skip the condition trigger unit is a ground unit

you leak also a point
set the mid of the map to a point variable named TempLoc and create units at the variable position ,
as well as adding following line to your triggers
call RemoveLocation(udg_TempLoc)

what it look like in acceptable way

• spawn archer NEW
  • Events
    • Unit - A unit enters hero archer <gen>
  • Conditions
    • (Unit-type of (Triggering unit)) Equal to Wisp
  • Actions
    • set TempLoc = CenterOfPlayableMapArea
    • Unit - Create 1 Sylvanas Windrunner for (OwnerOf(Triggering unit) at (TempLoc) facing 0.
    • Unit - Remove (Triggering unit) from the game
    • call RemoveLocation(udg_TempLoc)

 

[Lightskin]

i belive that this should work even a bit better

• spawn archer NEW
• Events
• Unit - A unit enters hero archer <gen>
• Conditions
• (Unit-type of (Entering unit)) Equal to Wisp
• Actions
• set TempLoc = CenterOfPlayableMapArea
• Unit - Create 1 Sylvanas Windrunner for (OwnerOf(Entering unit) at (TempLoc) facing 0.
• Unit - Remove (Entering unit) from the game
• call RemoveLocation(udg_TempLoc)

 

[Saia_Djinn]

no triggering unit is refered 2 faster (as i said reborn devil told me before and i believe)
also even faster would be 2 safe the unit in a variable so we are safing a call and do everything in conditions (only possible in JASS)

 

[Element of Water]

When it's a hero selecting trigger that will only be used a maximum of 12 times throughout the game, you don't need to care about location leaks.

 

[Saia_Djinn]

no u should clean them up because it messes up in the end
also 12 really don't cares
it's still better to have 0 instead of 12