[Spell] Hellfire Blast

[jj84]

hi guys i made Hellfire Blast ability, please check it, have i done it correctly? thanks.

• Hellfire Blast
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Hellfire Blast
  • Actions
    • Custom script: local unit t = GetSpellTargetUnit()
    • Custom script: set udg_Targeted = t
    • Wait until ((Targeted has buff Stunned (Pause)) Equal to True), checking every 0.10 seconds
    • Set TargetLoc = (Position of Targeted)
    • Unit - Create 1 Dummy for (Owner of (Triggering unit)) at TargetLoc facing Default building facing degrees
    • Set Dummy = (Last created unit)
    • Unit - Add Hellfire Blast (Damage) to Dummy
    • Unit - Set level of Hellfire Blast (Damage) for Dummy to (Level of Hellfire Blast for (Triggering unit))
    • Unit - Order Dummy to Night Elf Warden - Shadow Strike Targeted
    • Unit - Add a 0.20 second Generic expiration timer to Dummy
    • -------- Damage over time --------
    • Custom script: call UnitDamageTargetBJ( GetTriggerUnit(), t, 20.00, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_NORMAL )
    • Wait 1.00 seconds
    • Custom script: call UnitDamageTargetBJ( GetTriggerUnit(), t, 20.00, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_NORMAL )
    • Wait 1.00 seconds
    • Custom script: call UnitDamageTargetBJ( GetTriggerUnit(), t, 20.00, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_NORMAL )
    • Wait 1.00 seconds
    • Custom script: call UnitDamageTargetBJ( GetTriggerUnit(), t, 20.00, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_NORMAL )
    • -------- Remove Leak --------
    • Custom script: call RemoveLocation(udg_TargetLoc)
    • Custom script: set t = null
    • Custom script: set udg_Targeted = null
    • Custom script: set udg_TargetLoc = null
    • Custom script: set udg_Dummy = null

 

[Uncle]

Unfortunately, that's breaking most of the rules for what's considered "working correctly". It should technically work but for all of the wrong reasons and not without potential issues.

• Currently only one instance can be active at a time for it to work properly. The attempt to use local variables to avoid this issue is a good start but Targeted and TempLoc are still acting as global variables. Regardless, this is not a recommended solution.
• The unit can be stunned from a different ability that uses the Stunned (Pause) buff. Also, the Wait check is every 0.10 seconds which has the potential to miss the buff. That's unlikely to happen, but this shouldn't be something that we have to worry about.
• You're Removing TargetLoc after Waits, that's not safe since it can change during that period of time.
• You're Nulling global variables, there's no good reason to do this.
• Waits are generally bad practice. They're imprecise, they can run while the game is Paused (use Wait Game-Time to avoid that), and can't be cancelled or paused like a Timer. A "one time" cinematic is a good place to use a Wait, a custom spell that can fire multiple times in a row is not.
• The Dummy unit is removed from the game after 0.20 seconds, potentially causing issues if Shadow Strike relies on the caster.

Fixes:
I recommend this system for handling custom triggered Missiles (see my 1st post): [Spell] - Phoenix Fire replacement
I recommend using Unit Indexing to handle the damage over time effect once the Missile hits it's target. Or use another system that does all of the hard work for you: DamageOverTime v1.3

 

[jj84]

Unfortunately, that's breaking most of the rules for what's considered "working correctly". It should technically work but for all of the wrong reasons and not without potential issues.

• Currently only one instance can be active at a time for it to work properly. The attempt to use local variables to avoid this issue is a good start but Targeted and TempLoc are still acting as global variables. Regardless, this is not a recommended solution.
• The unit can be stunned from a different ability that uses the Stunned (Pause) buff. Also, the Wait check is every 0.10 seconds which has the potential to miss the buff. That's unlikely but this shouldn't be something that we have to worry about.
• You're Removing TargetLoc after Waits, that's not safe since it can change during that period of time.
• You're Nulling global variables, there's no good reason to do this.
• Waits are generally bad practice. They're imprecise, they can run while the game is Paused (use Wait Game-Time to avoid that), and can't be cancelled or paused like a Timer. A "one time" cinematic is a good place to use a Wait, a custom spell that can fire multiple times in a row is not.
• The Dummy unit is removed from the game after 0.20 seconds, potentially causing issues if Shadow Strike relies on the caster.

Fixes:
I recommend this system for handling custom triggered Missiles (see my 1st post): [Spell] - Phoenix Fire replacement
I recommend using Unit Indexing to handle the damage over time effect once the Missile hits it's target. Or use another system that does all of the hard work for you: DamageOverTime v1.3

Thanks

 

[jj84]

@Uncle is it better now? thanks for your help.

• Hellfire Blast
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Hellfire Blast
  • Actions
    • Custom script: local unit t = GetSpellTargetUnit()
    • Custom script: local location point = GetUnitLoc(GetSpellTargetUnit())
    • Custom script: set udg_Targeted = t
    • Wait until (((Targeted has buff Stunned (Pause)) Equal to True) or (((Triggering unit) has buff Stunned) Equal to True)), checking every 0.10 seconds
    • Custom script: set udg_TargetLoc = point
    • Unit - Create 1 Dummy for (Owner of (Triggering unit)) at TargetLoc facing Default building facing degrees
    • Set Dummy = (Last created unit)
    • Unit - Add Hellfire Blast (Damage) to Dummy
    • Unit - Set level of Hellfire Blast (Damage) for Dummy to (Level of Hellfire Blast for (Triggering unit))
    • Unit - Order Dummy to Night Elf Warden - Shadow Strike Targeted
    • Unit - Add a 2.00 second Generic expiration timer to Dummy
    • -------- Damage over time --------
    • Custom script: call UnitDamageTargetBJ( GetTriggerUnit(), t, 20.00, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_NORMAL )
    • Wait 1.00 game-time seconds
    • Custom script: call UnitDamageTargetBJ( GetTriggerUnit(), t, 20.00, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_NORMAL )
    • Wait 1.00 game-time seconds
    • Custom script: call UnitDamageTargetBJ( GetTriggerUnit(), t, 20.00, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_NORMAL )
    • Wait 1.00 game-time seconds
    • Custom script: call UnitDamageTargetBJ( GetTriggerUnit(), t, 20.00, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_NORMAL )
    • -------- Remove Leak --------
    • Custom script: call RemoveLocation(udg_TargetLoc)
    • Custom script: set t = null
    • Custom script: set point = null

 

[Uncle]

No, it's still making the same mistakes.

 

[jj84]

No, it's still making the same mistakes.

• Wait until (((Targeted has buff Stunned (Pause)) Equal to True) or (((Triggering unit) has buff Stunned) Equal to True)), checking every 0.10 seconds
• Unit - Add a 2.00 second Generic expiration timer to Dummy

i edited buff event and dummy time but for damage over time i'm noob i couldn't use damage over time but i tested it in multi caster and it worked.

 

[Daffa]

Curious, can you share what the spell meant to do?

 

[jj84]

Curious, can you share what the spell meant to do?

King Leoric - Skeleton King, Skills, Item Builds | DotA Builds

King Leoric - Skeleton King - Once a noble knight protecting his kingdom, the man was thrown into Hell, where he was ...

www.dotabuilds.com

 

[Uncle]

King Leoric - Skeleton King, Skills, Item Builds | DotA Builds

King Leoric - Skeleton King - Once a noble knight protecting his kingdom, the man was thrown into Hell, where he was ...

www.dotabuilds.com

That's some old DotA info, he doesn't have the damage over time or anything like that.

I show how to do Damage over time here:

Help with over time spell damage in MUI

Hello and greetings if anyone would be able to read this thread. I need help with the spell I am working on. I've been trying to follow some basic in making MUI spells in the tutorial but mine seems not to fire correctly at all. So this spell that I am currently working, holds a target in place...

www.hiveworkshop.com

Or use a system that does the work for you.

 

[Daffa]

I think you refer to the Dota 2 variant of Skeleton King? Skeleton King

 

[jj84]

I think you refer to the Dota 2 variant of Skeleton King? Skeleton King

that's right

 

[jj84]

That's some old DotA info, he doesn't have the damage over time or anything like that.

I show how to do Damage over time here:

Help with over time spell damage in MUI

Hello and greetings if anyone would be able to read this thread. I need help with the spell I am working on. I've been trying to follow some basic in making MUI spells in the tutorial but mine seems not to fire correctly at all. So this spell that I am currently working, holds a target in place...

www.hiveworkshop.com

Or use a system that does the work for you.

thank you again, this system is suitable for me.