Having trouble with my ability learning system

[Lazytom]

Hey all, been messing with the editor for a couple months now, in the midst of a large project currently. My problem here is that the ability learning system i've devised doesn't work and i can't think why.

Here is an example, perhaps someone could shed light on the problem?

• Warrior Levelling
  • Events
    • Unit - A unit Gains a level
  • Conditions
    • (Leveling Hero) Equal to Warrior
  • Actions
    • Set WarriorLevel = (WarriorLevel + 1)
    • Wait 0.01 seconds
    • If (WarriorLevel Equal to 3) then do (Unit - Add Last Stand (WARRIOR) to Warrior) else do (Do nothing)
    • Wait 0.01 seconds
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • WarriorLevel Equal to 5
      • Then - Actions
        • Unit - Remove Dodge (WARRIOR, rank1) from Warrior
        • Wait 0.01 seconds
        • Unit - Add Dodge (WARRIOR, rank2) to Warrior
      • Else - Actions
        • Do nothing

"Warrior" and "WarriorLevel" are both variables, their original values are declared at map initialisation.

Any ideas?

 

[calle287]

Hmm have you tried to set warrior(variable) to the hero if not then nothing happens
EDIT: like Set Warrior=(last created unit) or something

 

[Saia_Djinn]

also you dont need the waits they are just buggy and don't help anything

 

[MortAr]

First off all, yes remove the waits and the "Do Nothing" thing, they just slow down the trigger.

Secondly why you remove the ability? Just increase its level by 1 with this:

• Unit - Increase level of <Ability> for <Unit>

 

[Noobsmoke]

remove action "Do nothing" ... and never use it !

 

[Maker]

Are those unit or hero abilities?

For unit abilities, it's like this:

• Untitled Trigger 092
  • Events
    • Unit - A unit Gains a level
  • Conditions
  • Actions
    • Set Temp_Integer_1 = (Temp_Integer_1 + 1)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Temp_Integer_1 Equal to 3
      • Then - Actions
        • Unit - Add Abolish Magic to (Triggering unit)
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Temp_Integer_1 Equal to 5
          • Then - Actions
            • Unit - Remove Aerial Shackles from (Triggering unit)
            • Unit - Add Ancestral Spirit to (Triggering unit)
          • Else - Actions

 

[reason 3]

remove action "Do nothing" ... and never use it !

Wrong..sometimes Do nothing is actually usefull.

 

[Maker]

^When would that be the case?

 

[Forgotten_Warlord]

First off all, yes remove the waits and the "Do Nothing" thing, they just slow down the trigger.

Secondly why you remove the ability? Just increase its level by 1 with this:

• Unit - Increase level of <Ability> for <Unit>

yes this would work but make sure it detects the max level of the ability, because otherwise, idk if it still does or not but that use to make the game crash if it got the ability level higher than the actual level, or it bugged the ability

if then multiple functions work great, your system just needs redesigned, you don't need any variables for this at all.

 

[Noobsmoke]

Do nothing means ... nothing and nothing i an action ... and the computer "read" it ...

 

[reason 3]

Do nothing means ... nothing and nothing i an action ... and the computer "read" it ...

If you don't believe just do NOT use it.I agree to the 99% of the cases it is not needed...but some time it IS.
It's just the same as some times the wait 0.00 action is needed.

I won't put any effort to pursue you...but you can always try to find out what i mean by yourself.

 

[axleion]

but some time it IS.
It's just the same as some times the wait 0.00 action is needed.

I wonder what situation that "needed" Do Nothing....

 

[reason 3]

I wonder what situation that "needed" Do Nothing....

You really do?Then what about this?

• Player Group - Pick every player in Players and do (If ((Name of (Picked player)) Equal to reason3) then do (Game - Defeat (Picked player) with the message: You are a champion!) else do (Do nothing))

I know this can be done with if/then/else but if someone want to do it this way what would you put there?

 

[axleion]

damn, nice example....