Hammer of Storm v 1.3

[Moderator]

17:11, 16th Jun 2010
Hanky:
There are leaks and it's not even MUI or MPI. Before you submit anything please read the spell submission rules.

 

[krisserz]

Leaks, waits, non-MUI.
Read the leak tutorial...

 

[Egorman]

Leaks, waits, non-MUI.
Read the leak tutorial...

I read it. What are my leaks?

 

[krisserz]

leaks

• Unit Group - Pick every unit in (Units within 300.00 of (Position of HoS_Unit[2])) and do (Actions)

Leaks unit group and location (Position of HoS_Unit[2]))

• Unit - Move (Picked unit) instantly to ((Position of (Picked unit)) offset by -3.00 towards (Facing of (Picked unit)) degrees)

Location

• Lightning - Create a Chain Lighting - Main lightning effect from source (Position of HoS_Unit2[HoS_Number[3]]) to target (Position of (Picked unit))

Location twice

• Unit - Make (Picked unit) face (Position of HoS_Unit[2]) over 0.00 seconds

Location

Here you are. I may missed something, but these are enaugh. Also as I said the spell isn`t MUI and the way you damage target is inefficient.

 

[Egorman]

leaks

• Unit Group - Pick every unit in (Units within 300.00 of (Position of HoS_Unit[2])) and do (Actions)

Leaks unit group and location (Position of HoS_Unit[2]))

• Unit - Move (Picked unit) instantly to ((Position of (Picked unit)) offset by -3.00 towards (Facing of (Picked unit)) degrees)

Location

• Lightning - Create a Chain Lighting - Main lightning effect from source (Position of HoS_Unit2[HoS_Number[3]]) to target (Position of (Picked unit))

Location twice

• Unit - Make (Picked unit) face (Position of HoS_Unit[2]) over 0.00 seconds

Location

Here you are. I may missed something, but these are enaugh. Also as I said the spell isn`t MUI and the way you damage target is inefficient.

Thank you, I will correct these mistakes.
Explain to me please: what is MUI?

 

[krisserz]

Explain to me please: what is MUI?

Multi unit instancible. Try to cast this spell by 2 units at the same time. I`m sure it`ll bug. You must make this (and your second spell too) work in such a cases.
There are two ways of making spell MUI. One of them are hashtables and second one indexing (there you may find more information which could be useful for you).

 

[VoidLordXtreme]

dont use wait... they are very inefficient and they kill the spell being MUI (every units can cast it at the same time)

also your coding is inefficient:

this:

• If ((Level of Hammer of Storm for HoS_Unit[1]) Equal to 1) then do (Unit - Cause HoS_Unit[1] to damage (Picked unit), dealing 50.00 damage of attack type Spells and damage type Normal) else do (Do nothing)
• If ((Level of Hammer of Storm for HoS_Unit[1]) Equal to 2) then do (Unit - Cause HoS_Unit[1] to damage (Picked unit), dealing 100.00 damage of attack type Spells and damage type Normal) else do (Do nothing)
• If ((Level of Hammer of Storm for HoS_Unit[1]) Equal to 3) then do (Unit - Cause HoS_Unit[1] to damage (Picked unit), dealing 150.00 damage of attack type Spells and damage type Normal) else do (Do nothing)
• If ((Level of Hammer of Storm for HoS_Unit[1]) Equal to 4) then do (Unit - Cause HoS_Unit[1] to damage (Picked unit), dealing 200.00 damage of attack type Spells and damage type Normal) else do (Do nothing)

sould be like:

• Unit - Cause HoS_Unit[1] to damage (Picked unit), dealing (50.00 x (Real((Level of Hammer of Storm for HoS_Unit[1])))) damage of attack type Spells and damage type Normal

also, to avoid waits, you should set the whole trigger in the HoS move trigger, making the HoS start trigger only the init Trigger

you can count the time with integer or real variables

• Events
  • Time - Every 0.02 seconds of game time
• Conditions
• Actions
• Set Count_Real = (Count_Real + 0.01)
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • Count_Real Greater than or equal to 50.00
  • Then - Actions
    • blablabla
  • Else - Actions
    • blablabla

this is an example only

edit:

• Set HoS_Point[2] = ((Position of (Picked unit)) offset by -3.00 towards (Facing of (Picked unit)) degrees)

position of picked unit leaks

you should place a

• Custom script: set bj_wantDestroyGroup = true

before

• Unit Group - Pick every unit in (Units within 300.00 of HoS_Point[1]) and do (Actions)

well i think thats it... remove all the waits and replace them with timers

have fun and good luck

 

[Egorman]

edit:

• Set HoS_Point[2] = ((Position of (Picked unit)) offset by -3.00 towards (Facing of (Picked unit)) degrees)

What can replace

• Set HoS_Point[2] = ((Position of (Picked unit)) offset by -3.00 towards (Facing of (Picked unit)) degrees)

?????

 

[krisserz]

What can replace

• Set HoS_Point[2] = ((Position of (Picked unit)) offset by -3.00 towards (Facing of (Picked unit)) degrees)

?????

You must store Position of (Picked unit) to the variable (let`s say it`ll be HoS_Point[100]) and then you can

• Set HoS_Point[2] = HoS_Point[100] offset by -3.00 towards (Facing of (Picked unit)) degrees)

 

[Egorman]

How I set it?
I must set position of picked unit!
Can I set HoS_Point[100] = Position of Picked unit??

 

[krisserz]

The whole thing must (coz we don`t want the trigger to leak a location) look like this

• Set HoS_Point[100] = Position of (Picked unit)
• Set HoS_Point[2] = HoS_Point[100] offset by -3.00 towards (Facing of (Picked unit)) degrees)
• Custom script: call RemoveLocation(udg_HoS_Point[100])
• -------- And later... --------
• Custom script: call RemoveLocation(udg_HoS_Point[2])

 

[Egorman]

The whole thing must (coz we don`t want the trigger to leak a location) look like this

• Set HoS_Point[100] = Position of (Picked unit)
• Set HoS_Point[2] = HoS_Point[100] offset by -3.00 towards (Facing of (Picked unit)) degrees)
• Custom script: call RemoveLocation(udg_HoS_Point[100])
• -------- And later... --------
• Custom script: call RemoveLocation(udg_HoS_Point[2])

OK!Thanks!I edit this now.