Hades Spellpack (DC animated universe)

[Wrda]

Fist of the Underword King: You're currently not using local real angle in private function onCast.
You could cache GetHandleId of the unit in private function onUnitHit as an improvement. I think the range of the knockback should be configurable.
Breath of Hell Fire: It's slightly confusing to casting on a unit while it is a targeting image due to how you configured it in object editor. AngleBetweenPointsReal function doesn't seem to be used here, you're using Atan2, instead for some reason. I believe the models' path should be configurable.
Dominion of the Dead: perhaps making the cooldown reduction % amount configurable would be nice too.

I assume all of the libraries are required, although people might have to change the raw code of the dummy caster in DummyCaster trigger when copying the required unit data. You should add that to the instructions.

Overall, they're pretty powerful spells. Writing a description for each spell on the page is recommended and required, since it's generally more appealing and attractive.

Very minor fixes and improvements to be made.

 

[KitsuneTailsPrower]

Fist of the Underword King: You're currently not using local real angle in private function onCast.
You could cache GetHandleId of the unit in private function onUnitHit as an improvement. I think the range of the knockback should be configurable.
Breath of Hell Fire: It's slightly confusing to casting on a unit while it is a targeting image due to how you configured it in object editor. AngleBetweenPointsReal function doesn't seem to be used here, you're using Atan2, instead for some reason. I believe the models' path should be configurable.
Dominion of the Dead: perhaps making the cooldown reduction % amount configurable would be nice too.

I assume all of the libraries are required, although people might have to change the raw code of the dummy caster in DummyCaster trigger when copying the required unit data. You should add that to the instructions.

Overall, they're pretty powerful spells. Writing a description for each spell on the page is recommended and required, since it's generally more appealing and attractive.

Very minor fixes and improvements to be made.

Not sure what you meant by "range of the knockback" since the distance the unit is knocked back is already configurable. If you mean the collision range that's handled by the knockback library. I made the other fixes.

 

[Wrda]

Not sure what you meant by "range of the knockback" since the distance the unit is knocked back is already configurable. If you mean the collision range that's handled by the knockback library. I made the other fixes.

Sorry, I actually meant the time (4th parameter of the create function) of the knockback.

 

[KitsuneTailsPrower]

Sorry, I actually meant the time (4th parameter of the create function) of the knockback.

Done

 

[Wrda]

People might confuse with the wording on the 3rd point of the import instructions since it implies both use the same dummy unit id. "Configure the respective dummy unit ID in Dummy Caster and relatistic missiles libraries (Missiles trigger)" would clear all doubts.

All the other changes were made and the spellpack is good.

Approved

 

[KitsuneTailsPrower]

People might confuse with the wording on the 3rd point of the import instructions since it implies both use the same dummy unit id. "Configure the respective dummy unit ID in Dummy Caster and relatistic missiles libraries (Missiles trigger)" would clear all doubts.

I fixed this during my recent update