[Solved] GUI triggerer come in : Unit group leak, need fast reply!

[rysnt11]

I make a spell, that spell is kind of locust swarm, but with triggered damage and unit
What i want to ask is
1. I make 3 unit group call (gui version)
This:

• Unit group - pick every unit in (unit within bla of bla bla [1]) and do (action)

How i prevent group leak, or the unit group it self didn't leaked?

 

[GangSpear]

• Custom script: set bj_wantDestroyGroup = true

use this?

 

[rysnt11]

Only that?
Hmm...
I use that too...
Did that completly remove the leak?

 

[Marc Mamales]

store it to a variable

• Actions
  • Set UnitGroup = (Units within 512.00 of (Center of (Playable map area)))
  • Unit Group - Pick every unit in UnitGroup and do (Actions)
    • Loop - Actions
      • Unit - Kill (Picked unit)
  • Custom script: call DestroyGroup(udg_UnitGroup)

 

[rysnt11]

Which is more efficient?
Set bj wanttodestroygroup
Or
Call destroygroup(udg_yourgroup)?

 

[defskull]

If you're using GUI, don't care at all about efficiency.

 

[Maker]

bj_wantDestroy... is more efficient since that boolean is checked always when a group is picked in GUI.

But don't use it if you want to use the same group later.

@def, while that is not completely true. You can do efficient GUI and unefficient GUI.

Small things like this won't matter much though.

 

[rysnt11]

@def:
Haha~
So you learing about vjass?
Just Assuming from what have you said...
No offens
@maker:hmm...
Did the bjwanttodestroy can used in 3 unit group, for each of them?

 

[Maker]

You can use the boolean for as many unit groups as you like. It gets set to false automatically after each GUI unit group pick, so you have to set it to true before the next group you want to use if for.

 

[rysnt11]

Okay, i get it
Thanks all

 

[Bribe]

store it to a variable

• Actions
  • Set UnitGroup = (Units within 512.00 of (Center of (Playable map area)))
  • Unit Group - Pick every unit in UnitGroup and do (Actions)
    • Loop - Actions
      • Unit - Kill (Picked unit)
  • Custom script: call DestroyGroup(udg_UnitGroup)

Yeah that's the really overkill method. The only reason to do this is if you run into a situation where you have to reference that group more than once or you run into the "two birds with one stone" paradox.

• -------- Normal use --------
• Custom script: set bj_wantDestroyGroup = true
• Unit Group - Pick all...
  • Loop - Actions
    • -------- Fine --------
• -------- But this --------
• Custom script: set bj_wantDestroyGroup = true
• Unit Group - Pick all units in (Units in range of (Random unit from (Units...
  • Loop - Actions
    • -------- Uh oh, only one of these groups is gonna get destroyed here --------

 

[rysnt11]

@bribe: so, how to excactly destroy 3 group at once

 

[Bribe]

Well you can't destroy them at once, you have to set the extra ones to variables and destroy them one by one afterwards. For example, a solution to the problem above would be to do this:

• Custom script: set bj_wantDestroyGroup = true
• Set TempUnit = (Random unit from (Units...
• Custom script: set bj_wantDestroyGroup = true
• Unit Group - Pick all units in (Units in range of TempUnit...
  • Loop - Actions

 

[rysnt11]

Well you can't destroy them at once, you have to set the extra ones to variables and destroy them one by one afterwards. For example, a solution to the problem above would be to do this:

• Custom script: set bj_wantDestroyGroup = true
• Set TempUnit = (Random unit from (Units...
• Custom script: set bj_wantDestroyGroup = true
• Unit Group - Pick all units in (Units in range of TempUnit...
  • Loop - Actions

so, judging from the statement above, the tempunit is destroyed first, then the Unitgroup below

 

[Bribe]

It's because "(Random unit---" also works with bj_wantDestroyGroup that I was able to use that custom script. In some cases you actually have to set it to a unit group variable in order to properly destroy it, but for the most part you can get away with this shortcut.

 

[rysnt11]

Hmm...
I'll move to trigger and script, my spell seems so messed up...
I can't get the wip yet..
Uh oh...