[GUI] Sanctuary v1.0c

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

The spell is quite simple, maybe you could make it more original.

The dummy doesn't need invulnerability, locust makes it invunlerable.
SancLevel should be stored as a real, since you're not using it as an integer.
Try to calculate as much as you can outside the loop.
0.03 interval is too low for this.

Pharaoh, 23:30, 9th Oct 2011

Pharaoh_: Addressed a few points you should take care of.

 

[Zaio]

A rather simple spell but it works and i see no leaks. Good job.

However theese lines are not needed

• Set SancEffect[ID2] = (Last created special effect)
• Special Effect - Destroy SancEffect[ID2]

just use

• Special Effect - Destroy Last Created Special Effect

 

[Pharaoh_]

SancDamage doesn't have to be an array variable.

Make the special effects' models configurable in the Map Initialization.

Don't use two unit groups for the enumerations, just use an if/then/else inside of them to check whether the (Picked unit) belongs to an ally; if it does, perform the X actions, else, perform the Y actions. Once again, they don't need to have an array installed.

The spell is too simple I'm afraid.

 

[Adiktuz]

idea is nice, but yeah, it might be too simple...

 

[JsK]

Actually, I am still new to the unit indexer. Still trying to get used to it, I will try my best to improve it!

Updated triggers. More stuff will be added in the future.

 

[Zaio]

You might want to try making a more advanced spell JsK, you know leak proofing and made this spell almost perfect for what it is supposed to do, this spell is just too simple to get approved though, and you wont really be able to improve it much more. Try a more complex spell.

 

[baassee]

What if my allie is an undead? (yeah I know it will be healed but a dilemma hehe)

 

[Pharaoh_]

You don't have to declare the strings'e effects every time the ability is cast. Move them to the Map Initialization so that they are loaded once.

Rename SancReal[] to SancDamage[].

You use TempPoint and SancPoint[]. The first one is not needed.

Set Art - Death time of your dummy unit to 0 and Combat - Death type to "Can't raise, does not decay".

Use a unit group to add units already affected by one instance, to prevent the spam of the special effect on them.

Check whether the allied units' life is not equal to the maximum life of the unit (or percentage life not equal to 100%), to prevent enumeration and effects' creation.

The spell is not 100% MUI. When you create two instances, the second one will expire before the first one. It replaces the duration with the first instance, runs it till the duration is over and then continues checking for the first one.
A simple display of SancDuration[ID] in the loop trigger can prove that.