[GUI][MUI] Squad System v0.92

[Moderator]

12th Dec 2015
IcemanBo: Too long time as NeedsFix. Rejected.

10:41, 29th Jul 2010
The_Reborn_Devil:

It's getting better, but I noticed that you, in the trigger "Periodic" put this:

• Custom script: call RemoveLocation( udg_Temp_Point )

Outside the unit group loop. For every unit the "Unit Group - Pick every unit in Squads_Vars_Leaders and do (Actions)" finds you create a new location and it's important that you remove all and not only the last one ^^

Also, you can remove the

• Custom script: call RemoveLocation( udg_Temp_Point_2 )

You're not using it in that trigger.

Also, you might wanna use "Triggering Unit" whenever a unit dies, starts the effect of an ability, etc instead of "Dying Unit" and "Casting Unit".

The rest looks good to me.


Status: Rejected until updated
Rating: N/A

PM me or another mod once you've updated this to get it reviewed again. Have a nice day!

 

[RoboHippo]

Please tell me if you find a bug, leak, or just something that needs improvement.

When computer controlled squads are enabled (as they are in the demo map), pathing can get a bit glitchy, due to the workarounds for some aspects of WC3 AI.

 

[mnib]

the idea looks cool im not spell maker so dunno with triggers
that deserves a rep

 

[CoolSoFar]

I liked the idea, the trigger is easy to edit for one's preferred use

I don't see any bug, leak or glitches, however it need improvement... a lot..

• when you move in straight the unit following just right but when you change where you're heading they're moving in a mess, even worse if you change your facing point twice lot of them will rounding you all around and won't stop even if you leave them for minutes
• you need to limit how much units to recruit, just by having 6 melee units makes them grouping up like some mob not a squad :/
• when one of your units summon a water elemental or charming enemy units, they're not following you
• the units can't keep up their formation if the commander have superior movespeed, this might be a real problem if we're using heroes as commander and equipping a movespeed bonus item

I still haven't take a peek at your trigger, sorry I can't help you to improve it :/

sorry if my choose of words kinda harsh, but personally I really expect this system to be done and put it in my map

 

[RoboHippo]

I liked the idea, the trigger is easy to edit for one's preferred use

I don't see any bug, leak or glitches, however it need improvement... a lot..

• when you move in straight the unit following just right but when you change where you're heading they're moving in a mess, even worse if you change your facing point twice lot of them will rounding you all around and won't stop even if you leave them for minutes
• you need to limit how much units to recruit, just by having 6 melee units makes them grouping up like some mob not a squad :/
• when one of your units summon a water elemental or charming enemy units, they're not following you
• the units can't keep up their formation if the commander have superior movespeed, this might be a real problem if we're using heroes as commander and equipping a movespeed bonus item

I still haven't take a peek at your trigger, sorry I can't help you to improve it :/

sorry if my choose of words kinda harsh, but personally I really expect this system to be done and put it in my map

The pathing system works much better when you disable computer-controlled squads (they'll form in an arc behind you). They get all bunched up because with computer players, they always want to move their units back to their start location, so I had to tell them to hold position if within a certain range, when computers are enabled.

I think I'll add a way of limiting sqaud members right now...
EDIT: done

when one of your units summon a water elemental or charming enemy units, they're not following you

Summoned/charmed units are periodically given to the owner of the squad member responsible for them. Otherwise, your squad could exceed maximum size, with masses of Skeleton Warriors, etc. If you wish for them to continue following you, just recruit them.

 

[ALiEN95]

im not sure if the code is even good,sorry i didnt read it all,it was enough for me to see
"Determine New Owner" trigger
change it ans use
for each integer X from 1 to 12 do actions
loop
-if your player exual to player X
...

 

[RoboHippo]

im not sure if the code is even good,sorry i didnt read it all,it was enough for me to see
"Determine New Owner" trigger
change it ans use
for each integer X from 1 to 12 do actions
loop
-if your player exual to player X
...

Yeah, I've been meaning to change that trigger. I'll get on it in a bit.

EDIT: Actually, I've been looking more at that, but although what you suggested is certainly more elegant, what I originally put in there seems more efficient, since there's no way to break a loop in GUI. But, with nested if-statements, it will stop checking as soon as it finds the right player.