GUI Damage over Time [GDoT]

[IcemanBo]

I found these systems pretty quickly:

[GUI] Effect Over Time System 2.3.1
DOT [GUI-Damage Over Time]
DamageOverTime(DOT) 1.7
(DOT) Damage Over Interval Time. v3
https://www.hiveworkshop.com/threads/d-o-t-damage-over-time-v1-6c.110313/#resource-43679

mind to elaborate if your is superior? Heck, maybe we should go to check some of them again, but it's little senselful to approve same and same resources if we already have a hand full.

 

[Reventhous]

can you give me any idea for this system
improvement that will make some different from the others

 

[IcemanBo]

Currently not. When I tested "Effect over Time", iirc it handled DoT pretty well for me.

 

[Reventhous]

I trying to update this system because I detected a problem with the GUI linked list,
here is the new trigger

New

• GDoT
  • Events
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • And - All (Conditions) are true
          • Conditions
            • GDoTRegister_Caster Not equal to No unit
            • GDoTRegister_Target Not equal to No unit
      • Then - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • And - All (Conditions) are true
              • Conditions
                • GDoT_UseWrapper Equal to True
          • Then - Actions
            • Custom script: call ExecuteFunc("GDoTRegister")
          • Else - Actions
            • Custom script: call ExecuteFunc("GDoTRegisterEx")
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • GDoT_DebugMode Equal to True
          • Then - Actions
            • Game - Display to (All players) the text: GUI DoT: Error! App...
          • Else - Actions
    • Custom script: endfunction
    • -------- --------
    • Custom script: function GDoTOnIterate takes nothing returns nothing
    • Set GDoT_Current = GDoT_Next[0]
    • -------- --------
    • Custom script: loop
    • Custom script: exitwhen udg_GDoT_Current == 0
    • -------- --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • And - All (Conditions) are true
          • Conditions
            • GDoT_HitAmount[GDoT_Current] Greater than 0
            • (GDoT_Target[GDoT_Current] is alive) Equal to True
      • Then - Actions
        • -------- --------
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • GDoT_Freq[GDoT_Current] Greater than or equal to GDoT_DmgFrequency[GDoT_Current]
          • Then - Actions
            • Unit - Cause GDoT_Caster[GDoT_Current] to damage GDoT_Target[GDoT_Current], dealing GDoT_DpS[GDoT_Current] damage of attack type GDoT_AttackType[GDoT_Current] and damage type GDoT_DamageType[GDoT_Current]
            • -------- --------
            • -------- on damage event --------
            • Set GDoTEvent_OnDamage = 1.00
            • Set GDoTEvent_Caster = GDoT_Caster[GDoT_Current]
            • Set GDoTEvent_Target = GDoT_Target[GDoT_Current]
            • Set GDoTEvent_DpS = GDoT_DpS[GDoT_Current]
            • Set GDoTEvent_OnDamage = 0.00
            • -------- --------
            • Set GDoT_HitAmount[GDoT_Current] = (GDoT_HitAmount[GDoT_Current] - 1)
            • Set GDoT_Freq[GDoT_Current] = 0.00
          • Else - Actions
            • Set GDoT_Freq[GDoT_Current] = (GDoT_Freq[GDoT_Current] + GDoT_INTERVAL)
        • -------- --------
      • Else - Actions
        • Set GDoTEvent_EndDoT = 1.00
        • Set GDoTEvent_Caster = GDoT_Caster[GDoT_Current]
        • Set GDoTEvent_Target = GDoT_Target[GDoT_Current]
        • Set GDoTEvent_DpS = GDoT_DpS[GDoT_Current]
        • Set GDoTEvent_EndDoT = 0.00
        • -------- --------
        • Set GDoT_Prev[GDoT_Next[GDoT_Current]] = GDoT_Prev[GDoT_Current]
        • Set GDoT_Next[GDoT_Prev[GDoT_Current]] = GDoT_Next[GDoT_Current]
        • -------- --------
        • Special Effect - Destroy GDoT_DmgFx[GDoT_Current]
        • Set GDoT_Caster[GDoT_Current] = No unit
        • Set GDoT_Target[GDoT_Current] = No unit
        • Set GDoT_Freq[GDoT_Current] = 1.00
        • Set GDoT_DmgFrequency[GDoT_Current] = 1.00
        • Set GDoT_HitAmount[GDoT_Current] = 0
        • Set GDoT_DpS[GDoT_Current] = 0.00
        • Set GDoT_AttackType[GDoT_Current] = Spells
        • Set GDoT_DamageType[GDoT_Current] = Normal
        • -------- --------
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • GDoT_Current Equal to GDoT_Index
          • Then - Actions
            • Set GDoT_Index = (GDoT_Index - 1)
          • Else - Actions
    • Set GDoT_Current = GDoT_Next[GDoT_Current]
    • -------- --------
    • Custom script: endloop
    • -------- --------
    • -------- pause/stop the timer when there's nothing on the list --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • GDoT_Index Equal to 0
      • Then - Actions
        • Countdown Timer - Pause GDoT_Iterator
      • Else - Actions
    • -------- --------
    • Custom script: endfunction
    • -------- --------
    • Custom script: function GDoTRegisterEx takes nothing returns nothing
    • -------- increase the instance by 1 --------
    • Set GDoT_Index = (GDoT_Index + 1)
    • -------- --------
    • -------- store everything we need... --------
    • Set GDoT_Caster[GDoT_Index] = GDoTRegister_Caster
    • Set GDoT_Target[GDoT_Index] = GDoTRegister_Target
    • -------- --------
    • Special Effect - Create a special effect attached to the GDoTRegister_FxAttachPoint of GDoTRegister_Target using GDoTRegister_DmgEffect
    • Set GDoT_DmgFx[GDoT_Index] = (Last created special effect)
    • -------- --------
    • Set GDoT_Freq[GDoT_Index] = GDoTRegister_DmgFrequency
    • Set GDoT_DmgFrequency[GDoT_Index] = GDoTRegister_DmgFrequency
    • -------- I use counter insteads duration for accurate damage. --------
    • Set GDoT_HitAmount[GDoT_Index] = (Integer((GDoTRegister_Duration / GDoTRegister_DmgFrequency)))
    • -------- --------
    • Set GDoT_DpS[GDoT_Index] = (GDoTRegister_TotalDamage / (Real(GDoT_HitAmount[GDoT_Index])))
    • Set GDoT_AttackType[GDoT_Index] = GDoTRegister_AttackType
    • Set GDoT_DamageType[GDoT_Index] = GDoTRegister_DamageType
    • -------- --------
    • -------- add the instance to the list --------
    • Set GDoT_Next[GDoT_Index] = 0
    • Set GDoT_Prev[GDoT_Index] = GDoT_Prev[0]
    • Set GDoT_Next[GDoT_Prev[0]] = GDoT_Index
    • Set GDoT_Prev[0] = GDoT_Index
    • -------- --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • GDoT_Index Equal to 1
      • Then - Actions
        • Custom script: call TimerStart(udg_GDoT_Iterator, udg_GDoT_INTERVAL, true, function GDoTOnIterate)
      • Else - Actions
    • Custom script: endfunction
    • -------- --------
    • Custom script: function GDoTRegister takes nothing returns nothing
    • -------- wrapper --------
    • -------- you can config these --------
    • Set GDoTRegister_FxAttachPoint = origin
    • Set GDoTRegister_DmgFrequency = 1.00
    • Set GDoTRegister_AttackType = Spells
    • Set GDoTRegister_DamageType = Normal
    • Set GDoT_UseWrapper = False
    • Custom script: call GDoTRegisterEx()

but still, I can't solve it. The GDoT_Index just keep increasing.
Can you help me

EDIT: Update: Solved!
can you check the code

 

[zv27]

For noobs like me,could you explain how to use this.

 

[Chaosy]

I feel like this could be done a lot easier.
With the use of local variables (or GUI shadowing) and a wait you can do this with a single function.
I estimate roughly 10 lines of code. And most of that code is local variable declaration.

Of course it would be a bit inaccurate, but still.

 

[Reventhous]

Actually, this system is a mistake. There's already ton of system of this kind out there and they are even better.
If you guys have some idea that can make this system acceptable as approved system, I gladly to hear it.
And, about events in my system, can you guys tell me if I did something wrong.

@zv27: This is a system that can apply a DoT (Damage over Time) easily. You can see the demo I just provided in the description.
Also, except damaging units, you can also do something periodically by using the event. Like, creating a pulse of missile on every 0.25 s.
I haven't try this yet, but I think with the onDamage and EndDoT event, user can make a easy MUI spell.

@Chaosy: I don't know what to say about that easy method. From my imagination , that method will just wait and damage target (with just one hit) like a timed bomb. Can you tell me why use wait. From what I know, waits is forbidden.


EDIT: Updated!:
-fixed indexing problem
-fixed some minor problems

 

[Chaosy]

In jass it would be something like:

function DoT takes real dmg, unit target, real interval, integer numberOfTicks return nothing
//^ I am pretty sure those are considered local
local integer i = 0
loop
exitwhen i == numberofTicks
call TriggerSleepAction(interval)
deal dmg damage to target
set i = i + 1
endloop
endfunction

Waits can be up to 0.27 seconds inaccurate (at least that's what I read somewhere) which is why they are not used most of the time. But if it can cut down the code size to a third.. I'd say it's a decent trade.

 

[Reventhous]

Ahh, now I understand. But still, my thought says using waits is not acceptable and I don't think that method can replace this kind of system as long as the accuration is the important thing in order to create a smooth and clean spell .
If there is 20 spell with DoT, 20 waits will loop.

And like you said waits is 0.27s inaccurate. I can't imagine a spell that requires high damage frequency.

 

[Chaosy]

I think there are some cases where waits are acceptable. Though they are few.
Still, even without a wait I think you could cut down your code in half at least.

This would be the loop:

every 0.03 seconds
pick every unit in myGroup
set u = picked unit
set h = handle of u
set count = load from hashtable with keys h 0 + 0.03
save count in hashtable with keys h and 0
set interval = load from hashtable with keys h 1
if count is greater or equal to interval
save 0 in hashtavle with keys h and 0
deal damage to u
set completedTicks = load from hashtable with keys h 2 + 1
save completedTicks in hashtable with keys h 2
if completedTicks is greater than or equal to load fro mhashtable with keys h 3
remove u from group, dot is finished
endif
endif

there are some lazy coding in that but the concept would be the same. Just move some stuff around for minimal bonus speed

 

[Reventhous]

I will try and I'll add some sample spells that uses GDoT and its events, it will be the last update, I think (on second thought, I think its better to remove this system from Hive), and can I ask. Which is faster, Index or Hashtable? I'm confused

 

[zv27]

I will try and I'll add some sample spells that uses GDoT and its events, it will be the last update, I think (on second thought, I think its better to remove this system from Hive), and can I ask. Which is faster, Index or Hashtable? I'm confused

There is no way that the human brain registers the difference in speed between the above,
but if you ask me,
1-0 in favor of the index in the first half of the match hahaha.
Of course a little humor does not hurt.
Now seriously, both the fine.
And one more thing. damage type fire = damage type magic no difference(
refers to your demo code)

 

[Reventhous]

That was just for example, it doesn't matter.
Btw, It may have some difference on later time, I don't know, maybe someone will make GetDamageType() exist.

 

[IcemanBo]

Hey.

My first point still stands. Submissions should bring something useful to the table.
We're not willing to approve same over same submissions to our data base.
Does your submissions have any benefits in comparison to the ones I linked? (probably only compare to other GUI ones)

 

[Reventhous]

(on second thought, I think its better to remove this system from Hive)

Can you make that happen.

Btw, I'm going to upload a GUI version of Rapid Sound system. It is a conversion from vJass RapidSound by Quilnez.
[vJASS] - [Snippet] RapidSound
Is there any system out there that is similiar as my upcoming system? I googled and I saw nothing.

 

[IcemanBo]

Why is your second thought to remove it? If you're sure we will just move it to Substandard section.
Though, I thought that you maybe want to compare and say why your DoT is better and could be used.

 

[Reventhous]

The only benefit is the implementation simpleness, and there's no way this small system can compete with [GUI] Effect Over Time System 2.3.1
and yes, please move it.

 

[IcemanBo]

Sometimes it makes sense to argue, because others, also mods, don't have time (and also make mistakes) to scan all codes and compare pros/cons.
But so now you seem sure and we can move it. Moved.