[Solved] Group Arrays

[GIMLI_2]

Hi,
very short question. Are group arrays fine? Or is there a better way to attach unit groups to a certain unit?

thanks

 

[Warseeker]

Yep as long as you put them seperatly.

is there a better way to attach unit groups to a certain unit?

You mean adding a unit to a specified group?

 

[SAUS]

Group arrays are fine, just note you will have to create the groups when units use them and that you need to make sure you don't create them more than once. I assume you are using unit indexing. It is also possible with hashtables.

 

[IcemanBo]

If multiple groups are really needed, so not only needed as temporary group, then it's fully okay.

 

[GIMLI_2]

i use a unit indexer. i just thought about 2 options:
option 1: having an array of unit groups
option 2: have 1 unit group and save the caster into a variable with the custom value of each target and then loop through the whole group and check each unit

Yep as long as you put them seperatly.

If multiple groups are really needed, so not only needed as temporary group, then it's fully okay.

okay thanks

 

[IcemanBo]

option 2: what if a target is affected by multiple spell instances?

 

[GIMLI_2]

option 2: what if a target is affected by multiple spell instances?

forgot to mention, he can only be affected by one at a time

 

[IcemanBo]

Ah, okay. Hm, if you are using unit indexer already, and can avoid group arrays with mentioned way,
then it will be a bit more performant probably. Because groups are a bit more heavy overall.. but if not then I would not think twice/doubt to use groups.

 

[GIMLI_2]

Ah, okay. Hm, if you are using unit indexer already, and can avoid group arrays with mentioned way,
then it will be a bit more performant probably. Because groups are a bit more heavy overall.. but if not then I would not think twice/doubt to use groups.

ok, thanks

solved

 

[GIMLI_2]

Ok, i have a new problem
if i loop through the group and check for the units attached to the caster, i cannot do it this way:

        loop
            set FoG = FirstOfGroup(g)
            exitwhen FoG == null
            call GroupRemoveUnit(g, FoG)
        endloop

because i dont want to remove units from the group that are not attached to the current caster. The loop would be infinite then. I thought about adding the "not fitting" units to a temp group and readd them to the main group after the loop, but that's probably not the best way
Is there another way to loop through a group?

 

[WereElf]

call ForGroup(g, function ....)
and then use GetEnumUnit() to get the "picked unit".

 

[IcemanBo]

It is the good way with using a temp group.

It's explained the last part of this tutorial: https://www.hiveworkshop.com/forums...on-using-first-group-loop-enumeration-223140/

 

[GIMLI_2]

It is the good way with using a temp group.

It's explained the last part of this tutorial: vJass Optimization: Using a First of Group Loop for Enumeration

okay, thanks!

call ForGroup(g, function ....)
and then use GetEnumUnit() to get the "picked unit".

i wouldnt have access to my local variables in the loop function

 

[Anitarf]

A linked list might be more appropriate than a group for what you're trying to do (looping through without emptying it with acces to local variables). It would however be more work to code, unless you are using vJass.

 

[SAUS]

You can also add those units to a separate group (typically referred to as a "swap" group) and swap the groups after the loop.

        loop
            set FoG = FirstOfGroup(g)
            exitwhen FoG == null
            call GroupRemoveUnit(g, FoG)
            call GroupAddUnit(g2, FoG)
        endloop

        set gTemp = g
        set g = g2
        set g2 = gTemp