[JASS] GetSpellTargetLoc() not working

[Hamza121]

i made a spell that will create a unit and make it face to where the spell target location is the problem is
this

GetSpellTargetLoc()

is not working
but when i make the unit face the GetSpellTargetLoc() the unit faces the middle of the map
the spell is an edited impale spell i removed the buffs and effects
and wrote some jass to get it to summon the unit after i cast the impale spell

 

[KILLCIDE]

If it faces the middle of the map, that means the returned location has coordinates (0.00, 0.00). This usually happens when the location is null.

If you are using an editing impale spell, I see no reason why that value should return null. Can you post the code and possibly a demo map so we can find the error?

 

[Hamza121]

here are the parts of the code that are changing where the unit is facing

function Spell_Actions takes nothing returns nothing
    local unit caster = GetTriggerUnit()
    local location loc = GetSpellTargetLoc()
    local unit Unit
    set Unit = CreateUnit(GetOwningPlayer(caster), 'h003', 0, 0, 0)
    call SetUnitFacingToFaceLocTimed(Unit, loc, 0.01)
    set Caster = null
    set Unit = null
    set loc = null
endfunction

 

[BloodSoul]

Are you, by any chance, using call TriggerSleepAction(x) before GetSpellTargetLoc()? If so, for some reason, GetSpellTargetLoc() loses its value after any trigger wait function.

 

[KILLCIDE]

Where are you registering the event?

 

[Hamza121]

btw iam using newgen WE
this is it
call TriggerRegisterAnyUnitEventBJ(Spell, EVENT_PLAYER_UNIT_SPELL_EFFECT)

 

[WaterKnight]

and wrote some jass to get it to summon the unit after i cast the impale spell

Are you by chance using the EVENT_PLAYER_UNIT_SPELL_ENDCAST or EVENT_PLAYER_UNIT_SPELL_FINISH event? which do not reserve the GetSpellTargetLoc() event response.

 

[Hamza121]

Are you by chance using the EVENT_PLAYER_UNIT_SPELL_ENDCAST or EVENT_PLAYER_UNIT_SPELL_FINISH event? which do not reserve the GetSpellTargetLoc() event response.

as i said iam using the EVENT_PLAYER_UNIT_SPELL_EFFECT event

 

[WaterKnight]

Yes, I am sorry, did not see that post before. I think otherwise it looks okay, you immediately save the event response and I doubt you do something complex as cancelling the ability on the cast event, which could cause peculiarities. Nor do I believe that 'Impale' does anything special regarding that. Can you provide a test map?

 

[Hamza121]

Yes, I am sorry, did not see that post before. I think otherwise it looks okay, you immediately save the event response and I doubt you do something complex as cancelling the ability on the cast event, which could cause peculiarities. Nor do I believe that 'Impale' does anything special regarding that. Can you provide a test map?

how can i pm you

 

[KILLCIDE]

@WaterKnight since he's a new user, moderators have to approve his post first xD

@Hamza121You can just attach the map as a file here. Also, try to not double post. I advise you read the rules before doing anything.

 

[Hamza121]

@KILLCIDE thanks ill not do that again

@WaterKnight
here's the full code that will summon the unit
[Java 5] function Shooting_Actions takes nothing returns nothing local unit Unit = G - Pastebin.com
and after a bit of testing when i change to event EVENT_PLAYER_UNIT_SPELL_CAST or CHANNEL or EFFECT it changes the face to the top right of the player (not the map)
but ENDCAST and FINISH make it face the middle

 

[KILLCIDE]

You can paste JASS / vJASS code onto here using [code=jass][/code].

 

[WaterKnight]

It works for me but you are moving the unit after issuing the facing directive. Facing is a timed unit command. It can be cancelled by various means. Why not just state the angle in the unit constructor? And the caster will face the target point anyway.

 

[Hamza121]

It works for me but you are moving the unit after issuing the facing directive. Facing is a timed unit command. It can be cancelled by various means. Why not just state the angle in the unit constructor? And the caster will face the target point anyway.

OHHH ya its because i was spawning it in 0,0 changing the facing then changing the location it should be changing the location then changing the facing thanks for helping me

btw i know that it faces the target point anyway but when there's a small change in the angle it wont change it

 

[Dr Super Good]

OHHH ya its because i was spawning it in 0,0 changing the facing then changing the location it should be changing the location then changing the facing thanks for helping me

Why not create the unit where you need it with the appropriate facing? I would imagine that being easier to code and more efficient.