[JASS] getlocal player advice

[ABM]

hi everyone,

is this trigger safe?

[Jass=]
function Trig_Building_ProgressBar takes nothing returns nothing
local texttag udg_LocalText
local unit building
local real visible
local integer A
set udg_LocalPlayer = GetTriggerPlayer()
set building = GetConstructingStructure()
if ( IsPlayerInForce(udg_LocalPlayer, udg_Team[1]) == true )
set A = 1
elseif ( IsPlayerInForce(udg_LocalPlayer, udg_Team[2]) == true )
set A = 2
elseif ( IsPlayerInForce(udg_LocalPlayer, udg_Team[3]) == true )
set A = 3
else
set A = 4
endif
if ( GetUnitTypeId(building) == 'h016' ) then
if ( IsPlayerInForce(GetLocalPlayer(), udg_Team[A]) == true ) then
set visible = 0
else
set visible = 100
endif
call CreateTextTagUnitBJ( udg_ProgressBar[7], GetConstructingStructure(), 0, 8.00, 100, 100, 100, visible )
set udg_LocalText = GetLastCreatedTextTag()
call PolledWait( 0.50 )
if ( IsUnitAliveBJ(building) == true ) then
call SetTextTagTextBJ( udg_LocalText, udg_ProgressBar[8], 8.00 )
else
call DestroyTextTagBJ( udg_LocalText )
return
endif
call PolledWait( 0.50 )
call DestroyTextTagBJ( udg_LocalText )
endif
endfunction

//===========================================================================
function InitTrig_Building_ProgressBar_Copy takes nothing returns nothing
set gg_trg_Building_ProgressBar_Copy = CreateTrigger( )
call TriggerRegisterAnyUnitEventBJ( gg_trg_Building_ProgressBar_Copy, EVENT_PLAYER_UNIT_CONSTRUCT_START )
call TriggerAddAction( gg_trg_Building_ProgressBar_Copy, function Trig_Building_ProgressBar )
endfunction[/code]

i need the texttag to show only for team mate of player constructing the structure

 

[Starquizer]

Take this 2 links to help you more:

link1
link2

 

[ABM]

well i allready have check these two tutorials,
but usually they talk about 1 player, not a group of player using getlocalplayer...
i think the way i did it is ok.
but i rather ask for confirmation from more experienced player.

 

[Starquizer]

kLoader is the best answer.

Problem is that I have not tested every case that can cause desync (sorry about that) but you can get the confirmation you need from kLoader.

In Case you don't know what is kLoader

Its a program that allow you to run multiple WC3 instance at the same time, so you can use LAN games and add yourself as another human player to test desync

 

[Chaosy]

GetLocalPlayer with many players is no problem at all, you just list the users you want to use it should work just as if it was 1 player. If you want proof you can use this tutorial

http://www.hiveworkshop.com/forums/...multiple-warcraft-3-running-single-pc-226287/

 

[ABM]

thanks Chaosy and Starquizer