[JASS] Function not working properly

[Antares]

Hello,

I have just recently learned JASS and wanted to make a function that calculates an angle with an arcustangent function. this is the function:

function arcustangent takes real G, real A returns real
    if ( A < 0 ) then
        return AtanBJ( G / A ) + 180
        elseif ( A == 0 ) then
            if ( G > 0 ) then
                return AtanBJ( G / ( A + 0.01 ) )
            else
                return AtanBJ( G / ( A - 0.01 ) )
            endif
        else
        return AtanBJ( G / A )
        endif                
endfunction

later in the script, the variable declaration and function call:

function fastcalculation takes nothing returns nothing
...
...     
    local real A
    local real G
...
...
        set G = ScalarSpeedFrontVtF - ScalarSpeedVertBack
        set A = ScalarSpeedFrontPtF - ScalarSpeedParaBack
        set udg_ScalarMA[i] = arcustangent( G, A )

The values for G and A (Adjacent and Opposite) are not being handled by the arcustangent function. i just substituted the equation with set G = 5 and set A = 1, to see if this is the problem, but it didnt change anything. So the equation is NOT the problem. the function always returns zero (as the arcustangent of zero is zero).

Im completly new to JASS, so i dont know if I made any syntax errors. Jasscraft and the World Editor did not spit out any errors.

 

[Dr Super Good]

What is a arcustangent?

There is no return for if there is a value of A less than 0.

 

[Antares]

What is a arcustangent?

seems to be arctangent called in english.

There is no return for if there is a value of A less than 0.

i clipped an else while copying the script to the forum. fixed it now. that cant be the problem.

 

[Mooglefrooglian]

Use Atan2(y, x). Exact same. Its a built in function too, so it has some speed.

At least, as far as i can tell, that's what you're trying to do.

 

[Antares]

It works now. I dont know why, but it works.

Use Atan2(y, x). Exact same. Its a built in function too, so it has some speed.

If its faster, ill use it. Thx.

 

[Mooglefrooglian]

It works by putting the angle in the correct quadrant. Also, it requires radians, and you were using AtanBJ which uses degrees. Could be why yours wasnt working.

 

[PurplePoot]

It works by putting the angle in the correct quadrant. Also, it requires radians, and you were using AtanBJ which uses degrees. Could be why yours wasnt working.

I assume he realizes this seeing as he is returning +180 in some cases.

Keep in mind the parameters for Atan(2)(BJ) are not angles.