Fire Form

[Moderator]

12th Dec 2015
IcemanBo: Too long time as NeedsFix. Rejected.

16:05, 4th Mar 2011
Bribe:

call SelectUnit(obj.caster, true)

You know this will select that unit for every single player?

Your indentation is terrible and KeyTimers2 is worse. casterObject? Just name it Data and save everyone file size in their map.

This is highly lacking. It doesn't do anything unique.

00.03 -> this is just silly formatting. 00 is usually an "octal" (base 8) indicator and throws off the readability. Just run it off of Timer32, or even a struct-timer-loop, it's much faster.

Status: Rejected until update

 

[Cihparg]

I've seen this somewhere...
Just don't remember where.

Also, vJass is damn unnecessary for a easy spell like this.
Also this lacks eye-candy.

I can't help but rate this 1/5.
Also vote for rejection.

 

[iAyanami]

I've seen this somewhere...
Just don't remember where.

DotA Storm Spirit's ultimate? If you read the description, you would have known.

Also, vJass is damn unnecessary for a easy spell like this.

Nope. vJASS is much more efficient than GUI. This trigger involves periodic functions, which I find it enough of a reason to use vJASS.

I can't help but rate this 1/5.
Also vote for rejection.

Just because it's in vJASS?

And here begins the commenting:

    globals
    
    private constant integer    SPELL_ID    =   'A000'
    private constant integer    DUMMY_ID    =   'h000'
        
        // OFFSET is distance travelled per cycle
        // KT_PERIOD is the period you use for KT_Add
        //Manaperunit is the mana per unit moved.
        private constant real       OFFSET      =   20
        private constant real       KT_PERIOD   =   00.03
        private constant real       Manaperunit = .25
        
    endglobals

I realized you like to do this. The code isn't inline. Looks kind of disturbing. Make it like:

    globals
    
        private constant integer    SPELL_ID    =   'A000'
        private constant integer    DUMMY_ID    =   'h000'
        
        // OFFSET is distance travelled per cycle
        // KT_PERIOD is the period you use for KT_Add
        //Manaperunit is the mana per unit moved.
        private constant real       OFFSET      =   20
        private constant real       KT_PERIOD   =   00.03
        private constant real       Manaperunit = .25
        
    endglobals

Something like this.

private struct casterObject
    
unit caster
    unit dummy
        
real offsetX
real offsetY
    real direction
        
    real distDelta
    real distTarget
        
endstruct

Again, similar story as the above post.

// do practice indenting and leaving lines/spaces when necessary, just for the readability
private function onInit takes nothing returns nothing
    local trigger t = CreateTrigger()

    call TriggerRegisterAnyUnitEventBJ(t,EVENT_PLAYER_UNIT_SPELL_EFFECT)
    call TriggerAddCondition(t,Condition(function onEffect))
endfunction

    private function onEffect takes nothing returns boolean
        local casterObject  obj     =   casterObject(0) // not necessary, could just do local casterObject obj
        local real          x       =   0  // do not need
        local real          y       =   0  // to initialize these
        local real          angle   =   0 // values
        local boolean       cond    =   (GetSpellAbilityId() == SPELL_ID) // eliminate this to use 1 less variable
        
        if cond then // directly use GetSpellAbilityId() == SPELL_ID here
        
            // 1. Prepare the needed data.
            set x               =   GetUnitX(GetTriggerUnit()) // set triggering unit 
            set y               =   GetUnitY(GetTriggerUnit()) // to a variable
            set angle           =   Atan2(GetSpellTargetY() - y, GetSpellTargetX() - x)
            // Atan2 returns angle in radians, no conversion required.
            
            // 2. Instantiate.
            set obj             =   casterObject.create() // do this first, so that you can refer the triggering unit as obj.caster
            
            set obj.caster      =   GetTriggerUnit()
            set obj.dummy       =   CreateUnit(GetOwningPlayer(obj.caster), DUMMY_ID, x, y, angle*bj_RADTODEG)
            // angle*bj_RADTODEG makes the dummy looks toward the cast point.
            
            // 3. Determine the offsets of both x and y coordinates.
            // The angle is constant so the offset increase per iteration
            // will be constant.
            set obj.offsetX     =   OFFSET*Cos(angle)
            set obj.offsetY     =   OFFSET*Sin(angle)
            
            set x               =   GetSpellTargetX() - x
            set y               =   GetSpellTargetY() - y
            
            // 4. Determine the required distance to traverse. Store the
            //    distance travelled.
            set obj.distDelta   =   0
            set obj.distTarget  =   SquareRoot(x*x+y*y)
            
            // you could use a static if here to enable or disable this
            // ============= Debug messages ============
            debug call BJDebugMsg("====================")
            debug call BJDebugMsg("caster:"+GetUnitName(obj.caster))
            debug call BJDebugMsg("dummy:"+GetUnitName(obj.dummy))
            debug call BJDebugMsg("x offset:"+R2S(obj.offsetX))
            debug call BJDebugMsg("y offset:"+R2S(obj.offsetY))
            debug call BJDebugMsg("distance delta:"+R2S(obj.distDelta))
            debug call BJDebugMsg("distance required:"+R2S(obj.distTarget))
            debug call BJDebugMsg("====================")
            // =========================================
            
            // 5. Hide the casting unit.
            call ShowUnit(obj.caster, false)
            call PauseUnit(obj.dummy, true)
            call KT_Add(function userFunc, obj, KT_PERIOD)
            
        endif
        
        return false
    endfunction

private function userFunc takes nothing returns boolean
        local casterObject  obj     =   casterObject(KT_GetData()) // wouldn't it be simpler to just do local casterObject obj = KT_GetData()

I think that's all. However, it can still definitely be improved. For example, use methods instead of function. And use T32 instead of KT. You could also use allocate() and deallocate() directly.

 

[Cihparg]

DotA Storm Spirit's ultimate? If you read the description, you would have known.

First of all, I don't play DotA.
I'm pretty sure I've seen this spell suploaded earlier to somewhere, but can't remember where.

Nope. vJASS is much more efficient than GUI. This trigger involves periodic functions, which I find it enough of a reason to use vJASS.

I were referring for Jass, though.
This is extremely easy to be done in either GUI or Jass.
vJass is less efficient than Jass and you know the reason.
vJass is for those who are lazy enough to not write the whole code by themself, or research the jass libraries granted by Blizzard.

As you probably have seen most of vJass things are rip-offs of other peoples, there is not much done by the "creator" infact.

Just because it's in vJASS?

Nope.
Because this~ Bleh I already explained that.

Also, vJass is damn unnecessary for a easy spell like this.
Also this lacks eye-candy.

 

[Lambdadelta]

^ Really now people?

Anyways, the spell is indeed lacking.

• There is no learn tooltip for the ability.
• The ability has only one level. Examples should have three, just some unwritten standard to keep be consistent with default hero abilities.
• The ability is in the wrong button position. It should be in (0,2). Once again for keeping to convention.

• The spell has no transition to the fire form. It's instant. It's exceedingly awkward to just see Blood Mage -> Some red fireball.
• Does the ability even damage the enemies? I can't find the part of code that does.

• Debugging code shouldn't be left in the public release, we don't need to see remnants of your debugging.
• <Insert more code comments>

 

[illegalpie]

In a later version I will add damage, but for now, its not included.

No damage right now, I'll fix the other things, As for the no transition, I might be able to make an inferno of some sort, or make the hero run forward a bit at 522 speed or something, I'll remove the Debugging also.

 

[illegalpie]

First of all, I don't play DotA.
I'm pretty sure I've seen this spell suploaded earlier to somewhere, but can't remember where.

I were referring for Jass, though.
This is extremely easy to be done in either GUI or Jass.
vJass is less efficient than Jass and you know the reason.
vJass is for those who are lazy enough to not write the whole code by themself, or research the jass libraries granted by Blizzard.

Can JASS do this all in one trigger?

Didn't think so.

As you probably have seen most of vJass things are rip-offs of other peoples, there is not much done by the "creator" infact.


Nope.
Because this~ Bleh I already explained that.

Go troll elsewhere.

And by the way, This is my first spell, ever. Thanks for being an asshole and voting 1/5.

 

[Cihparg]

Yes, Jass can do this in one trigger.
vJass wouldn't be possible if there wasn't Jass, and I'm not trolling.
To be honest, I'm not even ~close to trolling and you should behave a ~lot better or I'll make sure you will get reported, just a friendly notice.

You should've learnt more pure Jass instead of vJass.

EDIT: Quotes are used to QUOTE other people, not to edit what they've wrote.
EDIT 2: Oh yes, I already forgot where you can learn to be a Hiver.
This you can learn from here.

 

[iAyanami]

Yes, Jass can do this in one trigger.
vJass wouldn't be possible if there wasn't Jass, and I'm not trolling.
To be honest, I'm not even ~close to trolling and you should behave a ~lot better or I'll make sure you will get reported, just a friendly notice.

You should've learnt more pure Jass instead of vJass.

EDIT: Quotes are used to QUOTE other people, not to edit what they've wrote.
EDIT 2: Oh yes, I already forgot where you can learn to be a Hiver.
This you can learn from here.

Yes, vJASS is JASS. All vJASS scripts will be converted to JASS after being compiled. However, that's not a valid reason to criticize other people's work.

vJASS is basically, you could say, a system, which includes more features than your plain JASS. Of course, you could use these features in JASS, except you would need to re-write them from scratch. Since a lot of the systems out there uses vJASS, I don't see why vJASS is bad, even if it could be coded in JASS. Then why don't you go ahead and criticize all spells and systems that were made in vJASS, because really, they could have been made in plain JASS.

And seriously, lets stick to commenting the codes and the spell itself rather than arguing over if it's JASS or vJASS.

 

[Cihparg]

If there was something to discuss about this useless Spell, then perhaps.
If it had even a single bit of what is mentioned above it could be called a Spell, now it is just a useless Spell.

Also I do not critisize anything more than what I should. Also discussing about how vJass is more usefull than the other scripting methods is useless~ As you already pointed out that vJass = Jass, but just done in a few functions instead of thousands.

Speaking of vJass, Jass and GUI differences, faults and other is like speaking of what religion is a lie, does God exist or does he not, is there a soul or is there not~ One thing goes for all of them; Something is a lie and it will not be discovered by humankind as long the subject is kept on the lie-side.

And there the subject changes once again, I will state this my last argument to this thread
Also if we are just to reply each others replies we can do that on either Visitor Messages or Private Messages.

Final statement about this spell;;
Useless piece of nothing~ Improve it 95% and we'll call it a spell.

 

[illegalpie]

Then why are you here? Just leave, we don't want you here if you're just going to criticize, besides, theres an unlimited world of improvement for it.

 

[chobibo]

off-topic: illegalpie are you NeuroToxin from theHelper.net?

No offense illegalpie, but you have to complete the spells first before you submit them lol. Good luck dude, hope you don't lose hope.

@iAyanami
I initialized it because I didn't know where it was supposed to be used. Also the b boolean was supposed to be used with another condition. The indent is fucked up because of the text editor I was using. I fixed that but I guess he wasn't able to se the updated script I posted.