Bat Form v1.3

[Moderator]

16:17, 3rd Aug 2012
Magtheridon96: Okay, there aren't any major problems at this point.
I'll still leave the Indexing tip in this review in case you want to update it to use a better form of indexing.

Still, good job.

Indexing tip

Your indexing is pretty much the same way I do indexing in vJass, but the iteration isn't as good as it could be. There are cases in which you'd be iterating over dead instances when you don't need to.
Try using a stack instead. All you need is one variable to store the number of running instances and arrays for all your data. (And another integer to use in the For each loop)
Allocation is done by incrementing the integer simply.
Deallocation is done like this:

set data1[currentInstanceInLoop] = data1[instancesRunningCount]
set data2[currentInstanceInLoop] = data2[instancesRunningCount]
etc...
set currentInstanceInLoop = currentInstanceInLoop - 1
set instancesRunningCount = instancesRunningCount - 1

 

[Marsal]

Upcoming changes today:
-Damage increase and damage reduction depending on how many targets are hit.
-Effects (moaaaar eyecandy)
-Sound changes

 

[mckill2009]

The hero launches towards the target point...

no it doesnt, it travels towards the edge of the map at that angle, which causes bugs, the picture below shows the hero cant get out of the shaded area...

EDIT:
In any case, the spell looks great so Im rating it 4/5 unless changes made...

 

[Marsal]

I thought I fixed this :/ I'll update with a fix asap.

 

[defskull]

I thought you went over the deadline, hmmm.
So this spell does not support cooldown since you use the method Add/Remove Ability ?

 

[Marsal]

I don't really know what is the deadline ~.~

Forgot about this, I thought it will act like items with abilities, if you drop it and pick it up again it will still have a cooldown. I could fix that by using a different method but from what you said I guess I'm out of the deadline :/

 

[defskull]

The deadline was August 2nd.
Well, rules are rules dude :/

You also signed the contract to obey the rules.

 

[Marsal]

Don't be a douche... I didn't know what the deadline is since I wasn't there.. Anyway this is just a spell, it took really nothing but 2-3 hours. It's not the world.

 

[iChaos]

----------------------------------------------------------------------

As you can see in the image, there is 2 heroes. But when I used the skill, it went over the border, and left the other hero. I tried it with the other one, but I didn't work. So only 1 hero left.

 

[Marsal]

Hmm... It shouldn't do this. In fact it's nearly impossible :/ Anyway, I'll try to fix these things after the spell is judged.