Fiery Spellpack 1.01a

[Moderator]

Fiery Spellpack 1.01a | Reviewed by Maker | 13th May 2013

NEEDS FIX

There are tons of leaks The spells are quite simple and spam effects I recommend you improve your triggering skills a bit and then try your luck in getting spells approved then Things that leak Hashtables and MUI Dynamic indexing Spell Submission Rules

[tr]

 

[Tank-Commander]

loop should be 0.03 not 0.01 periodic timer

Your sfx is inefficiently done, you only need two locations and a loop to create all of those effects.

This is rather basic and severely sfx spammy over uniqueness and originality, not sure how good the chances of being approved are, and if then, having a high rating of any sort

(very quick initial notes)

Edit:

• ((Picked unit) belongs to an enemy of Player 12 (Brown)) Equal to True

Why them? shouldn't it be based on the owner of the caster

Hells stomp is an object editor spell coated up in sfx spam, not exactly what I'd call approvable material

You have no configuration for any of your spells, anywhere

• Set TAmountMax = 696969
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • TAmount Greater than TAmountMax
  • Then - Actions
    • Set TAmount = 1
  • Else - Actions

Inefficient recycling, use a hashtable or learn how to dynamically index instances

 

[Almia]

He don't know what the max index is. The max array index is 8192. Your indexing method has very weak recycling.
Please view these resources:
http://www.hiveworkshop.com/forums/spells-569/gui-dynamic-indexing-template-144325/?prev=mmr=6
http://www.hiveworkshop.com/forums/...9/complete-beginners-guide-hashtables-197381/
http://www.hiveworkshop.com/forums/trigger-gui-editor-tutorials-279/hashtables-mui-133407/
http://www.hiveworkshop.com/forums/...279/mui-spells-using-artificial-waits-223315/
http://www.hiveworkshop.com/forums/trigger-gui-editor-tutorials-279/mui-triggers-waits-218354/

to have a much efficient indexing/MUI.

variables must have prefixes.
Spells must have configuration trigger.

You have tons of leaks
Please read this:
http://www.hiveworkshop.com/forums/triggers-scripts-269/things-leak-35124/

For HSExecute,you should learn to use For Loop Integer,it will make your code shorter. Read this:
http://www.hiveworkshop.com/forums/...torials-279/chapter-1-static-shapes-gui-7337/
http://www.hiveworkshop.com/forums/...rials-279/chapter-2-dynamic-effects-gui-7336/

0.01 loop is very very fast. We recommend 0.03 as minimum value and 0.05 as max value. 100 frames is too much.

Spell is not MUI.

Use Triggering Unit instead of Casting,but that is optional.

Spells are too simple to be approved.

 

[DSanhueza]

Thanks this is actually what I was looking for when I uploaded the spell, I need to work these things out! Everything will be fixed on the next update.

 

[zv27]

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• ((Picked unit) belongs to an enemy of "Player 12 (Brown)") Equal to True

should be

TriggeringPlayer

• Set HSPoints[1] = ((Position of (Casting unit)) offset by (Real(HSAoe)) towards 0.00 degrees)
• Set HSPoints[2] = ((Position of (Casting unit)) offset by (Real(HSAoe)) towards 45.00 degrees)
• Set HSPoints[3] = ((Position of (Casting unit)) offset by (Real(HSAoe)) towards 90.00 degrees)
• Set HSPoints[4] = ((Position of (Casting unit)) offset by (Real(HSAoe)) towards 135.00 degrees)
• Set HSPoints[5] = ((Position of (Casting unit)) offset by (Real(HSAoe)) towards 180.00 degrees)
• Set HSPoints[6] = ((Position of (Casting unit)) offset by (Real(HSAoe)) towards 225.00 degrees)
• Set HSPoints[7] = ((Position of (Casting unit)) offset by (Real(HSAoe)) towards 270.00 degrees)
• Set HSPoints[8] = ((Position of (Casting unit)) offset by (Real(HSAoe)) towards 315.00 degrees)

Example

• Set HSExampleLoc = Position of (Triggering unit)
• Set HSPoints[1] = ((HSExampleLoc) offset by (Real(HSAoe)) towards 0.00 degrees)
• // and so on

This is very ugly, but it does not matter...

• Special Effect - Create a special effect at HSPoints[1] using Abilities\Spells\Other\Doom\DoomDeath.mdl
• Special Effect - Destroy (Last created special effect)
• Special Effect - Create a special effect at HSPoints[2] using Abilities\Spells\Other\Doom\DoomDeath.mdl
• Special Effect - Destroy (Last created special effect)
• Special Effect - Create a special effect at HSPoints[3] using Abilities\Spells\Other\Doom\DoomDeath.mdl
• Special Effect - Destroy (Last created special effect)
• Special Effect - Create a special effect at HSPoints[4] using Abilities\Spells\Other\Doom\DoomDeath.mdl
• Special Effect - Destroy (Last created special effect)
• Special Effect - Create a special effect at HSPoints[5] using Abilities\Spells\Other\Doom\DoomDeath.mdl
• Special Effect - Destroy (Last created special effect)
• Special Effect - Create a special effect at HSPoints[6] using Abilities\Spells\Other\Doom\DoomDeath.mdl
• Special Effect - Destroy (Last created special effect)
• Special Effect - Create a special effect at HSPoints[7] using Abilities\Spells\Other\Doom\DoomDeath.mdl
• Special Effect - Destroy (Last created special effect)
• Special Effect - Create a special effect at HSPoints[8] using Abilities\Spells\Other\Doom\DoomDeath.mdl
• Special Effect - Destroy (Last created special effect)

->

• Set HSExampleStringFX = Abilities\Spells\Other\Doom\DoomDeath.mdl
• Special Effect - Create a special effect at HSPoints[1] using HSExampleStringFX
• // and so on

• Custom script: call RemoveLocation (udg_HSPoints[1])
• Custom script: call RemoveLocation (udg_HSPoints[2])
• Custom script: call RemoveLocation (udg_HSPoints[3])
• Custom script: call RemoveLocation (udg_HSPoints[4])
• Custom script: call RemoveLocation (udg_HSPoints[5])
• Custom script: call RemoveLocation (udg_HSPoints[6])
• Custom script: call RemoveLocation (udg_HSPoints[7])
• Custom script: call RemoveLocation (udg_HSPoints[8])

so many locations are definitely sucks but when it is already so...this is a better solution
[learn to use the coordinates]
->

• Set HSExampleSomeIntegerName = 8
• loop
  • exitwhen udg_HSExampleSomeIntegerName == 0
  • call RemoveLocation (udg_HSPoints[udg_HSExampleSomeIntegerName])
  • Set HSExampleSomeIntegerName = HSExampleSomeIntegerName - 1
• endloop