Fiery Rock v 1.2a

[Moderator]

22:13, 21st Jul 2012
Magtheridon96: Approved.

This is a pretty good spell, and although the idea is not something that blows my mind, it's still something you don't see everyday.

 

[maddeem]

endexing. The new way to index.
make Level of Hit for FR_Caster[FR_integer] into a variable, as you refer to it like 4 times.
this (FR_Caster_Pos offset by FR_Real_CastRange[FR_integer] towards (Facing of FR_Caster[FR_integer]) degrees) leaks once
offsetting a location creates a new location

 

[Magtheridon96]

Instead of setting the group outside of the if statement, set it inside the else block because you don't need it inside the 'Then' block. You can do the same for Caster_Pos and dummy_loc.
But note: you would have to destroy them in the same block that you are creating them, so move their respective "DestroyGroup" and "RemoveLocation" calls to the else block.

Also, you should cache (Real((Level of Hit for FR_Caster[FR_integer])))

And this leaks:
Unit - Create 1 dummy for (Owner of FR_Caster[FR_integer]) at (FR_Caster_Pos offset by FR_Real_CastRange[FR_integer] towards (Facing of FR_Caster[FR_integer]) degrees) facing Default building facing degrees

You should store the location in a variable and remove it.


Excellent indexing by the way.

 

[eubz]

There you go, spell updated.

 

[Magtheridon96]

In the cast trigger, you don't need dummy_loc, use DummyCreatorPos.
They will point to the same location.

Also:

Trigger

• Set FR_Caster_Pos = (Position of FR_Caster[FR_integer])
• Set FR_dummy_loc = (Position of FR_dummy[FR_integer])

and

• Custom script: call RemoveLocation(udg_FR_Caster_Pos)
• Custom script: call RemoveLocation(udg_FR_dummy_loc)

should be moved to the Else block since you have no use for them if "Then" actions are executed.

 

[eubz]

Spell fixed. Updated again.

 

[Magtheridon96]

• Set FR_Caster_Pos = (Position of FR_Caster[FR_integer])
• Set FR_dummy_loc = (Position of FR_dummy[FR_integer])

Those are still not in the Else block ._.

 

[eubz]

Which else action, here?

?

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• FR_size Equal to 0
• Then - Actions
• Trigger - Turn off (This trigger)
• Else - Actions

Or here?

?

• Else - Actions
• Set FR_Real_Time[FR_integer] = (FR_Real_Time[FR_integer] - 1.00)
• Set FR_TargetGroup = (Units within FR_AoE_Real[FR_integer] of FR_dummy_loc matching ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) is Magic Immune) Equal to False) and ((((Matching unit) is alive) Equal to True) and (((Matching unit) belongs to an enemy
• Unit Group - Pick every unit in FR_TargetGroup and do (Actions)
• Loop - Actions
• Set FR_Target_u[FR_integer] = (Picked unit)
• Unit - Cause FR_Caster[FR_integer] to damage FR_Target_u[FR_integer], dealing FR_Real_Damage[FR_integer] damage of attack type Spells and damage type Normal
• Special Effect - Create a special effect attached to the FR_Target_SEff_Attachment of (Picked unit) using FR_Target_SEff
• Special Effect - Destroy (Last created special effect)
• -------- clearing up leaks --------
• Custom script: call DestroyGroup(udg_FR_TargetGroup)
• Custom script: call RemoveLocation(udg_FR_Caster_Pos)
• Custom script: call RemoveLocation(udg_FR_dummy_loc)

 

[Magtheridon96]

The second one

 

[eubz]

then, the two are already inside the else actions.

incorrect trigger

• Else - Actions
  • Set FR_Real_Time[FR_integer] = (FR_Real_Time[FR_integer] - 1.00)
  • Set FR_TargetGroup = (Units within FR_AoE_Real[FR_integer] of FR_dummy_loc matching ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) is Magic Immune) Equal to False) and ((((Matching unit) is alive) Equal to True) and (((Matching unit) belongs to an enemy
  • Unit Group - Pick every unit in FR_TargetGroup and do (Actions)
    • Loop - Actions
      • Set FR_Target_u[FR_integer] = (Picked unit)
      • Unit - Cause FR_Caster[FR_integer] to damage FR_Target_u[FR_integer], dealing FR_Real_Damage[FR_integer] damage of attack type Spells and damage type Normal
      • Special Effect - Create a special effect attached to the FR_Target_SEff_Attachment of (Picked unit) using FR_Target_SEff
      • Special Effect - Destroy (Last created special effect)
  • -------- clearing up leaks --------
  • Custom script: call DestroyGroup(udg_FR_TargetGroup)
  • Custom script: call RemoveLocation(udg_FR_Caster_Pos)
  • Custom script: call RemoveLocation(udg_FR_dummy_loc)
  • -------- ====================================================== -------

Clearing up leaks is now under the Unit Group action, after its loop actions.
EDIT:
Oops, sorry mag, I haven't figured out. editing the spell again.
thanks.

 

[Magtheridon96]

This is how it should be:

Le Trigger

• FR Duration
  • Events
    • Time - Every 1.00 seconds of game time
  • Conditions
  • Actions
    • -------- ====================================================== --------
    • -------- DO NOT TRY TO CONFIGURE ANYTHING BELOW --------
    • For each (Integer FR_loop) from 1 to FR_size, do (Actions)
      • Loop - Actions
        • Set FR_integer = FR_index[FR_loop]
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • FR_Real_Time[FR_integer] Equal to 0.00
          • Then - Actions
            • Special Effect - Destroy FR_SEffect_1[FR_integer]
            • Special Effect - Destroy FR_SEffect_2[FR_integer]
            • Special Effect - Destroy FR_SEffect_3[FR_integer]
            • Unit - Kill FR_dummy[FR_integer]
            • Unit - Remove FR_dummy[FR_integer] from the game
            • Set FR_index[FR_loop] = FR_index[FR_size]
            • Set FR_index[FR_size] = FR_integer
            • Set FR_size = (FR_size - 1)
            • Set FR_loop = (FR_loop - 1)
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • FR_size Equal to 0
              • Then - Actions
                • Trigger - Turn off (This trigger)
              • Else - Actions
          • Else - Actions
            • Set FR_Real_Time[FR_integer] = (FR_Real_Time[FR_integer] - 1.00)
            • Set FR_Caster_Pos = (Position of FR_Caster[FR_integer])
            • Set FR_dummy_loc = (Position of FR_dummy[FR_integer])
            • Set FR_TargetGroup = (Units within FR_AoE_Real[FR_integer] of FR_dummy_loc matching ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) is Magic Immune) Equal to False) and ((((Matching unit) is alive) Equal to True) and (((Matching unit) belongs to an enemy
            • Unit Group - Pick every unit in FR_TargetGroup and do (Actions)
              • Loop - Actions
                • Set FR_Target_u[FR_integer] = (Picked unit)
                • Unit - Cause FR_Caster[FR_integer] to damage FR_Target_u[FR_integer], dealing FR_Real_Damage[FR_integer] damage of attack type Spells and damage type Normal
                • Special Effect - Create a special effect attached to the FR_Target_SEff_Attachment of (Picked unit) using FR_Target_SEff
                • Special Effect - Destroy (Last created special effect)
            • -------- clearing up leaks --------
            • Custom script: call DestroyGroup(udg_FR_TargetGroup)
            • Custom script: call RemoveLocation(udg_FR_Caster_Pos)
            • Custom script: call RemoveLocation(udg_FR_dummy_loc)
            • -------- ====================================================== -------

Because currently, if the "Then" actions are executed, this leaks.

 

[eubz]

There you go. I hope I am now correct.