Electric Walls v1.2

[Moderator]

15:30, 23rd Aug 2013
PurgeandFire: Approved and recommended. An cool-looking, lightning-tastic spell.

 

[Adiktuz]

So this casts chain lightnings to enemies that go near?

 

[Tank-Commander]

Since it selects targets in a cirular AOE, I kind of fail to see the point of having it as a wall of lightning, it may as well be a mana burn sphere effect and save all the lightning creations and those lightning orbs - they don't do anything. you'd cut the code in well over half and nothing would really change.

I know you move an orb across the "wall" but you only need one of those, don't need all the others and argueably not that either, also object editor damage really isn't good. I think half of the code could've been put to better use with creating an actual "lazer" for the "wall" rather than creating some redundant effects which may have a good feel, but don't actually reprisent anything (incidentally I think the name "lightning lazer" is unfitting for this spell in it's current state)

 

[Adiktuz]

^

I see... maybe I'll do something like this with my Lightning system, it's pretty simple to do this with that... XD...

 

[DivineLight]

nice
agree with Tank-Commander..
btw Tank-Commander, it's laser not lazer

 

[nhocklanhox6]

Well, thanks tank about your suggestion but i writed lightning laser, i don't write lightning lazer, please look carefully.

 

[DivineLight]

but i agree with tank, I think the name "lightning laser" is unfitting for this spell.. why don't "lightning wall" or "electric wall"? because this spell doesn't looks like a laser :\
btw cool spell
4/5

 

[nhocklanhox6]

oh, i don't have ability to set a true name, i'm so stupid ;((

 

[Tank-Commander]

Well, thanks tank about your suggestion but i writed lightning laser, i don't write lightning lazer, please look carefully.

well I would correct my spelling to laser (because lazer isn't actually a word and it's just one of those spellings I always slip up on) doesn't exactly change my comment nor is the "difference" between lazer and laser pertinant to my point. Of course, it's your spell and you can do what you like with it, though the point remains.

 

[DivineLight]

oh, i don't have ability to set a true name, i'm so stupid ;((

what do you mean?

 

[nhocklanhox6]

well I would correct my spelling to laser (because lazer isn't actually a word and it's just one of those spellings I always slip up on) doesn't exactly change my comment nor is the "difference" between lazer and laser pertinant to my point. Of course, it's your spell and you can do what you like with it, though the point remains.

Well, i see i'm was wrong, i'm sorry so much, Tank , please forgive me T.T!.

 

[DivineLight]

woah, you're using my suggestion
i feel honored xD

 

[PurgeandFire]

Review:

• In the method onCast, you have this:
  

  set x = tarx + 0 * Cos(0.01747)
  set y = tary + 0 * Sin(0.01747)

  0 * n = 0, so it can be simplified to:
  

  set x = tarx 
  set y = tary

  You can actually just remove the local variables "x" and "y" and use "tarx" and "tary" instead.
• In the method onCast, these lines:
  

  set o = tarx + ORB_COLUMN * Cos((f+ORB_ANGLE)*0.01747)
  set z = tary + ORB_COLUMN * Sin((f+ORB_ANGLE)*0.01747)

  Can be precalculated since all of it is constant. Just put it below the declarations of tarx and tary:
  

  local real tarx = GetSpellTargetX()
  local real tary = GetSpellTargetY()
  local real o = tarx + ORB_COLUMN * Cos((f+ORB_ANGLE)*0.01747)
  local real z = tary + ORB_COLUMN * Sin((f+ORB_ANGLE)*0.01747)

• In the method onCast, you should set u = null.
• In the method onPeriodic, you can precalculate some more calculations. Check out these lines:
  

                  if not fade then
                      set x = GetUnitX(dummy.unit[i]) + ORB_LASER_SPEED * Cos(facing*0.01747)
                      set y = GetUnitY(dummy.unit[i]) + ORB_LASER_SPEED * Sin(facing*0.01747)
                      call SetUnitPosition(dummy.unit[i],x,y)
          
                  else
                      set x = GetUnitX(dummy.unit[i]) - ORB_LASER_SPEED * Cos(facing*0.01747)
                      set y = GetUnitY(dummy.unit[i]) - ORB_LASER_SPEED * Sin(facing*0.01747)
                      call SetUnitPosition(dummy.unit[i],x,y)
                  endif

  ORB_LASER_SPEED * Cos(facing * 0.01747) is a constant. So is the one multiplied by sin. Thus, you can actually make two real members of the struct and store those:
  

  real offsetX
  real offsetY
  // declare the members in your struct

  In the method onCast, you would define them:
  

  //Set dummies move angle
  set facing = Angle(GetUnitX(dummy.unit[i]),GetUnitY(dummy.unit[i]),o,z)
  //
  set offsetX = ORB_LASER_SPEED * Cos(facing * 0.01747)
  set offsetY = ORB_LASER_SPEED * Sin(facing * 0.01747)

  Or even better:
  

  //Set dummies move angle
  set facing = Angle(GetUnitX(dummy.unit[i]),GetUnitY(dummy.unit[i]),o,z) * 0.01747
  //
  set offsetX = ORB_LASER_SPEED * Cos(facing)
  set offsetY = ORB_LASER_SPEED * Sin(facing)

  Then in the method onPeriodic, you would just use offsetX and offsetY:
  

                  if not fade then
                      set x = GetUnitX(dummy.unit[i]) + offsetX
                      set y = GetUnitY(dummy.unit[i]) + offsetY
                      call SetUnitPosition(dummy.unit[i],x,y)
          
                  else
                      set x = GetUnitX(dummy.unit[i]) - offsetX
                      set y = GetUnitY(dummy.unit[i]) - offsetY
                      call SetUnitPosition(dummy.unit[i],x,y)
                  endif

• In the method filterUnit, you have this line:
  IsUnitEnemy(u, GetTriggerPlayer())
  Since you are checking GetTriggerPlayer() in the timer loop, it might return null (iirc). Instead you should check:
  IsUnitEnemy(u, GetOwningPlayer(caster))

Other than that, it looks good. Another eye-candy spell.

 

[neo_sluf]

nice lightning spell 4/5! +Rep for the good job!