Dummy Ability Problem

[HHOOUUNN]

Anyone want to help me with dummy spells? I want to make soul burn (Drown) become an aoe ability, so i make a dummy trigger for it, but the end result i only get the main target with soul burn, and just another random one nearby, not the whole group

• Drown
  • Events
    • Unit - A unit Begins casting an ability
  • Conditions
    • (Ability being cast) Equal to Drown (Titan)
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Level of Drown (Titan) for (Casting unit)) Equal to 1
      • Then - Actions
        • Unit Group - Pick every unit in (Units within 300.00 of (Position of (Target unit of ability being cast)) matching (((Matching unit) Not equal to (Target unit of ability being cast)) and ((((Matching unit) belongs to an enemy of (Owner of (Casting unit))) Equal to True) and ((((Matching uni and do (Actions)
          • Loop - Actions
            • Unit - Create 1 Object for (Owner of (Casting unit)) at (Position of (Picked unit)) facing (Position of (Picked unit))
            • Unit Group - Add (Last created unit) to ObjectGroupDrown
            • Unit - Add Drown (Object) to (Last created unit)
            • Unit - Order (Last created unit) to Neutral Fire Lord - Soul Burn (Picked unit)
      • Else - Actions

I had the same problem for hurl boulder too

 

[Squiggy]

First, it's full of leaks. Read here about leaks
Second, i can't read the whole conditions for the specified unitgroup

 

[HHOOUUNN]

so my leak here is a unit group leak?

 

[Squiggy]

(Position of (Picked unit)) also leaks
next, could you complete the conditions for the unit group? i think that's the important thing ^^

 

[HHOOUUNN]

Set TargetGroupDrown = (Units within 300.00 of (Position of (Target unit of ability being cast)) matching ((((Matching unit) belongs to an enemy of (Owner of (Casting unit))) Equal to True) and (((Matching unit) Not equal to (Target unit of ability being cast)) and (((Matching unit) is alive) Equal to True)

i checked the condition, it works, just the leaking

EDIT:
thanks for showing me though that there are such things as leaks, i didnt know that would leak so easily first time i was introduced to that. Too bad i dont know how to fix it

Do NOT double-post. Use the Edit Post button.
~Posts Merged

 

[Squiggy]

Well i can fix it for you.. just watch ^^

• Drown
• Events
• Unit - A unit Begins casting an ability
• Conditions
• (Ability being cast) Equal to Drown (Titan)
• Actions
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • (Level of Drown (Titan) for (Casting unit)) Equal to 1
    • Then - Actions
      • Set temppoint = (Postion of (target unit of ability being cast))
      • Custom script: set bj_wantDestroyGroup = true
      • Set TargetGroupDrown = (Units within 300.00 of temppoint matching ((((Matching unit) belongs to an enemy of (Owner of (Casting unit))) Equal to True) and (((Matching unit) Not equal to (Target unit of ability being cast)) and (((Matching unit) is alive) Equal to True)
    • Unit Group - Pick every unit in TargetGroupDrown and do (Actions)
      • Loop - Actions
        • Unit - Create 1 Object for (Owner of (Casting unit)) at temppoint1 facing (Picked Unit)
        • Unit Group - Add (Last created unit) to ObjectGroupDrown
        • Unit - Add a x second standard expiration timer to (Last created unit)
        • Unit - Add Drown (Object) to (Last created unit)
        • Unit - Order (Last created unit) to Neutral Fire Lord - Soul Burn (Picked unit)
    • Else - Actions
  • Custom script - call RemoveLocation(udg_temppoint)
  • Custom script - call DestroyGroup(udg_tempgroup)

You just have to fill in the x with the value you want the dummy to be 'alive'

/shall be ok now..

 

[Need_O2]

1- LEARN ABOUT THE F**CING bj_wantDestroyGroup
2- You destroy group inside loop which will cause thread crash in second time run

And you check your conditions, soul burn mana cost and things like that
"Matching unit is not equal to target unit of ability being cast" ? whats that

 

[Squiggy]

But wait - This tells me as far as i understand that i don't have to write set bj_wantDestroyGroup = true.. or am i wrong?

 

[NeC-ChRiSSi]

Why do you do it then ?

 

[Need_O2]

u dont have to use variable stuff while there is bj_wantDestroyGroup

 

[jareph]

HHOOUUNN u wan only 1 unit in unit group?

• Set UnitGroup = (Random 1 units from (Units within 512.00 of (Position of (Last created unit))))

Unit group > Random N unit from unit group function.

 

[HHOOUUNN]

nah, all enemy units around the targeted one into that unit group

ima try squiggy's way right now

 

[NeC-ChRiSSi]

Hmm... I could give you my Spell. I got some of them. They only use another Spell which is casted on an enemy.
Problem is that the Units, that cast the spell are not removed, so I hide them.
But they work. I tested it a hundred times^^

 

[HHOOUUNN]

Drown
Events
Unit - A unit Begins casting an ability
Conditions
(Ability being cast) Equal to Drown (Titan)
Actions
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Level of Drown (Titan) for (Casting unit)) Equal to 1
Then - Actions
Set RandomPoint = (Position of (Target unit of ability being cast))
Custom script: set bj_wantDestroyGroup = true
Set TargetGroupDrown = (Units within 300.00 of RandomPoint matching ((((Matching unit) belongs to an enemy of (Owner of (Casting unit))) Equal to True) and (((Matching unit) Not equal to (Target unit of ability being cast)) and (((Matching unit) is alive) Equal to True))))
Unit Group - Pick every unit in TargetGroupDrown and do (Actions)
Loop - Actions
Unit - Create 1 Object for (Owner of (Casting unit)) at RandomPoint facing (Position of (Picked unit))
Unit - Add a 1.50 second Summoned Unit expiration timer to (Last created unit)
Unit Group - Add (Last created unit) to ObjectGroupDrown
Unit - Add Drown (Object) to (Last created unit)
Unit - Order (Last created unit) to Neutral Fire Lord - Soul Burn (Picked unit)
Else - Actions
Custom script: call RemoveLocation(udg_RandomPoint)
Custom script: call DestroyGroup(udg_TargetGroupDrown)

is this seem right to you guys? two targets become soul burned

 

[Squiggy]

it seems BUT are 2 enough? if not i suppose the expirationtimer is too low and the dummy can't cast more than 2 times