1. Are you planning to upload your awesome spell or system to Hive? Please review the rules here.
    Dismiss Notice
  2. Updated Resource Submission Rules: All model & skin resource submissions must now include an in-game screenshot. This is to help speed up the moderation process and to show how the model and/or texture looks like from the in-game camera.
    Dismiss Notice
  3. DID YOU KNOW - That you can unlock new rank icons by posting on the forums or winning contests? Click here to customize your rank or read our User Rank Policy to see a list of ranks that you can unlock. Have you won a contest and still havn't received your rank award? Then please contact the administration.
    Dismiss Notice
  4. We have recently started the 16th edition of the Mini Mapping Contest. The theme is mini RPG. Do check it out and have fun.
    Dismiss Notice
  5. Dismiss Notice
  6. The Highway to Hell has been laid open. Come along and participate in the 5th Special Effect Contest.
    Dismiss Notice
  7. Check out the Staff job openings thread.
    Dismiss Notice
Dismiss Notice
60,000 passwords have been reset on July 8, 2019. If you cannot login, read this.

Doom Fuse

Submitted by JC Helas
This bundle is marked as pending. It has not been reviewed by a staff member yet.
I don't know what to type here :v since reviewer can easily check the codes at "Preview Triggers"

Credits to:
Changelog

Jass:
  • v1.0 -Release
  • v1.0a -Fix Loop Function
  • v1.0b -Fix Loop Conditio
  • -Add More Documentary
  • v1.0c -Fix lightning color
  • v1.0d -Fixed Wave
  • -Remove BJ

vJass
  • v1.0 -Release
  • v1.0a -Fixed Waves
  • -Fixed Filter
  • -Fixed SpellEffectEvent
  • v1.0b -Add Vaccum Effect
  • -Fix Lightning DeIndex
  • -Fix Spell Effect Optionalize
Previews
Contents

Doom Fuse v1.0d Jass (Map)

Doom Fuse v1.0b vJass (Map)

Reviews
MyPad
It was once said that those who dare wander at night will behold an enigmatic and predatory luminescence. It was thought to be a spirit, an impish pixie, an impudent fairy, phantom, or even an alien sighting. As this eerie presence grips its'...
  1. Pyrogasm

    Pyrogasm

    Joined:
    Feb 27, 2007
    Messages:
    3,648
    Resources:
    1
    Spells:
    1
    Resources:
    1
    It's 2019 and vJASS has now been fully integrated into the editor for multiple large patches. I don't think it's too much to ask to take advantage of the simplest features:
    • Encapsulate your spell in a library/scope
    • Use globals blocks instead of relying on a variable creation trigger and GUI variables
    • Use an initializer instead of the default InitTrig_ function, which will break if the trigger is renamed.
     
  2. JC Helas

    JC Helas

    Joined:
    Oct 19, 2014
    Messages:
    127
    Resources:
    3
    Maps:
    1
    Spells:
    2
    Resources:
    3
    Thanks for your wonderful opinion bro but i have to stay on this lvl,, we all starts from gui and I dont think no one has left behind every month or year may have new editor I hope you get what I mean :V,, about the initTrig i guess you have not notice on how it works,, well if ever they change the triggers' name at folder automatically it will change so XD why not try it? Witness how the function change its self.. XD
     
    Last edited: Nov 3, 2019
  3. Pyrogasm

    Pyrogasm

    Joined:
    Feb 27, 2007
    Messages:
    3,648
    Resources:
    1
    Spells:
    1
    Resources:
    1
    There's literally no reason no to use the most basic and simple features that improve accessibility and ease of use for everyone. You're actively making it harder for anyone who wishes to use your resource, and yourself during development. Anyone who doesn't have access to a 1.29+ editor either pirated the game and can't update (ffs it's like $15) or is willingly running an old patch, and in that old patch either WEX or JNGP will still work.
    It never used to do this, it's a new addition to the editor I was unaware of. Thank you.
     
  4. JC Helas

    JC Helas

    Joined:
    Oct 19, 2014
    Messages:
    127
    Resources:
    3
    Maps:
    1
    Spells:
    2
    Resources:
    3
    Its okay bro I rely to the power of "COPY" "PASTE" i guess im not alone XD even how long that perfix are XD
     
  5. MyPad

    MyPad

    Spell Reviewer

    Joined:
    May 9, 2014
    Messages:
    1,338
    Resources:
    7
    Models:
    1
    Icons:
    2
    Spells:
    3
    JASS:
    1
    Resources:
    7
    It was once said that those who dare wander at night will behold an enigmatic and predatory luminescence. It was thought to be a spirit, an impish pixie, an impudent fairy, phantom, or even an alien sighting. As this eerie presence grips its' audience, a woeful song can be heard; the wailing of maidens gone mad, an ear-piercing howl, despair made manifest. Woe to those who wander to these lights, for none shall grant them rest, a requiem that can never know its' end.



    Now, onto the review: (vJASS)
    • In struct
      DoomFuse
      , there is no need to inline
      TriggerRegisterAnyUnitEventBJ
      , since it is only going to be called once.

    • Local variables do not appear to be in camelCase. (This is somewhat minor, so feel free to ignore this)

    • Having SpellEffectEvent and RegisterPlayerUnitEvent appears to be overkill for this spell. (Good thing they're optional).

    • IsUnitType(unit, UNIT_TYPE_DEAD)
      can and should be replaced with
      not UnitAlive(unit)
      .

    • Instead of using raw numbers to indicate wave states, you could use some global variables that will clearly describe the wave state, instead of relying on presumptions made on your end on what each wave state actually is. (This is to aid development down the line when a user wants to modify the spell.)
    It appears that a lot of work will have to be done before approval, so this will be moved to Awaiting Update
     
  6. JC Helas

    JC Helas

    Joined:
    Oct 19, 2014
    Messages:
    127
    Resources:
    3
    Maps:
    1
    Spells:
    2
    Resources:
    3
    :O woaahh,,

    In vJass, that BJ line you mention bro? Hehehe maybe in jass okay i will rid that bj..

    UnitAlive bro? i never seen that native before please bro tell me which one XD

    I dont get what you mean that i have to make it global variable for user to understand the state clearly >_<

    Edit:
    Do you mean bro that i have to write down documentary for each wave?

    Bytheway thanks bro for putting the owners name of those system and reviewing my spell
    -Appreciated
     
    Last edited: Nov 7, 2019
  7. MyPad

    MyPad

    Spell Reviewer

    Joined:
    May 9, 2014
    Messages:
    1,338
    Resources:
    7
    Models:
    1
    Icons:
    2
    Spells:
    3
    JASS:
    1
    Resources:
    7
    It is just
    UnitAlive
    . To declare such a native, copy and paste the following line:
    native UnitAlive takes unit id returns boolean


    There's no need to write a long documentary on what each wave state means. It can be done like this.

    Code (vJASS):

    // Extra code
    if this.wave == WAVE_PHASE_ONE then
        //Insert code here
        //Insert some condition when proceeding to another phase.
        set this.wave = WAVE_PHASE_TWO
    elseif this.wave == WAVE_PHASE_TWO then
       // Extra code
    endif
    // Extra code
     


    Those are just examples of naming each wave state. You can think of names better than the example at conveying the mode.

    No, that would not be necessary. There's no need to copy and paste what the function already does to save performance at a point where it isn't necessary to do so (It will only be called once, on map initialization, so it would just be inconvenient). I am suggesting the opposite, to use that BJ (
    TriggerRegisterAnyUnitEventBJ
    ) in the vJASS version, for the reason stated above.
     
  8. JC Helas

    JC Helas

    Joined:
    Oct 19, 2014
    Messages:
    127
    Resources:
    3
    Maps:
    1
    Spells:
    2
    Resources:
    3
    the spell has been updated,, if you include to add those libraries for 1.31 well i dont have,, my warcraft is still 1.27b,, i wish to update but we dont have wifi now a days,, i should wait until we have..
     
  9. JC Helas

    JC Helas

    Joined:
    Oct 19, 2014
    Messages:
    127
    Resources:
    3
    Maps:
    1
    Spells:
    2
    Resources:
    3
    Bro its update