[JASS] Does this leak?

[Geshishouhu]

Hi guys, does the following code leak?

function Trig_hInitializingActions takes nothing returns nothing
    local group g
    set g = CreatingSomeGroup
    call ForGroup(g, function callback)
    set g = CreatingSomeOtherGroup
    call ForGroup(g, function callback)
    call DestroyGroup(g)
    set g = null
endfunction

Or should I do this?

function Trig_hInitializingActions takes nothing returns nothing
    local group g1 = CreatingSomeGroup
    local group g2 = CreatingSomeOtherGroup
    call ForGroup(g1, function callback)
    call DestroyGroup(g1)
    call ForGroup(g2, function callback)
    call DestroyGroup(g2)
    set g1 = null
    set g2 = null
endfunction

 

[IcemanBo]

If you don't use function CreateGroup() in your function you can't say if you leak or not, because then obviosuly SomeGroup and SomeOtherGroup are globals.
And we can't see what else you would do with your globals.

But if you create groups in your function, then your 1st example would leak.

Anyway you would not need two local groups, you also could do:

function Trig_hInitializingActions takes nothing returns nothing
    local group myGroup = SomeGroup

    call ForGroup(myGroup, function callback)
    call DestroyGroup(myGroup)

    set myGroup = SomeOtherGroup
    call ForGroup(myGroup, function callback)
    call DestroyGroup(myGroup)

    set myGroup = null
endfunction

 

[Vinz]

^This. Groups only leak if you Create them without destroying the previous. The memory is irretrievable AFAIK.

GroupClear might be useful in related circumstances.

 

[Geshishouhu]

Thanks for the replies. I edited my first post to clear up confusion.
Anyway, thanks.

 

[IcemanBo]

So you don't know yet if you leak or not? If so, read my 1st post again.

Btw, instead of CreatingSomeOtherGroup you just could write CreateGroup().

 

[Geshishouhu]

So you don't know yet if you leak or not? If so, read my 1st post again.

Btw, instead of CreatingSomeOtherGroup you just could write CreateGroup().

Got it, thnx. +Rep